From patchwork Thu Feb 27 03:41:29 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: 76824143@qq.com X-Patchwork-Id: 13993678 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC69DC021BE for ; Thu, 27 Feb 2025 03:48:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 421EA280001; Wed, 26 Feb 2025 22:48:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D23F6B0089; Wed, 26 Feb 2025 22:48:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29961280001; Wed, 26 Feb 2025 22:48:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 071AD6B0088 for ; Wed, 26 Feb 2025 22:48:28 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7A72AC02FA for ; Thu, 27 Feb 2025 03:48:27 +0000 (UTC) X-FDA: 83164342254.12.4E0C0FE Received: from out203-205-221-164.mail.qq.com (out203-205-221-164.mail.qq.com [203.205.221.164]) by imf28.hostedemail.com (Postfix) with ESMTP id E9BC4C0004 for ; Thu, 27 Feb 2025 03:48:24 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=qq.com header.s=s201512 header.b=TwCCQCKw; spf=pass (imf28.hostedemail.com: domain of 76824143@qq.com designates 203.205.221.164 as permitted sender) smtp.mailfrom=76824143@qq.com; dmarc=pass (policy=quarantine) header.from=qq.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740628105; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=jLYzyOL3keatVd3SZhOXBi+1WbU0yvjvUS0YqE0Jt98=; b=Rhje2Ppa89uqjuhMcvQ4ZpI8HWSx42oHcQmvzaTkrOiYZZSToCLKjKl24GaAeLsmHiVyu8 Md70y09Osh10McRFRfsixVvGmpkD3Bb/c/YepGKLXYT5wcOycfYyEVpIm2/GHsdKyGSKPo j/HQZnMQuzuxWVDCUIAMHoGDPxwltEg= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=qq.com header.s=s201512 header.b=TwCCQCKw; spf=pass (imf28.hostedemail.com: domain of 76824143@qq.com designates 203.205.221.164 as permitted sender) smtp.mailfrom=76824143@qq.com; dmarc=pass (policy=quarantine) header.from=qq.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740628105; a=rsa-sha256; cv=none; b=bplUiIPRT98kLUKHQ4LT7b4Kc2vc+yod6jc+jR2fdyng0wCeZIHRRfvmtG4eJUnoNV4Cq3 20beDVgdiGnVHh6cfM2rMm2FaoGVJ5NAhHx7nPCTe1Sg6EiiDxVOitq7E5TZlt7Awz7qoh yhAUVWIq9jEq+WV8HjDR/6OExwrA7ck= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1740628094; bh=jLYzyOL3keatVd3SZhOXBi+1WbU0yvjvUS0YqE0Jt98=; h=From:To:Cc:Subject:Date; b=TwCCQCKwMbmowubNDOg9uPxXslhgTQfHjsaSxXuIWFsevAn6AV/sOltlUQlfKPAfW 2/Hixl30Mf8bvckr593gVs7UtxN475z9N9r8GfQ/e5T2gind5ijKsWW1utPq4pdFIe UGGOLwD+I921znWcmj7TdvducyewFc5hvOc03ZC4= Received: from localhost.localdomain ([116.128.244.169]) by newxmesmtplogicsvrszb16-1.qq.com (NewEsmtp) with SMTP id A7985A7C; Thu, 27 Feb 2025 11:41:57 +0800 X-QQ-mid: xmsmtpt1740627717tzl59ecjz Message-ID: X-QQ-XMAILINFO: MVlKP0emjWgkeMAQlF5IYEEvmDIt4Ww/1lbsE2eAaFTDD1pbVKYcV7ZWex/DZd gErN54EtfnbMyRp4aaFkf7o4nAqFEnC0txpZ7kXxFQ7qY4/UkcMbRyIukzNt7q5RgzdF3fdqPSw7 /r0ZzkQ+9hGReY3BYQSqhm+rJ2R+di2POURwu2ZkInAUdxQVhP/FE0KZe9wKCxfhQWuCaP9fkyTm P9VPr6uwlPXyZoMtf6ooYMqP+debxKQTjVf0pbwRfpnzyK52deAOumiFB1XCrMfc2kNTznUUJ6Pi /9kkC6LcdhQwTPN1taCFmi5jmc4Msc2ex8URaLGMyh726XORZE9F3aSW2B06v2+Oe/mpCIVKlwB2 LYM8FE7uMOrm4Gi0aPEPNxWE8ZUcbqw0eLDfPw1B7nvSJKlVQz+Ek9b734ONkDDXTX4fAWZxY+jm /kXPbCdlww1guGDtmdMdb8meMa9SmfhScL0LPsk1b5Q9eRSnDsYO31fbds3aQga+Mub49krv+FW0 acce1U1NsaUEqixNgy5uMmLV/q4/NTtBKtJv7zhnB8MHnecahG/5HgZcvcQE0MuTU5pmeKWMlQvo T0f7+S2HE1UqB/mZJYoP7c5coej1kJjykLxVctP029YNmHXJz99IWaHb7COPC5b/5ZJUaVUmCw5g F4YQQV6sQqRNc4uhgD1hxaJvfWHG6j1JWlEaXPmgrYe63sZWG65NMcUEHLRqMIxSNUY1WY4YpzAw QqXjaRL19shHXZFrIupLzrlxPGKtYw1UTsmBwwfKsAlFI3AozGbYFwo036xYrt0wVc054QKXQxd5 ZofHElzSphpHvKKa+I/UYLNpZSQsNpE52CO20frkM29OsRnhFbRzEOIhQh4lt2Hjo+sGF+8CtJhv ZFH9ssW3+OqwTJBuox4Ovhg+5D8eXfEa9jSF+A5LgsETiKtp/9LLkHicOmv1F+SWaOEmGCz41wN2 ZK0DpTmGQzVyMNa3ElCA== X-QQ-XMRINFO: OJlEh3abS6gXi5NWrXbD0WI= From: 76824143@qq.com To: akpm@linux-foundation.org, vbabka@suse.cz Cc: linux-mm@kvack.org, Hao Zhang , syzbot+0cfd5e38e96a5596f2b6@syzkaller.appspotmail.com Subject: [PATCH v2] mm/page_alloc: Fix uninitialized variable Date: Thu, 27 Feb 2025 11:41:29 +0800 X-OQ-MSGID: <20250227034129.77154-1-76824143@qq.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E9BC4C0004 X-Stat-Signature: j44oieype8qo9h3wf39wopbqjw4cu9qc X-Rspam-User: X-HE-Tag: 1740628104-510246 X-HE-Meta: U2FsdGVkX18iPT4N8dnWxuGpazeY6Nw7pJ3Snbr0CPQvCdiGJGHE2kdg5WxBmRIrVfBxl+VdUcrCkko+ZhBSBgYU7pNUukZmTzbcFxnbYBS8mtQHpANRvGNEannDPBIee9RQi5NXFHSD9QtpQkvEVu2Z8X5G4qiQKbACNDTEP1mYYNUnEcDRqG0varg4h5wFQvhscDFYEOL/72Bjo1kPyu7L0vcxgi/keiLClxAr+GEVbYvnolRvDqhis0e3uKRWKiN0tB6vEUPmB8epyZF5U9V8feDDMdjN7QAfoZ5uXtGP/t4L44BeiIzeSlOLyx3RYXgPlP4M6PFCR6Jx84i83qRrj/ReKjwFIv0DdXoGAuOK+Hf6h9NYKDfVoQAjHMsZhfv2TK4CQwCwHKG5diq1l8ASOKV2q+4dpbiv9pwi5sHUVxOZcMVxmY/RiIX8zkKVQJv5ByQTniv5QiyDmb85K+6fPojTzLxU51OaGGxYnVERZpBtJtr0OC+C3v5Nc9OJYB+SIUmhuRGnwsMmVbQbxFmNukYoBi67A/Qj45yiRryKGHppsL6Oa/U7p1e9sLjMByC0K+J5oskvSh15W8ET6PCcri6TUq8kc8y8pf2xQ5j33bvAdJIptsJsXZrjl1VzpUEmhIIdw3118qYzQOuif4oxiw1CJETdAEswsdulyuHFdwf1sUnx9jRVYqJbePpWSs/kgRBqKmHurYbMnnVaHmVceQcjXKHmKU5ECY+0IprW/QhnXo7DYCpHsc2+z0aQ6EFwubG16700ugYCr6+lX2+mcRne1FGEIz5mYfLltk9/Uo9kAjb7L4boR737DDjKSQzGAvD6Bm0jgzx8B72nsq9NDpl+lJStAP7ZvNIbJrQj+8R4CAUeUDGAdDR+JiBUOfQFBKHQY+vN4JbEWcsueFl7Q7sAYrGXSVL220Pxj5hgFKPDLudiDgPYb6E8/d+1/HGDBgu6wqDAp7IIuRZ IO4OsRXX B3uFToNGKx2TSjIoCxS8hqj7EpKJ8cJAefSWO/I5H1vVp4C1ffOIImfHX59ECRYXuFLLtBRWnAclyQFCz0PeXtihqoShXmoJvHT6+Yv7pxtrNyNfnzCedEAz0g5KF7eQ+Lp9QYHYhLIlfo6P6mmS0mQdxcDfbjjFDoFElCU8xdHoFgIY1Y1KKjKsoq6vW0Zp+caEurQIkj/YZIkSO4Ty7LfXNM8+6Yf8hOZClXZj2EphabAIjeJ7S/77o49kVUBgyC90zmXeZr5TOdjO5bbHQBgLc+6iLHdVLAgnWW+w/wMWnPmH4DOp5t1B7HChMxPMhvseDkbYvOkHZJoAsJrk31HngSYRvZ3az8ktQEkbW6DwuaX+qgTb4WRlQpz/D0kpslM2J/KGKA9sHtMGDi2/hnebn7A8K7GDuMMBc3wk5IQgJlbxxJjY0Fdn/ztGl4uY7iBsHCaYTa6W8K6U+BMI32Y+jyg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000370, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Hao Zhang The variable "compact_result" is not initialized in function __alloc_pages_slowpath(). It causes should_compact_retry() to use an uninitialized value. Initialize variable "compact_result" with the value COMPACT_SKIPPED. BUG: KMSAN: uninit-value in __alloc_pages_slowpath+0xee8/0x16c0 mm/page_alloc.c:4416 __alloc_pages_slowpath+0xee8/0x16c0 mm/page_alloc.c:4416 __alloc_frozen_pages_noprof+0xa4c/0xe00 mm/page_alloc.c:4752 alloc_pages_mpol+0x4cd/0x890 mm/mempolicy.c:2270 alloc_frozen_pages_noprof mm/mempolicy.c:2341 [inline] alloc_pages_noprof mm/mempolicy.c:2361 [inline] folio_alloc_noprof+0x1dc/0x350 mm/mempolicy.c:2371 filemap_alloc_folio_noprof+0xa6/0x440 mm/filemap.c:1019 __filemap_get_folio+0xb9a/0x1840 mm/filemap.c:1970 grow_dev_folio fs/buffer.c:1039 [inline] grow_buffers fs/buffer.c:1105 [inline] __getblk_slow fs/buffer.c:1131 [inline] bdev_getblk+0x2c9/0xab0 fs/buffer.c:1431 getblk_unmovable include/linux/buffer_head.h:369 [inline] ext4_getblk+0x3b7/0xe50 fs/ext4/inode.c:864 ext4_bread_batch+0x9f/0x7d0 fs/ext4/inode.c:933 __ext4_find_entry+0x1ebb/0x36c0 fs/ext4/namei.c:1627 ext4_lookup_entry fs/ext4/namei.c:1729 [inline] ext4_lookup+0x189/0xb40 fs/ext4/namei.c:1797 __lookup_slow+0x538/0x710 fs/namei.c:1793 lookup_slow+0x6a/0xd0 fs/namei.c:1810 walk_component fs/namei.c:2114 [inline] link_path_walk+0xf29/0x1420 fs/namei.c:2479 path_openat+0x30f/0x6250 fs/namei.c:3985 do_filp_open+0x268/0x600 fs/namei.c:4016 do_sys_openat2+0x1bf/0x2f0 fs/open.c:1428 do_sys_open fs/open.c:1443 [inline] __do_sys_openat fs/open.c:1459 [inline] __se_sys_openat fs/open.c:1454 [inline] __x64_sys_openat+0x2a1/0x310 fs/open.c:1454 x64_sys_call+0x36f5/0x3c30 arch/x86/include/generated/asm/syscalls_64.h:258 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x1e0 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f Local variable compact_result created at: __alloc_pages_slowpath+0x66/0x16c0 mm/page_alloc.c:4218 __alloc_frozen_pages_noprof+0xa4c/0xe00 mm/page_alloc.c:4752 Reported-by: syzbot+0cfd5e38e96a5596f2b6@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=0cfd5e38e96a5596f2b6 Signed-off-by: Hao Zhang Reviewed-by: Vlastimil Babka --- v2: Init variable "compact_result" in __alloc_pages_slowpath() mm/page_alloc.c | 1 + 1 file changed, 1 insertion(+) base-commit: d082ecbc71e9e0bf49883ee4afd435a77a5101b6 diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 579789600a3c..424731333276 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -4243,6 +4243,7 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, restart: compaction_retries = 0; no_progress_loops = 0; + compact_result = COMPACT_SKIPPED; compact_priority = DEF_COMPACT_PRIORITY; cpuset_mems_cookie = read_mems_allowed_begin(); zonelist_iter_cookie = zonelist_iter_begin();