| Message ID | 1560421215-10750-1-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | treewide: improve R-Car SDHI performance | expand |
On Thu, Jun 13, 2019 at 07:20:10PM +0900, Yoshihiro Shimoda wrote: > This patch series is based on iommu.git / next branch. > > Since SDHI host internal DMAC of the R-Car Gen3 cannot handle two or > more segments, the performance rate (especially, eMMC HS400 reading) > is not good. However, if IOMMU is enabled on the DMAC, since IOMMU will > map multiple scatter gather buffers as one contignous iova, the DMAC can > handle the iova as well and then the performance rate is possible to > improve. In fact, I have measured the performance by using bonnie++, > "Sequential Input - block" rate was improved on r8a7795. > > To achieve this, this patch series modifies IOMMU and Block subsystem > at first. Since I'd like to get any feedback from each subsystem whether > this way is acceptable for upstream, I submit it to treewide with RFC. > > Changes from v5: > - Almost all patches are new code. > - [4/5 for MMC] This is a refactor patch so that I don't add any > {Tested,Reviewed}-by tags. > - [5/5 for MMC] Modify MMC subsystem to use bigger segments instead of > the renesas_sdhi driver. > - [5/5 for MMC] Use BLK_MAX_SEGMENTS (128) instead of local value > SDHI_MAX_SEGS_IN_IOMMU (512). Even if we use BLK_MAX_SEGMENTS, > the performance is still good. Thanks for your hard work, Shimoda-san! I may not be the biggest DMA, IOMMU, and block layer expert, but I really like how this simplifies the SDHI driver and enhances the MMC core. So, I'll add my two cents to the patches although I can't really comment on the main functionality.
This patch series is based on iommu.git / next branch. Since SDHI host internal DMAC of the R-Car Gen3 cannot handle two or more segments, the performance rate (especially, eMMC HS400 reading) is not good. However, if IOMMU is enabled on the DMAC, since IOMMU will map multiple scatter gather buffers as one contignous iova, the DMAC can handle the iova as well and then the performance rate is possible to improve. In fact, I have measured the performance by using bonnie++, "Sequential Input - block" rate was improved on r8a7795. To achieve this, this patch series modifies IOMMU and Block subsystem at first. Since I'd like to get any feedback from each subsystem whether this way is acceptable for upstream, I submit it to treewide with RFC. Changes from v5: - Almost all patches are new code. - [4/5 for MMC] This is a refactor patch so that I don't add any {Tested,Reviewed}-by tags. - [5/5 for MMC] Modify MMC subsystem to use bigger segments instead of the renesas_sdhi driver. - [5/5 for MMC] Use BLK_MAX_SEGMENTS (128) instead of local value SDHI_MAX_SEGS_IN_IOMMU (512). Even if we use BLK_MAX_SEGMENTS, the performance is still good. https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=127511 Changes from v4: - [DMA MAPPING] Add a new device_dma_parameters for iova contiguous. - [IOMMU] Add a new capable for "merging" segments. - [IOMMU] Add a capable ops into the ipmmu-vmsa driver. - [MMC] Sort headers in renesas_sdhi_core.c. - [MMC] Remove the following codes that made on v3 that can be achieved by DMA MAPPING and IOMMU subsystem: -- Check if R-Car Gen3 IPMMU is used or not on patch 3. -- Check if all multiple segment buffers are aligned to PAGE_SIZE on patch 3. https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=125593 Changes from v3: - Use a helper function device_iommu_mapped on patch 1 and 3. - Check if R-Car Gen3 IPMMU is used or not on patch 3. - Check if all multiple segment buffers are aligned to PAGE_SIZE on patch 3. - Add Reviewed-by Wolfram-san on patch 1 and 2. Note that I also got his Reviewed-by on patch 3, but I changed it from v2. So, I didn't add his Reviewed-by at this time. https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=120985 Changes from v2: - Add some conditions in the init_card(). - Add a comment in the init_card(). - Add definitions for some "MAX_SEGS". https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=116729 Changes from v1: - Remove adding init_card ops into struct tmio_mmc_dma_ops and tmio_mmc_host and just set init_card on renesas_sdhi_core.c. - Revise typos on "mmc: tmio: No memory size limitation if runs on IOMMU". - Add Simon-san's Reviewed-by on a tmio patch. https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=110485 Yoshihiro Shimoda (5): iommu: add an exported function to get minimum page size for a domain block: sort headers on blk-setting.c block: add a helper function to merge the segments by an IOMMU mmc: tmio: Use dma_max_mapping_size() instead of a workaround mmc: queue: Use bigger segments if IOMMU can merge the segments block/blk-settings.c | 40 ++++++++++++++++++++++++++++++++++------ drivers/iommu/iommu.c | 18 +++++++++++++++--- drivers/mmc/core/queue.c | 33 +++++++++++++++++++++++++++++---- drivers/mmc/host/tmio_mmc_core.c | 17 ++++------------- include/linux/blkdev.h | 2 ++ include/linux/iommu.h | 1 + include/linux/mmc/host.h | 1 + 7 files changed, 86 insertions(+), 26 deletions(-)