mbox series

[PATCH/RFC,v2,0/2] treewide: fix _mmc_suspend() on PSCI

Message ID 1592566143-4546-1-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive)
Headers show
Series treewide: fix _mmc_suspend() on PSCI | expand

Message

Yoshihiro Shimoda June 19, 2020, 11:29 a.m. UTC 
We can detect whether the system is going to suspend by using
pm_suspend_via_firmware() API. So, this patch series update
both PSCI and MMC driver for my environment (r8a77951-salvator-xs).

We can apply these patches to each subsystem. I believe this is
a correct way, but I still mark RFC now...

Changes from v1:
 - Use pm_suspend_via_firmware() API instead of pm_suspend_target_state.
 - Modify the psci driver to call pm_set_suspend_via_firmware.
 https://patchwork.kernel.org/patch/11557505/

Yoshihiro Shimoda (2):
  firmware: psci: call pm_set_suspend_via_firmware()
  mmc: core: Call mmc_power_off_nofity() if pm_suspend_via_firmware()

 drivers/firmware/psci/psci.c | 8 ++++++++
 drivers/mmc/core/mmc.c       | 4 +++-
 2 files changed, 11 insertions(+), 1 deletion(-)

Comments

Geert Uytterhoeven June 19, 2020, 2:51 p.m. UTC | #1 
Hi Shimoda-san,

On Fri, Jun 19, 2020 at 2:42 PM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> We can detect whether the system is going to suspend by using
> pm_suspend_via_firmware() API. So, this patch series update
> both PSCI and MMC driver for my environment (r8a77951-salvator-xs).

Cool, didn't know about pm_set_.*_via_firmware().

Looks like this can be used in the clock and pin control drivers, too.
Currently they're checking for !psci_ops.cpu_suspend.

Gr{oetje,eeting}s,

                        Geert