mbox series

[v2,0/3] mmc: sdhi: improve HS400 quirk handling

Message ID 20190606113537.8869-1-wsa+renesas@sang-engineering.com (mailing list archive)
Headers show
Series mmc: sdhi: improve HS400 quirk handling | expand

Message

Wolfram Sang June 6, 2019, 11:35 a.m. UTC
There are some more SoCs which cannot handle HS400. Add them and clean up the
quirk handling a bit. So, patch 1 is suitable for stable, the rest isn't.

Note that I don't have that HW, so I am relying on the provided information.

Changes since v1 (thanks Geert and Fabrizio!):
	* use '[012]' to specify the range instead of single entries
	* add RZ/G2M to the list

Wolfram Sang (3):
  mmc: sdhi: disallow HS400 for M3-W ES1.2, RZ/G2M, and V3H
  mmc: sdhi: improve quirk descriptions
  mmc: sdhi: remove unneeded initialization

 drivers/mmc/host/renesas_sdhi_core.c | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

Comments

Niklas Söderlund June 10, 2019, 12:48 p.m. UTC | #1
Hi (again) Wolfram,

I now see there was a v2 of this series which addressed Geert's 
comments. Sorry for missing this and replying to v1. For the whole 
series,

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

On 2019-06-06 13:35:34 +0200, Wolfram Sang wrote:
> There are some more SoCs which cannot handle HS400. Add them and clean up the
> quirk handling a bit. So, patch 1 is suitable for stable, the rest isn't.
> 
> Note that I don't have that HW, so I am relying on the provided information.
> 
> Changes since v1 (thanks Geert and Fabrizio!):
> 	* use '[012]' to specify the range instead of single entries
> 	* add RZ/G2M to the list
> 
> Wolfram Sang (3):
>   mmc: sdhi: disallow HS400 for M3-W ES1.2, RZ/G2M, and V3H
>   mmc: sdhi: improve quirk descriptions
>   mmc: sdhi: remove unneeded initialization
> 
>  drivers/mmc/host/renesas_sdhi_core.c | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)
> 
> -- 
> 2.11.0
>
Ulf Hansson June 10, 2019, 4:17 p.m. UTC | #2
On Thu, 6 Jun 2019 at 13:35, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> There are some more SoCs which cannot handle HS400. Add them and clean up the
> quirk handling a bit. So, patch 1 is suitable for stable, the rest isn't.
>
> Note that I don't have that HW, so I am relying on the provided information.
>
> Changes since v1 (thanks Geert and Fabrizio!):
>         * use '[012]' to specify the range instead of single entries
>         * add RZ/G2M to the list
>
> Wolfram Sang (3):
>   mmc: sdhi: disallow HS400 for M3-W ES1.2, RZ/G2M, and V3H
>   mmc: sdhi: improve quirk descriptions
>   mmc: sdhi: remove unneeded initialization
>
>  drivers/mmc/host/renesas_sdhi_core.c | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)
>

Applied patch 1 for fixes and by adding a stable tag, the rest is
applied for next, thanks!

Kind regards
Uffe