| Message ID | 20201110162151.37622-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mmc: renesas_sdhi: refactor SCC reset | expand |
Hi Wolfram, Thanks for your work. On 2020-11-10 17:21:48 +0100, Wolfram Sang wrote: > So, after some preparations, we can take the next step and improve > resetting the SCC. Patch #1 is a fix requested by the BSP team to be > more robust in case the firmware did something unexpected before. > Patches #2 and #3 are cleanups made possible after patch #1. > > Patches have been tested on a Renesas Salvator-XS (R-Car M3-N) and a > Renesas Lager (R-Car H2) board. > > A note to Shimoda-san: I did not forget that the BSP team also suggested > to use the SRCR3 register for a reset in probe(). However, it appears > there is more to discuss there. This is why I decided to send out this > series first because we want to have it anyhow. I'll send the SRCR3 > RFC-patch later this week. > > This series depends on the just sent out series "[RFC PATCH 0/4] mmc: > renesas_sdhi: reset SCC only when available". A branch (with some more > extras) can be found here: > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/tap_en_v2 For the whole series, Tested-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > All the best, > > Wolfram > > > Wolfram Sang (3): > mmc: renesas_sdhi: clear TAPEN when resetting, too > mmc: renesas_sdhi: merge the SCC reset functions > mmc: renesas_sdhi: remove superfluous SCLKEN > > drivers/mmc/host/renesas_sdhi_core.c | 19 +++++-------------- > 1 file changed, 5 insertions(+), 14 deletions(-) > > -- > 2.28.0 >
Hi Wolfram-san, Thank you for the patch! > From: Wolfram Sang, Sent: Wednesday, November 11, 2020 1:22 AM > > So, after some preparations, we can take the next step and improve > resetting the SCC. Patch #1 is a fix requested by the BSP team to be > more robust in case the firmware did something unexpected before. > Patches #2 and #3 are cleanups made possible after patch #1. > > Patches have been tested on a Renesas Salvator-XS (R-Car M3-N) and a > Renesas Lager (R-Car H2) board. > > A note to Shimoda-san: I did not forget that the BSP team also suggested > to use the SRCR3 register for a reset in probe(). However, it appears > there is more to discuss there. This is why I decided to send out this > series first because we want to have it anyhow. I'll send the SRCR3 > RFC-patch later this week. I got it. > This series depends on the just sent out series "[RFC PATCH 0/4] mmc: > renesas_sdhi: reset SCC only when available". A branch (with some more > extras) can be found here: > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/tap_en_v2 Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Also, I tested on Salvator-XS (R-Car H3 and M3-W+). So, Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda
On Tue, 10 Nov 2020 at 17:22, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > So, after some preparations, we can take the next step and improve > resetting the SCC. Patch #1 is a fix requested by the BSP team to be > more robust in case the firmware did something unexpected before. > Patches #2 and #3 are cleanups made possible after patch #1. > > Patches have been tested on a Renesas Salvator-XS (R-Car M3-N) and a > Renesas Lager (R-Car H2) board. > > A note to Shimoda-san: I did not forget that the BSP team also suggested > to use the SRCR3 register for a reset in probe(). However, it appears > there is more to discuss there. This is why I decided to send out this > series first because we want to have it anyhow. I'll send the SRCR3 > RFC-patch later this week. > > This series depends on the just sent out series "[RFC PATCH 0/4] mmc: > renesas_sdhi: reset SCC only when available". A branch (with some more > extras) can be found here: > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/tap_en_v2 > > All the best, > > Wolfram > > > Wolfram Sang (3): > mmc: renesas_sdhi: clear TAPEN when resetting, too > mmc: renesas_sdhi: merge the SCC reset functions > mmc: renesas_sdhi: remove superfluous SCLKEN > > drivers/mmc/host/renesas_sdhi_core.c | 19 +++++-------------- > 1 file changed, 5 insertions(+), 14 deletions(-) > > -- > 2.28.0 > Applied for next, thanks! Kind regards Uffe