mbox series

[RFT,0/2] mmc: tmio: make resets more robust

Message ID 20210316085717.7276-1-wsa+renesas@sang-engineering.com (mailing list archive)
Headers show
Series mmc: tmio: make resets more robust | expand

Message

Wolfram Sang March 16, 2021, 8:57 a.m. UTC
Here are two more patches improving the robustness of resetting the IP
core. Patches are on top of mmc/next and this series "[PATCH v2 0/3]
mmc: renesas_sdhi: reset via reset controller", especially "[PATCH v2
1/3] mmc: tmio: abort DMA before reset".

Tested on Salvator-XS with H3 ES2.0 and M3-N. A branch for testing can
be found here:

git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/for-5.13

Some additional testing by Shimoda-san or the BSP team would be much
appreciated!

   Wolfram


Takeshi Saito (1):
  mmc: tmio: restore bus width when resetting

Wolfram Sang (1):
  mmc: tmio: always flag retune when resetting and a card is present

 drivers/mmc/host/tmio_mmc_core.c | 37 +++++++++++++++++---------------
 1 file changed, 20 insertions(+), 17 deletions(-)

Comments

Yoshihiro Shimoda March 23, 2021, 1:09 p.m. UTC | #1
Hi Wolfram-san,

> From: Wolfram Sang, Sent: Tuesday, March 16, 2021 5:57 PM
> 
> Here are two more patches improving the robustness of resetting the IP
> core. Patches are on top of mmc/next and this series "[PATCH v2 0/3]
> mmc: renesas_sdhi: reset via reset controller", especially "[PATCH v2
> 1/3] mmc: tmio: abort DMA before reset".
> 
> Tested on Salvator-XS with H3 ES2.0 and M3-N. A branch for testing can
> be found here:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/for-5.13
> 
> Some additional testing by Shimoda-san or the BSP team would be much
> appreciated!

Thank you for the patch!

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

And, I tested on H3 ES3.0 and then I didn't observe any regression.
So,

Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda
Ulf Hansson March 24, 2021, 10:20 a.m. UTC | #2
On Tue, 16 Mar 2021 at 09:58, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> Here are two more patches improving the robustness of resetting the IP
> core. Patches are on top of mmc/next and this series "[PATCH v2 0/3]
> mmc: renesas_sdhi: reset via reset controller", especially "[PATCH v2
> 1/3] mmc: tmio: abort DMA before reset".
>
> Tested on Salvator-XS with H3 ES2.0 and M3-N. A branch for testing can
> be found here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/for-5.13
>
> Some additional testing by Shimoda-san or the BSP team would be much
> appreciated!
>
>    Wolfram
>
>
> Takeshi Saito (1):
>   mmc: tmio: restore bus width when resetting
>
> Wolfram Sang (1):
>   mmc: tmio: always flag retune when resetting and a card is present
>
>  drivers/mmc/host/tmio_mmc_core.c | 37 +++++++++++++++++---------------
>  1 file changed, 20 insertions(+), 17 deletions(-)
>

Applied for next, thanks!

Kind regards
Uffe