| Message ID | 20210624151616.38770-1-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mmc: avoid vicious circle when retuning | expand |
On 24/06/21 6:16 pm, Wolfram Sang wrote: > See patch 1 for a description of the problem. This series implements the > alternative approach suggested by Adrian (thanks!). It also adds some > documentation and a minor cleanup which I came up with while working on > the fix. Patch 1 can go to stable as is, the rest built on top of that. > > This series fixes the performance issue which we saw when injecting CRC > errors on Renesas R-Car Gen3 hardware. > > Looking forward to comments! Looks good to me. For all 3 patches: Acked-by: Adrian Hunter <adrian.hunter@intel.com> > > > Wolfram Sang (3): > mmc: core: clear flags before allowing to retune > mmc: host: add kdoc for mmc_retune_{en|dis}able > mmc: host: factor out clearing the retune state > > drivers/mmc/core/core.c | 6 ++++-- > drivers/mmc/core/host.c | 13 +++++++++++-- > drivers/mmc/core/host.h | 6 ++++++ > 3 files changed, 21 insertions(+), 4 deletions(-) >
Hi Wolfram-san, Thank you for the patches! > From: Wolfram Sang, Sent: Friday, June 25, 2021 12:16 AM > > See patch 1 for a description of the problem. This series implements the > alternative approach suggested by Adrian (thanks!). It also adds some > documentation and a minor cleanup which I came up with while working on > the fix. Patch 1 can go to stable as is, the rest built on top of that. Perhaps, we can add a Fixes tag into the patch 1 like below? Fixes: bd11e8bd03ca ("mmc: core: Flag re-tuning is needed on CRC errors") > This series fixes the performance issue which we saw when injecting CRC > errors on Renesas R-Car Gen3 hardware. > > Looking forward to comments! The patches look good to me. So, Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> And, I tested on my environment (r8a77951-salvator-xs) with local error injection, and the performance issue disappeared. So, Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Best regards, Yoshihiro Shimoda
On Thu, 24 Jun 2021 at 17:16, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > See patch 1 for a description of the problem. This series implements the > alternative approach suggested by Adrian (thanks!). It also adds some > documentation and a minor cleanup which I came up with while working on > the fix. Patch 1 can go to stable as is, the rest built on top of that. > > This series fixes the performance issue which we saw when injecting CRC > errors on Renesas R-Car Gen3 hardware. > > Looking forward to comments! > > > Wolfram Sang (3): > mmc: core: clear flags before allowing to retune > mmc: host: add kdoc for mmc_retune_{en|dis}able > mmc: host: factor out clearing the retune state > > drivers/mmc/core/core.c | 6 ++++-- > drivers/mmc/core/host.c | 13 +++++++++++-- > drivers/mmc/core/host.h | 6 ++++++ > 3 files changed, 21 insertions(+), 4 deletions(-) > > -- > 2.30.2 > Patch1 applied for fixes and by adding a fixes+stable tag. Patch2 and patch3, queued up for v5.15 (temporary on the devel branch). Thanks and kind regards Uffe
See patch 1 for a description of the problem. This series implements the alternative approach suggested by Adrian (thanks!). It also adds some documentation and a minor cleanup which I came up with while working on the fix. Patch 1 can go to stable as is, the rest built on top of that. This series fixes the performance issue which we saw when injecting CRC errors on Renesas R-Car Gen3 hardware. Looking forward to comments! Wolfram Sang (3): mmc: core: clear flags before allowing to retune mmc: host: add kdoc for mmc_retune_{en|dis}able mmc: host: factor out clearing the retune state drivers/mmc/core/core.c | 6 ++++-- drivers/mmc/core/host.c | 13 +++++++++++-- drivers/mmc/core/host.h | 6 ++++++ 3 files changed, 21 insertions(+), 4 deletions(-)