mbox series

[0/2] mmc: Fix dma_map_sg error check

Message ID 20220825074008.33349-1-jinpu.wang@ionos.com (mailing list archive)
Headers show
Series mmc: Fix dma_map_sg error check | expand

Message

Jinpu Wang Aug. 25, 2022, 7:40 a.m. UTC 
Hi, all,

While working on a bugfix on RTRS[1], I noticed there are quite a few other
drivers have the same problem, due to the fact dma_map_sg return 0 on error,
not like most of the cases, return negative value for error.

I "grep -A 5 dma_map_sg' in kernel tree, and audit/fix the one I feel is buggy,
hence this patchset. As suggested by Christoph Hellwig, I now send the patches per
subsystem, this is for mmc subsystem.

Thanks!

[1] https://lore.kernel.org/linux-rdma/20220818105355.110344-1-haris.iqbal@ionos.com/T/#t

Jack Wang (2):
  mmc: meson-mx-sdhc: Fix error check for dma_map_sg
  mmc: jz4740_mmc: Fix error check for dma_map_sg

 drivers/mmc/host/jz4740_mmc.c        | 4 ++--
 drivers/mmc/host/meson-mx-sdhc-mmc.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Ulf Hansson Aug. 26, 2022, 9:16 a.m. UTC | #1 
On Thu, 25 Aug 2022 at 09:40, Jack Wang <jinpu.wang@ionos.com> wrote:
>
> Hi, all,
>
> While working on a bugfix on RTRS[1], I noticed there are quite a few other
> drivers have the same problem, due to the fact dma_map_sg return 0 on error,
> not like most of the cases, return negative value for error.
>
> I "grep -A 5 dma_map_sg' in kernel tree, and audit/fix the one I feel is buggy,
> hence this patchset. As suggested by Christoph Hellwig, I now send the patches per
> subsystem, this is for mmc subsystem.
>
> Thanks!
>
> [1] https://lore.kernel.org/linux-rdma/20220818105355.110344-1-haris.iqbal@ionos.com/T/#t
>
> Jack Wang (2):
>   mmc: meson-mx-sdhc: Fix error check for dma_map_sg
>   mmc: jz4740_mmc: Fix error check for dma_map_sg
>
>  drivers/mmc/host/jz4740_mmc.c        | 4 ++--
>  drivers/mmc/host/meson-mx-sdhc-mmc.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>

The series, applied for next, thanks!

Kind regards
Uffe