mbox series

[0/4] mmc: sdhci: Tidy reset handling

Message ID 20220926192022.85660-1-adrian.hunter@intel.com (mailing list archive)
Headers show
Series mmc: sdhci: Tidy reset handling | expand

Message

Adrian Hunter Sept. 26, 2022, 7:20 p.m. UTC
Hi

When reviewing the patch "mmc: sdhci-tegra: Issue CMD and DAT resets
together" currently on the mailing list:

https://lore.kernel.org/linux-mmc/20220926094906.14537-3-pshete@nvidia.com/

it seemed like some small tidy up was needed first.  Hence these patches.

In particular, patch 4 "mmc: sdhci: Centralize CMD and DATA reset handling"
should enable the proposed quirk from the sdhci-tegra patch to be
implemented in a more consistent way.


Adrian Hunter (4):
      mmc: sdhci: Separate out sdhci_reset_for_all()
      mmc: sdhci: Remove misleading comment about resets
      mmc: sdhci: Get rid of SDHCI_QUIRK_RESET_CMD_DATA_ON_IOS
      mmc: sdhci: Centralize CMD and DATA reset handling

 drivers/mmc/host/sdhci-pci-core.c | 23 ++++++++++-
 drivers/mmc/host/sdhci.c          | 84 ++++++++++++++++++++++++---------------
 drivers/mmc/host/sdhci.h          |  2 -
 3 files changed, 73 insertions(+), 36 deletions(-)


Regards
Adrian

Comments

Ulf Hansson Sept. 27, 2022, 12:13 p.m. UTC | #1
On Mon, 26 Sept 2022 at 21:20, Adrian Hunter <adrian.hunter@intel.com> wrote:
>
> Hi
>
> When reviewing the patch "mmc: sdhci-tegra: Issue CMD and DAT resets
> together" currently on the mailing list:
>
> https://lore.kernel.org/linux-mmc/20220926094906.14537-3-pshete@nvidia.com/
>
> it seemed like some small tidy up was needed first.  Hence these patches.
>
> In particular, patch 4 "mmc: sdhci: Centralize CMD and DATA reset handling"
> should enable the proposed quirk from the sdhci-tegra patch to be
> implemented in a more consistent way.
>
>
> Adrian Hunter (4):
>       mmc: sdhci: Separate out sdhci_reset_for_all()
>       mmc: sdhci: Remove misleading comment about resets
>       mmc: sdhci: Get rid of SDHCI_QUIRK_RESET_CMD_DATA_ON_IOS
>       mmc: sdhci: Centralize CMD and DATA reset handling
>
>  drivers/mmc/host/sdhci-pci-core.c | 23 ++++++++++-
>  drivers/mmc/host/sdhci.c          | 84 ++++++++++++++++++++++++---------------
>  drivers/mmc/host/sdhci.h          |  2 -
>  3 files changed, 73 insertions(+), 36 deletions(-)
>
>
> Regards
> Adrian

Applied for next, thanks!

Kind regards
Uffe