From patchwork Wed Nov 1 07:38:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Adrian Hunter X-Patchwork-Id: 13442589 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2286CC4332F for ; Wed, 1 Nov 2023 07:38:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231179AbjKAHit (ORCPT ); Wed, 1 Nov 2023 03:38:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231169AbjKAHit (ORCPT ); Wed, 1 Nov 2023 03:38:49 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDB17E4; Wed, 1 Nov 2023 00:38:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698824324; x=1730360324; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=KagOix17M6bQzQZUD36jEg+Kj080AKQxOTN/L7teNfM=; b=JkO9uUKI4kcVJGjZEajLuDkkolxfNn995ubZ6NgicQOSRir4LnWl/Ha8 rnuE2wvmIvcRKoskaJjsjUo2y8L2mtqOLWrz3Tjq05zTmbxy2D2xWhWMe k9/UBBv/TIZ+w8QQFNd8O8h4OuJpk1nMZTcgszH/iLnLVR8egYjAXeOC2 YyZWLopYGKrE/QC/Q9r20xp1PfeS5fLjot4k2pdTKeQTYeHwjdTgb7lVD qh8bGUROFh13xHhZ4tnQ6qtTsueGWXqZ887plU07JPASK7SMfn1/64hJA N6UCfjo7K4/WAWL4BFSyLlqNM8WomdsuB6JIwRC8y+oyjFu2fsxBd3q33 Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="9982612" X-IronPort-AV: E=Sophos;i="6.03,267,1694761200"; d="scan'208";a="9982612" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 00:38:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10880"; a="934357503" X-IronPort-AV: E=Sophos;i="6.03,267,1694761200"; d="scan'208";a="934357503" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO ahunter-VirtualBox.home\044ger.corp.intel.com) ([10.252.34.17]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 00:38:37 -0700 From: Adrian Hunter To: Ulf Hansson , =?utf-8?q?Kornel_Dul=C4=99ba?= , Radoslaw Biernacki , Gwendal Grignou , Ritesh Harjani , Asutosh Das Cc: Chaotian Jing , Aswath Govindraju , Bhavya Kapoor , Kamal Dasu , Al Cooper , Haibo Chen , Bhupesh Sharma , Shaik Sajida Bhanu , Sai Krishna Potthuri , Swati Agarwal , Victor Shih , Ben Chuang , Thierry Reding , Aniruddha Tvs Rao , Chun-Hung Wu , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/5] mmc: block: Fixes for CQE error recovery recovery Date: Wed, 1 Nov 2023 09:38:22 +0200 Message-Id: <20231101073827.4772-1-adrian.hunter@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Hi Some issues have been found with CQE error recovery. Here are some fixes. There is also a patch from Kornel Dulęba: https://lore.kernel.org/linux-mmc/e7c12e07-7540-47ea-8891-2cec73d58df1@intel.com/T/#u which is still under review. Please also note ->post_disable() seems to be missing from cqhci_recovery_start(). It would be good if ->post_disable() users could check if this needs attention. Adrian Hunter (5): mmc: block: Do not lose cache flush during CQE error recovery mmc: cqhci: Increase recovery halt timeout mmc: block: Be sure to wait while busy in CQE error recovery mmc: block: Retry commands in CQE error recovery mmc: cqhci: Warn of halt or task clear failure drivers/mmc/core/block.c | 2 ++ drivers/mmc/core/core.c | 9 +++++++-- drivers/mmc/host/cqhci-core.c | 12 ++++++------ 3 files changed, 15 insertions(+), 8 deletions(-) Regards Adrian