From patchwork Fri Nov 3 08:47:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Adrian Hunter X-Patchwork-Id: 13444405 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32261C4167B for ; Fri, 3 Nov 2023 08:48:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235102AbjKCIsS (ORCPT ); Fri, 3 Nov 2023 04:48:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235136AbjKCIsR (ORCPT ); Fri, 3 Nov 2023 04:48:17 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1570BD5E; Fri, 3 Nov 2023 01:48:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699001291; x=1730537291; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=pgGJxu22SuOko7jFYhtpgXsdMllFfBeSM101ozpIhzo=; b=XVk89u7TqoH56DMFL2Zr2HGqAPdC1fevrvR0Eg4cBOGHWBkYEUfzoMKm a72Ec0bwa06gjgLPEvDHpM8Mm42WInjb5rtkZCQFIKcJph/5P4STYH6so 6I7Pp/86bPqSCtcWuxPiWdOW2QNax4OonXw0ecCd90AxK21uBQ/UUpJ+O VXmb1DQ1iZRGDA8NMojKlFqwZD4oJqcm6MOOznzd+L9rGxwANhnOODEcm 0uKLdarRC3tYNhWRJwWFEbXuXAzUSsyqT3bBoqvYri+cqpkazxtmwfT6Y gHGYG80lYvXdIW7A9PpDNLh8bLEMv85ckUpfBvaALwgsKivPt1N9ah3Rb g==; X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="391774470" X-IronPort-AV: E=Sophos;i="6.03,273,1694761200"; d="scan'208";a="391774470" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2023 01:48:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="796556409" X-IronPort-AV: E=Sophos;i="6.03,273,1694761200"; d="scan'208";a="796556409" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO ahunter-VirtualBox.home\044ger.corp.intel.com) ([10.252.51.133]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2023 01:48:04 -0700 From: Adrian Hunter To: Ulf Hansson , =?utf-8?q?Kornel_Dul=C4=99ba?= , Radoslaw Biernacki , Gwendal Grignou , Asutosh Das Cc: Chaotian Jing , Bhavya Kapoor , Kamal Dasu , Al Cooper , Haibo Chen , Shaik Sajida Bhanu , Sai Krishna Potthuri , Victor Shih , Ben Chuang , Thierry Reding , Aniruddha Tvs Rao , Chun-Hung Wu , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 0/6] mmc: block: Fixes for CQE error recovery recovery Date: Fri, 3 Nov 2023 10:47:14 +0200 Message-Id: <20231103084720.6886-1-adrian.hunter@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Hi Some issues have been found with CQE error recovery. Here are some fixes. As of V2, the alternative implementation for the patch from Kornel Dulęba: https://lore.kernel.org/linux-mmc/e7c12e07-7540-47ea-8891-2cec73d58df1@intel.com/T/#u is now included, see patch 6 "mmc: cqhci: Fix task clearing in CQE error recovery") Please also note ->post_disable() seems to be missing from cqhci_recovery_start(). It would be good if ->post_disable() users could check if this needs attention. Changes in V2: mmc: cqhci: Fix task clearing in CQE error recovery New patch mmc: cqhci: Warn of halt or task clear failure Add fixes and stable tags Adrian Hunter (6): mmc: block: Do not lose cache flush during CQE error recovery mmc: cqhci: Increase recovery halt timeout mmc: block: Be sure to wait while busy in CQE error recovery mmc: block: Retry commands in CQE error recovery mmc: cqhci: Warn of halt or task clear failure mmc: cqhci: Fix task clearing in CQE error recovery drivers/mmc/core/block.c | 2 ++ drivers/mmc/core/core.c | 9 +++++++-- drivers/mmc/host/cqhci-core.c | 44 +++++++++++++++++++++---------------------- 3 files changed, 31 insertions(+), 24 deletions(-) Regards Adrian