| Message ID | 20241229-update_pm_macro-v1-0-c7d4c4856336@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() | expand |
On Sun, Dec 29, 2024 at 12:32:39AM +0100, Raphael Gallais-Pou wrote: > Prevent the use of macros, and rely instead on kernel configuration for > power management. > > This series makes the same change over six different drivers: > usb-st-dwc3, sdhci-st, st-spi-fsm, ahci_st, sti-dwmac, spi-st. Is there any actual interaction between these changes? In general you shouldn't combine patches for multiple subsystems into a single series unless there's some dependency or other interaction since it just complicates management of the patches.
Le 06/01/2025 à 14:08, Mark Brown a écrit : > On Sun, Dec 29, 2024 at 12:32:39AM +0100, Raphael Gallais-Pou wrote: >> Prevent the use of macros, and rely instead on kernel configuration for >> power management. >> >> This series makes the same change over six different drivers: >> usb-st-dwc3, sdhci-st, st-spi-fsm, ahci_st, sti-dwmac, spi-st. > > Is there any actual interaction between these changes? In general you > shouldn't combine patches for multiple subsystems into a single series > unless there's some dependency or other interaction since it just > complicates management of the patches. Hi, No, there isn't apart from the fact that those are stm32 drivers. As Miquel also stated a few days ago, is was wrong for me to sent all of this in a whole serie. I will just resend them separately as a v2, taking into account Miquel's review[1] and the kernel robot. Regards, Raphaël [1] https://lore.kernel.org/lkml/877c7ha77n.fsf@bootlin.com/
Prevent the use of macros, and rely instead on kernel configuration for power management. This series makes the same change over six different drivers: usb-st-dwc3, sdhci-st, st-spi-fsm, ahci_st, sti-dwmac, spi-st. Signed-off-by: Raphael Gallais-Pou <rgallaispou@gmail.com> --- Raphael Gallais-Pou (6): usb: dwc3: st: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() mmc: sdhci-st: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() mtd: st_spi_fsm: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() ahci: st: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() net: stmmac: sti: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() spi: st: Switch from CONFIG_PM_SLEEP guards to pm_sleep_ptr() drivers/ata/ahci_st.c | 6 ++---- drivers/mmc/host/sdhci-st.c | 6 ++---- drivers/mtd/devices/st_spi_fsm.c | 6 ++---- drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c | 8 +++----- drivers/spi/spi-st-ssc4.c | 6 +----- drivers/usb/dwc3/dwc3-st.c | 6 ++---- 6 files changed, 12 insertions(+), 26 deletions(-) --- base-commit: 8155b4ef3466f0e289e8fcc9e6e62f3f4dceeac2 change-id: 20241228-update_pm_macro-e4585beafd33 Best regards,