From patchwork Wed Oct 2 08:44:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2973661 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A1627BFF0B for ; Wed, 2 Oct 2013 08:45:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8AAD3203B4 for ; Wed, 2 Oct 2013 08:45:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A35E3203E3 for ; Wed, 2 Oct 2013 08:45:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753690Ab3JBIo5 (ORCPT ); Wed, 2 Oct 2013 04:44:57 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:30890 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753541Ab3JBIoi (ORCPT ); Wed, 2 Oct 2013 04:44:38 -0400 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MU1004A59M6PB20@mailout1.samsung.com> for linux-mmc@vger.kernel.org; Wed, 02 Oct 2013 17:44:37 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 2E.24.17682.5FCDB425; Wed, 02 Oct 2013 17:44:37 +0900 (KST) X-AuditID: cbfee68e-b7f756d000004512-2d-524bdcf5f162 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id E3.0D.09055.4FCDB425; Wed, 02 Oct 2013 17:44:36 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MU100EFD9MCIK70@mmp1.samsung.com>; Wed, 02 Oct 2013 17:44:36 +0900 (KST) From: Jingoo Han To: 'Chris Ball' Cc: linux-mmc@vger.kernel.org, 'Adrian Hunter' , 'Jingoo Han' Subject: [PATCH] mmc: sdhci-pci: remove unnecessary pci_set_drvdata() Date: Wed, 02 Oct 2013 17:44:36 +0900 Message-id: <000001cebf4b$a0011140$e00333c0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac6/S5+iCMLl9SLRQb2fjCVzTvnSkQ== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGIsWRmVeSWpSXmKPExsVy+t8zA92vd7yDDP6cZ7Y4+WQNm8X21xvZ LC4vvMRqceR/P6MDi8fiPS+ZPA5dWcvo0bdlFaPH501yASxRXDYpqTmZZalF+nYJXBkTNp5l K3jCVvH870q2BsZ9rF2MnBwSAiYSq/4vgrLFJC7cW8/WxcjFISSwjFHiypopbDBFez68ZIVI LGKUePv+PxOE84tR4vm83WDtbAJqEl++HGYHsUUEFCW2fD8OZjML5Ek8m9rIBGILC7hKLJp5 GWwqi4CqxM/9F8FsXgFbiTl7t7BA2IISPybfY4Ho1ZJYv/M4E4QtL7F5zVvmLkYOoIvUJR79 1YVYpSexffs+qBIRiX0v3jGC3CYhsI5d4senKewQuwQkvk0+xALRKyux6QAzxGOSEgdX3GCZ wCg2C8nmWUg2z0KyeRaSFQsYWVYxiqYWJBcUJ6UXGekVJ+YWl+al6yXn525ihMRZ3w7Gmwes DzEmA62fyCwlmpwPjNO8knhDYzMjC1MTU2Mjc0sz0oSVxHnVWqwDhQTSE0tSs1NTC1KL4otK c1KLDzEycXBKNTCylaVGvKkOtbEztpMsjj2lXvVFWuKCwVRNMZsL+rd43z9p2GQw781x4QZn tZ8H/3a6txa/OxNj9LU4cf3DCuWqDzYcy3xtFkytEdO52nsg8oph0cM7HPEHPl6TnWhy4432 7ynJEzR2XXdT9zrh8OL2mRtPOB96xThv1LlT3jZ1+eyn85V25gQosRRnJBpqMRcVJwIAzmWF oMkCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEKsWRmVeSWpSXmKPExsVy+t9jAd2vd7yDDJ6xWZx8sobNYvvrjWwW lxdeYrU48r+f0YHFY/Gel0weh66sZfTo27KK0ePzJrkAlqgGRpuM1MSU1CKF1Lzk/JTMvHRb Je/geOd4UzMDQ11DSwtzJYW8xNxUWyUXnwBdt8wcoJVKCmWJOaVAoYDE4mIlfTtME0JD3HQt YBojdH1DguB6jAzQQMI6xowJG8+yFTxhq3j+dyVbA+M+1i5GTg4JAROJPR9eQtliEhfurWfr YuTiEBJYxCjx9v1/JgjnF6PE83m7warYBNQkvnw5zA5iiwgoSmz5fhzMZhbIk3g2tZEJxBYW cJVYNPMyG4jNIqAq8XP/RTCbV8BWYs7eLSwQtqDEj8n3WCB6tSTW7zzOBGHLS2xe85a5i5ED 6CJ1iUd/dSFW6Uls374PqkREYt+Ld4wTGAVmIZk0C8mkWUgmzULSsoCRZRWjaGpBckFxUnqu oV5xYm5xaV66XnJ+7iZGcAw/k9rBuLLB4hCjAAejEg+vxEOvICHWxLLiytxDjBIczEoivBXH vYOEeFMSK6tSi/Lji0pzUosPMSYDPTqRWUo0OR+YXvJK4g2NTcyMLI3MLIxMzM1JE1YS5z3Q ah0oJJCeWJKanZpakFoEs4WJg1OqgVH4nckhex4FrudZZ1z49uqzfxesme4k+93ihGruVOuQ sIb+KdY8Etf3uxkbJ8yZa9rSv9he7Xzse88tHf9PrHm1r1k0kCGUfWZLgOn3TZvcz5deEAn/ v61SZ6u3eAfv/hla7aJBOzw5Tm7X5J1sEu8oos+oVOuW+/Z6+UeemWmiZd6fuGawKrEUZyQa ajEXFScCAAemMDElAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/mmc/host/sdhci-pci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c index d7d6bc8..f0d20f0 100644 --- a/drivers/mmc/host/sdhci-pci.c +++ b/drivers/mmc/host/sdhci-pci.c @@ -1533,7 +1533,6 @@ static int sdhci_pci_probe(struct pci_dev *pdev, return 0; free: - pci_set_drvdata(pdev, NULL); kfree(chip); err: @@ -1555,7 +1554,6 @@ static void sdhci_pci_remove(struct pci_dev *pdev) for (i = 0; i < chip->num_slots; i++) sdhci_pci_remove_slot(chip->slots[i]); - pci_set_drvdata(pdev, NULL); kfree(chip); }