From patchwork Wed Oct 2 08:36:21 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2973471 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D5FFF9F88A for ; Wed, 2 Oct 2013 08:36:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D7C3720399 for ; Wed, 2 Oct 2013 08:36:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE05820397 for ; Wed, 2 Oct 2013 08:36:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753414Ab3JBIgo (ORCPT ); Wed, 2 Oct 2013 04:36:44 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:37888 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753346Ab3JBIgn (ORCPT ); Wed, 2 Oct 2013 04:36:43 -0400 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MU1002WR98CGRR0@mailout4.samsung.com> for linux-mmc@vger.kernel.org; Wed, 02 Oct 2013 17:36:22 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.50]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 04.47.31253.50BDB425; Wed, 02 Oct 2013 17:36:21 +0900 (KST) X-AuditID: cbfee690-b7f3b6d000007a15-bc-524bdb05d7b2 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id B1.6C.05832.50BDB425; Wed, 02 Oct 2013 17:36:21 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MU100AUK98LQH00@mmp2.samsung.com>; Wed, 02 Oct 2013 17:36:21 +0900 (KST) From: Jingoo Han To: 'Chris Ball' Cc: linux-mmc@vger.kernel.org, 'Sonic Zhang' , 'Jingoo Han' References: <000201cebf4a$63a313c0$2ae93b40$%han@samsung.com> In-reply-to: <000201cebf4a$63a313c0$2ae93b40$%han@samsung.com> Subject: [PATCH 2/2] mmc: mmc_spi: remove unnecessary spi_set_drvdata() Date: Wed, 02 Oct 2013 17:36:21 +0900 Message-id: <000301cebf4a$78d9d530$6a8d7f90$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac6/SmN2xOjEtwR+RzmoTMiMFSTXmQAAAhmg Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsVy+t8zI13W295BBmsWWlpsf72RzeLywkus Fkf+9zNa3NnazObA4vHqqqPHoStrGT36tqxi9Pi8SS6AJYrLJiU1J7MstUjfLoEr4+SCH0wF d9kqth+VaGDcz9rFyMEhIWAisWp5eRcjJ5ApJnHh3nq2LkYuDiGBZYwSi9acZYVImEic+bGW ESIxnVFi4fnLzBDOL0aJxvmfmEGq2ATUJL58OcwOYosIKEps+X4czGYWyJaY2/kdbJKQgK3E 6j3dbCA2p4CdxPKvzUwgVwgLuEtsPlYAEmYRUJXYvmA9WDkvUPmD9zvYIGxBiR+T77FAjNSS WL/zOBOELS+xec1bZohn1CUe/dUFMUUEjCSenleBqBCR2PfiHdj5EgLn2CX2vpjNArFKQOLb 5EMsEK2yEpsOMEO8KylxcMUNlgmMErOQLJ6FZPEsJItnIVmxgJFlFaNoakFyQXFSepGJXnFi bnFpXrpecn7uJkZINE7YwXjvgPUhxmSg9ROZpUST84HRnFcSb2hsZmRhamJqbGRuaUaasJI4 r3qLdaCQQHpiSWp2ampBalF8UWlOavEhRiYOTqkGxoXrBWt1nruoss3f8t1pcbppDNMitlt/ lXMufnN9VMlpc4fr3yQvX1mrvfdqJmYtP3X8Zm1Sqr2vQ9ccrt7VRu5bizIWn74tHvBqUUr7 rFiVnvSFFxcVGyjt15jGJxh80+3Gh7dfoub45m778+vP4o2bNl/OmqF+a2e8415GrUjZGu+d PWy165RYijMSDbWYi4oTAd/PZy3cAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrOKsWRmVeSWpSXmKPExsVy+t9jQV3W295BBrsfm1psf72RzeLywkus Fkf+9zNa3NnazObA4vHqqqPHoStrGT36tqxi9Pi8SS6AJaqB0SYjNTEltUghNS85PyUzL91W yTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMHaKWSQlliTilQKCCxuFhJ3w7ThNAQN10L mMYIXd+QILgeIwM0kLCOMePkgh9MBXfZKrYflWhg3M/axcjJISFgInHmx1pGCFtM4sK99Wxd jFwcQgLTGSUWnr/MDOH8YpRonP+JGaSKTUBN4suXw+wgtoiAosSW78fBbGaBbIm5nd/BpgoJ 2Eqs3tPNBmJzCthJLP/azNTFyMEhLOAusflYAUiYRUBVYvuC9WDlvEDlD97vYIOwBSV+TL7H AjFSS2L9zuNMELa8xOY1b5lBxkgIqEs8+qsLYooIGEk8Pa8CUSEise/FO8YJjEKzkAyahWTQ LCSDZiFpWcDIsopRNLUguaA4KT3XSK84Mbe4NC9dLzk/dxMjONqfSe9gXNVgcYhRgINRiYdX 4qFXkBBrYllxZe4hRgkOZiUR3orj3kFCvCmJlVWpRfnxRaU5qcWHGJOB/pzILCWanA9MRHkl 8YbGJmZGlkZmFkYm5uakCSuJ8x5stQ4UEkhPLEnNTk0tSC2C2cLEwSnVwNj02/bJg4WL95Yu aNibyLLU6YjBbae/nle37ozb+XDSryZBpzs2Vdrh8Vs3TF6wrjp3Uf215s6v4tv82nl3bmTV axb7pimov8/5YqqvzDv2/w9LP6obff1+5e4dj+9aTf1ZXz6279/9wVnosZDcbKGEDxOfzZi+ YN+WFJfP3MVeqnV2X40vMeYosRRnJBpqMRcVJwIA4grLnToDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han Acked-by: Sonic Zhang --- drivers/mmc/host/mmc_spi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c index 40770a5..4c5e279 100644 --- a/drivers/mmc/host/mmc_spi.c +++ b/drivers/mmc/host/mmc_spi.c @@ -1472,7 +1472,6 @@ fail_glue_init: fail_nobuf1: mmc_free_host(mmc); mmc_spi_put_pdata(spi); - spi_set_drvdata(spi, NULL); nomem: kfree(ones); @@ -1507,7 +1506,6 @@ static int mmc_spi_remove(struct spi_device *spi) spi->max_speed_hz = mmc->f_max; mmc_free_host(mmc); mmc_spi_put_pdata(spi); - spi_set_drvdata(spi, NULL); } return 0; }