From patchwork Wed Jan 8 01:51:03 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 3451091 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 45D819F390 for ; Wed, 8 Jan 2014 01:51:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8EC602012F for ; Wed, 8 Jan 2014 01:51:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ACD8920136 for ; Wed, 8 Jan 2014 01:51:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753627AbaAHBvS (ORCPT ); Tue, 7 Jan 2014 20:51:18 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:41165 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754797AbaAHBvF (ORCPT ); Tue, 7 Jan 2014 20:51:05 -0500 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MZ20091L7T3VJ00@mailout4.samsung.com> for linux-mmc@vger.kernel.org; Wed, 08 Jan 2014 10:51:04 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.50]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 9D.20.12635.70FACC25; Wed, 08 Jan 2014 10:51:03 +0900 (KST) X-AuditID: cbfee68d-b7fcd6d00000315b-09-52ccaf07578b Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 34.6E.29263.70FACC25; Wed, 08 Jan 2014 10:51:03 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MZ200JWW7T3BVB0@mmp2.samsung.com>; Wed, 08 Jan 2014 10:51:03 +0900 (KST) From: Jingoo Han To: 'Jiri Kosina' Cc: trivial@kernel.org, 'Chris Ball' , linux-mmc@vger.kernel.org, 'Sonic Zhang' , 'Jingoo Han' References: <000001cf0c13$dcea0570$96be1050$%han@samsung.com> In-reply-to: <000001cf0c13$dcea0570$96be1050$%han@samsung.com> Subject: [PATCH 2/3] mmc: mmc_spi: remove unnecessary spi_set_drvdata() Date: Wed, 08 Jan 2014 10:51:03 +0900 Message-id: <000301cf0c14$1666f880$4334e980$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac8ME9ZoPCFpmDDXTKipAHxsatQZYwAAClUA Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsVy+t8zI1329WeCDLZelLGYcHk7o8XlhZdY LXbPWcxiceR/P6PFna3NbBbv919mcmDzeHXV0WPTqk42jxuvFjJ59G1ZxehxZsERdo/Pm+QC 2KK4bFJSczLLUov07RK4Mk7dOsFY0MteMbO1lbGB8RVrFyMnh4SAicSBx51sELaYxIV764Fs Lg4hgWWMEv3nDgI5HGBFF7fpQ8SnM0ps3XIIrEFI4BejxMVJ+SA2m4CaxJcvh9lBbBEBZYkN 57rBBjELLGKUmNCxjwmiwVbi8L/TYM2cAnYSG1f0sIDYwgLuEm2/F4HZLAKqEl82b2QEsXmB 6s9fmcgGYQtK/Jh8D6yGWUBLYv3O40wQtrzE5jVvmSEOVZd49FcX4gYjiXcNN5ghSkQk9r14 xwhyj4TAS3aJdYfmQO0SkPg2+RALRK+sxKYDzJCAkJQ4uOIGywRGiVlINs9CsnkWks2zkKxY wMiyilE0tSC5oDgpvchQrzgxt7g0L10vOT93EyMkdnt3MN4+YH2IMRlo/URmKdHkfGDs55XE GxqbGVmYmpgaG5lbmpEmrCTOm/QwKUhIID2xJDU7NbUgtSi+qDQntfgQIxMHp1QDo/oPmweX jbaoPVp0TnhmrL7+y8biZ4sEr0d+qAhoF3t8KvNqe5Ofcc3Kv96LPHYtsJD7wNQQlPjxwvd7 ++PurZvO28By//ZRpv471WcuRnDvXbdArvDFyY0fv69cwR+n5bNEWvP3iZqzHtmpX59bWze3 P6hxzthQ7utmbxt/2MNBk7ODu0fjtRJLcUaioRZzUXEiAN383/LzAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLKsWRmVeSWpSXmKPExsVy+t9jQV329WeCDA6dk7CYcHk7o8XlhZdY LXbPWcxiceR/P6PFna3NbBbv919mcmDzeHXV0WPTqk42jxuvFjJ59G1ZxehxZsERdo/Pm+QC 2KIaGG0yUhNTUosUUvOS81My89JtlbyD453jTc0MDHUNLS3MlRTyEnNTbZVcfAJ03TJzgM5Q UihLzCkFCgUkFhcr6dthmhAa4qZrAdMYoesbEgTXY2SABhLWMWacunWCsaCXvWJmaytjA+Mr 1i5GDg4JAROJi9v0uxg5gUwxiQv31rN1MXJxCAlMZ5TYuuUQG0hCSOAXo8TFSfkgNpuAmsSX L4fZQWwRAWWJDee6wRqYBRYxSkzo2McE0WArcfjfabBmTgE7iY0relhAbGEBd4m234vAbBYB VYkvmzcygti8QPXnr0xkg7AFJX5MvgdWwyygJbF+53EmCFteYvOat8wQR6tLPPqrC3GDkcS7 hhvMECUiEvtevGOcwCg0C8mkWUgmzUIyaRaSlgWMLKsYRVMLkguKk9JzDfWKE3OLS/PS9ZLz czcxghPDM6kdjCsbLA4xCnAwKvHw3lA7EyTEmlhWXJl7iFGCg1lJhPdYN1CINyWxsiq1KD++ qDQntfgQYzLQoxOZpUST84FJK68k3tDYxMzI0sjMwsjE3Jw0YSVx3gOt1oFCAumJJanZqakF qUUwW5g4OKUaGBOu3pI8LLE6NCW+NKT8pr5D9RTFK66FO0r7CyWmpixZluO00nXjAka5ku6V 6rkWv69Or3nSOvlUvkzEXukd0q+Vr/2+cv0ed7r6qZ3rpq94lZP4kvUc95E4Q5PvrKIqiROE NT4+LedLqzZbKseq3lmhrrlVf+fEbxvznz3hqRG1Ov9T7pP3PyWW4oxEQy3mouJEAME7iTZQ AwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han Acked-by: Sonic Zhang --- drivers/mmc/host/mmc_spi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c index 40770a5..4c5e279 100644 --- a/drivers/mmc/host/mmc_spi.c +++ b/drivers/mmc/host/mmc_spi.c @@ -1472,7 +1472,6 @@ fail_glue_init: fail_nobuf1: mmc_free_host(mmc); mmc_spi_put_pdata(spi); - spi_set_drvdata(spi, NULL); nomem: kfree(ones); @@ -1507,7 +1506,6 @@ static int mmc_spi_remove(struct spi_device *spi) spi->max_speed_hz = mmc->f_max; mmc_free_host(mmc); mmc_spi_put_pdata(spi); - spi_set_drvdata(spi, NULL); } return 0; }