| Message ID | 000e01ce9247$d6063f30$8212bd90$@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, August 06, 2013,Jingoo Han wrote: > Include 'dw_mmc-pltfm.h' header file in order to fix > the following sparse warnings: > > drivers/mmc/host/dw_mmc-pltfm.c:36:5: warning: symbol 'dw_mci_pltfm_register' was not declared. Should > it be static? > drivers/mmc/host/dw_mmc-pltfm.c:94:1: warning: symbol 'dw_mci_pltfm_pmops' was not declared. Should it > be static? > drivers/mmc/host/dw_mmc-pltfm.c:118:5: warning: symbol 'dw_mci_pltfm_remove' was not declared. Should > it be static? > > Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Jingoo Han <jg1.han@samsung.com> Acked-by: Seungwon Jeon <tgih.jun@samsung.com> -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Seungwon, On Fri, Aug 09 2013, Seungwon Jeon wrote: > On Tue, August 06, 2013,Jingoo Han wrote: >> Include 'dw_mmc-pltfm.h' header file in order to fix >> the following sparse warnings: >> >> drivers/mmc/host/dw_mmc-pltfm.c:36:5: warning: symbol >> dw_mci_pltfm_register' was not declared. Should >> it be static? >> drivers/mmc/host/dw_mmc-pltfm.c:94:1: warning: symbol >> dw_mci_pltfm_pmops' was not declared. Should it >> be static? >> drivers/mmc/host/dw_mmc-pltfm.c:118:5: warning: symbol >> dw_mci_pltfm_remove' was not declared. Should >> it be static? >> >> Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> >> Signed-off-by: Jingoo Han <jg1.han@samsung.com> > > Acked-by: Seungwon Jeon <tgih.jun@samsung.com> Thanks, pushed to mmc-next for 3.12. - Chris.
diff --git a/drivers/mmc/host/dw_mmc-pltfm.c b/drivers/mmc/host/dw_mmc-pltfm.c index ee52556..2089752 100644 --- a/drivers/mmc/host/dw_mmc-pltfm.c +++ b/drivers/mmc/host/dw_mmc-pltfm.c @@ -23,6 +23,7 @@ #include <linux/of.h> #include "dw_mmc.h" +#include "dw_mmc-pltfm.h" static void dw_mci_rockchip_prepare_command(struct dw_mci *host, u32 *cmdr) {
Include 'dw_mmc-pltfm.h' header file in order to fix the following sparse warnings: drivers/mmc/host/dw_mmc-pltfm.c:36:5: warning: symbol 'dw_mci_pltfm_register' was not declared. Should it be static? drivers/mmc/host/dw_mmc-pltfm.c:94:1: warning: symbol 'dw_mci_pltfm_pmops' was not declared. Should it be static? drivers/mmc/host/dw_mmc-pltfm.c:118:5: warning: symbol 'dw_mci_pltfm_remove' was not declared. Should it be static? Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/mmc/host/dw_mmc-pltfm.c | 1 + 1 file changed, 1 insertion(+)