From patchwork Mon Mar 25 07:28:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seungwon Jeon X-Patchwork-Id: 2329181 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id B88313FD8C for ; Mon, 25 Mar 2013 07:28:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755382Ab3CYH2Z (ORCPT ); Mon, 25 Mar 2013 03:28:25 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:29977 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754948Ab3CYH2Y (ORCPT ); Mon, 25 Mar 2013 03:28:24 -0400 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MK700HFKGR3RRS0@mailout1.samsung.com> for linux-mmc@vger.kernel.org; Mon, 25 Mar 2013 16:28:22 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.48]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 2B.65.12250.69CFF415; Mon, 25 Mar 2013 16:28:22 +0900 (KST) X-AuditID: cbfee691-b7f5f6d000002fda-77-514ffc96bedf Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 69.DF.17838.69CFF415; Mon, 25 Mar 2013 16:28:22 +0900 (KST) Received: from DOTGIHJUN01 ([12.23.118.161]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MK7009B6GRA8TE0@mmp1.samsung.com>; Mon, 25 Mar 2013 16:28:22 +0900 (KST) From: Seungwon Jeon To: linux-mmc@vger.kernel.org Cc: 'Chris Ball' , 'Jaehoon Chung' References: In-reply-to: Subject: [PATCH RESEND] mmc: dw_mmc: fix fifo access for 64-bit Date: Mon, 25 Mar 2013 16:28:22 +0900 Message-id: <001c01ce292a$54a35a80$fdea0f80$%jun@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac03z3aCvVFr8FaITt2vKVQKst76fw3Ogf7QC4iI1hAMB9K34BZmlr6gAIYipsA= Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrEIsWRmVeSWpSXmKPExsVy+t8zA91pf/wDDR4e07LY/nojm8WNX22s Fkf+9zM6MHscurKW0aNvyypGj8+b5AKYo7hsUlJzMstSi/TtErgyut59ZS6Yzlax7kgXWwNj E2sXIyeHhICJxPX3a9kgbDGJC/fWA9lcHEICyxgl3p85xwJT9GvRLFaIxCJGiX9T+9khnD+M EpsaGhhBqtgEtCT+vnnDDGKLCMhK/PxzAWwss4C3xKv5a4BqOIAauCVWNweBhDkFeCTW/ekE KxcWsJeYs2U+2DIWAVWJ1iOPwOK8ArYSs6edY4ewBSV+TL7HAjFSXWLSvEXMELa8xOY1b5lB xksAxR/91YW4wE/iy7kLUCUiEvtevGOE+GUXu8S1CVkQqwQkvk0+xALRKiux6QAzRImkxMEV N1gmMErMQrJ4FpLFs5AsnoVkwwJGllWMoqkFyQXFSelFpnrFibnFpXnpesn5uZsYIfE3cQfj /QPWhxiTgdZPZJYSTc4Hxm9eSbyhsZmRhamJqbGRuaUZacJK4rzqLdaBQgLpiSWp2ampBalF 8UWlOanFhxiZODilGhhd/fkOlBZLsb9k3cpx8UrPlMMhIqFFx+a3P/Z6kvbbSPrv7oUrGmdU 3nVTP5T3OuPbhe0vzwu82yUaqOa8R27CgtlyRSZPYh9O2CJwpOT3nJN7Ij9UFDcfUre7fS5T huHx+ptzonSuepWdvbzm4smvM3Y/OTH7iElhcGj8W/t34gX2BUIpEg3GSizFGYmGWsxFxYkA Xy5vHdUCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrAKsWRmVeSWpSXmKPExsVy+t9jAd1pf/wDDf7/VrPY/nojm8WNX22s Fkf+9zM6MHscurKW0aNvyypGj8+b5AKYoxoYbTJSE1NSixRS85LzUzLz0m2VvIPjneNNzQwM dQ0tLcyVFPISc1NtlVx8AnTdMnOANikplCXmlAKFAhKLi5X07TBNCA1x07WAaYzQ9Q0Jgusx MkADCesYM7refWUumM5Wse5IF1sDYxNrFyMnh4SAicSvRbOgbDGJC/fWs3UxcnEICSxilPg3 tZ8dwvnDKLGpoYERpIpNQEvi75s3zCC2iICsxM8/F9hAbGYBb4lX89cA1XAANXBLrG4OAglz CvBIrPvTCVYuLGAvMWfLfBYQm0VAVaL1yCOwOK+ArcTsaefYIWxBiR+T77FAjFSXmDRvETOE LS+xec1bZpDxEkDxR391IS7wk/hy7gJUiYjEvhfvGCcwCs1CMmkWkkmzkEyahaRlASPLKkbR 1ILkguKk9FxDveLE3OLSvHS95PzcTYzg+H4mtYNxZYPFIUYBDkYlHl6BGv9AIdbEsuLK3EOM EhzMSiK80feAQrwpiZVVqUX58UWlOanFhxiTgR6dyCwlmpwPTD15JfGGxiZmRpZGZhZGJubm pAkrifMeaLUOFBJITyxJzU5NLUgtgtnCxMEp1cCot+IMwz3xW99nH23rPf9rZTW/1hMLS7NF Dy+W2G+cu7fYx+80z6mN39dd+GahXyxzl7MtunySRwGjdMWMg6sbGo4cYOL68a5R4lnuOj0W vRT1LvOOQn3mG0/vCPTfzcs5ZXCv0HyjR5ZQ6ZM+D97m5aqyuzeKlE2Mdb093z0neGK9dd7c vjlKLMUZiYZazEXFiQCjP4AOMwMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org mci_writew causes a failure of fifo access for 64-bit. mci_writeq is correct. Signed-off-by: Seungwon Jeon Acked-by: Jaehoon Chung --- drivers/mmc/host/dw_mmc.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index a443820..753c55c 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -1373,8 +1373,9 @@ static void dw_mci_push_data64(struct dw_mci *host, void *buf, int cnt) int len = dw_mci_push_part_bytes(host, buf, cnt); buf += len; cnt -= len; + if (host->part_buf_count == 8) { - mci_writew(host, DATA(host->data_offset), + mci_writeq(host, DATA(host->data_offset), host->part_buf); host->part_buf_count = 0; }