From patchwork Mon Sep 23 01:23:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2925551 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 821F69F398 for ; Mon, 23 Sep 2013 01:23:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B6B8C20503 for ; Mon, 23 Sep 2013 01:23:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5863B20529 for ; Mon, 23 Sep 2013 01:23:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752816Ab3IWBXf (ORCPT ); Sun, 22 Sep 2013 21:23:35 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:36432 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752611Ab3IWBXe (ORCPT ); Sun, 22 Sep 2013 21:23:34 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MTK00GPG164EPC0@mailout2.samsung.com> for linux-mmc@vger.kernel.org; Mon, 23 Sep 2013 10:23:33 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [203.254.230.47]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 52.46.30629.3189F325; Mon, 23 Sep 2013 10:23:31 +0900 (KST) X-AuditID: cbfee68d-b7fe86d0000077a5-e2-523f98135920 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id C5.34.09055.2189F325; Mon, 23 Sep 2013 10:23:31 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MTK00CVZ176T080@mmp1.samsung.com>; Mon, 23 Sep 2013 10:23:30 +0900 (KST) From: Jingoo Han To: 'Chris Ball' Cc: linux-mmc@vger.kernel.org, 'Adrian Hunter' , 'Jingoo Han' Subject: [PATCH] mmc: sdhci-pci: remove unnecessary pci_set_drvdata() Date: Mon, 23 Sep 2013 10:23:30 +0900 Message-id: <002601ceb7fb$83531ea0$89f95be0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac63+4M3euneDW9nQbmupbZMQvRZ+Q== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCIsWRmVeSWpSXmKPExsVy+t8zfV3hGfZBBhMfs1icfLKGzWL7641s FpcXXmK1OPK/n9GBxWPxnpdMHoeurGX06NuyitHj8ya5AJYoLpuU1JzMstQifbsErowJG8+y FTxhq3j+dyVbA+M+1i5GTg4JAROJJ+tXMkPYYhIX7q1n62Lk4hASWMYosfn4QkaYolU9/1kg EosYJT53PoByfjFKfDv4EKyKTUBN4suXw+wgtoiAosSW78fBbGaBPIlnUxuZQGxhAVeJRTMv s4HYLAKqEpcnnQVbzStgKzH9yisWCFtQ4sfkeywQvVoS63ceZ4Kw5SU2r3kLVM8BdJG6xKO/ uiCmiICexL0PhhAVIhL7XryDunkbu8SNbWYQmwQkvk0+xALRKSux6QDUv5ISB1fcYJnAKDYL yd5ZSPbOQrJ3FpINCxhZVjGKphYkFxQnpRcZ6hUn5haX5qXrJefnbmKExFjvDsbbB6wPMSYD rZ/ILCWanA+M0bySeENjMyMLUxNTYyNzSzPShJXEedVarAOFBNITS1KzU1MLUovii0pzUosP MTJxcEo1MMZkPNCrLGOduys4YslOpf3Z11lk1j073zDdN9ljWVQLw5N1XgpXnTTbegUD7L6/ XF/+wdRqdsBfs82vYp8Ji+3lSHou+2CXqtY25j6B/z2Pv7lIvLKquhadkcG4qk329BWrHzd5 vy3kvqvxNf+fOI+eUI779FS/X7OPfj/SsHz1TPGtOy+FhSqxFGckGmoxFxUnAgA6vRAsxwIA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEKsWRmVeSWpSXmKPExsVy+t9jAV3hGfZBBmvmM1qcfLKGzWL7641s FpcXXmK1OPK/n9GBxWPxnpdMHoeurGX06NuyitHj8ya5AJaoBkabjNTElNQihdS85PyUzLx0 WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKCdSgpliTmlQKGAxOJiJX07TBNCQ9x0 LWAaI3R9Q4LgeowM0EDCOsaMCRvPshU8Yat4/nclWwPjPtYuRk4OCQETiVU9/1kgbDGJC/fW s3UxcnEICSxilPjc+YAFwvnFKPHt4ENGkCo2ATWJL18Os4PYIgKKElu+HwezmQXyJJ5NbWQC sYUFXCUWzbzMBmKzCKhKXJ50lhnE5hWwlZh+5RULhC0o8WPyPRaIXi2J9TuPM0HY8hKb17wF qucAukhd4tFfXRBTREBP4t4HQ4gKEYl9L94xTmAUmIVk0Cwkg2YhGTQLScsCRpZVjKKpBckF xUnpuYZ6xYm5xaV56XrJ+bmbGMEx/ExqB+PKBotDjAIcjEo8vBGJ9kFCrIllxZW5hxglOJiV RHibOoFCvCmJlVWpRfnxRaU5qcWHGJOB/pzILCWanA9ML3kl8YbGJmZGlkZmFkYm5uakCSuJ 8x5otQ4UEkhPLEnNTk0tSC2C2cLEwSnVwOjBLfP9O/cm2WPhEy5uDM77ffLUMdNY8RQF1vf+ Qu/t395gOLp1bthvgeuc1TaOs6fPuSW8QPO0z6vyDb/yHv643CObzi8jeuzNgcxpvJmFmfNk LljuTlovaV7yLnxmmHLtQXvt7GK5jSFfdjmqia7RKt9ivMXslXhRTfWuw3mvZz9LUj+rPk2J pTgj0VCLuag4EQD4682qJQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han --- drivers/mmc/host/sdhci-pci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-pci.c b/drivers/mmc/host/sdhci-pci.c index d7d6bc8..f0d20f0 100644 --- a/drivers/mmc/host/sdhci-pci.c +++ b/drivers/mmc/host/sdhci-pci.c @@ -1533,7 +1533,6 @@ static int sdhci_pci_probe(struct pci_dev *pdev, return 0; free: - pci_set_drvdata(pdev, NULL); kfree(chip); err: @@ -1555,7 +1554,6 @@ static void sdhci_pci_remove(struct pci_dev *pdev) for (i = 0; i < chip->num_slots; i++) sdhci_pci_remove_slot(chip->slots[i]); - pci_set_drvdata(pdev, NULL); kfree(chip); }