| Message ID | 003401ce2c4c$26048490$720d8db0$%han@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Mar 29, 2013 at 12:38 PM, Jingoo Han <jg1.han@samsung.com> wrote: > Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following > build warning when CONFIG_PM_SLEEP is not selected. This is because > sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when > the CONFIG_PM_SLEEP is enabled. > > drivers/mmc/host/sdhci-spear.c:295:12: warning: 'sdhci_suspend' defined but not used [-Wunused-function] > drivers/mmc/host/sdhci-spear.c:308:12: warning: 'sdhci_resume' defined but not used [-Wunused-function] > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > drivers/mmc/host/sdhci-spear.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Acked-by: Viresh Kumar <viresh.kumar@linaro.org> -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Fri, Mar 29 2013, Viresh Kumar wrote: > On Fri, Mar 29, 2013 at 12:38 PM, Jingoo Han <jg1.han@samsung.com> wrote: >> Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following >> build warning when CONFIG_PM_SLEEP is not selected. This is because >> sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when >> the CONFIG_PM_SLEEP is enabled. >> >> drivers/mmc/host/sdhci-spear.c:295:12: warning: 'sdhci_suspend' >> defined but not used [-Wunused-function] >> drivers/mmc/host/sdhci-spear.c:308:12: warning: 'sdhci_resume' >> defined but not used [-Wunused-function] >> >> Signed-off-by: Jingoo Han <jg1.han@samsung.com> >> --- >> drivers/mmc/host/sdhci-spear.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) > > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Thanks, pushed to mmc-next for 3.10. - Chris.
diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c index 8d28334..7ae5b3a 100644 --- a/drivers/mmc/host/sdhci-spear.c +++ b/drivers/mmc/host/sdhci-spear.c @@ -291,7 +291,7 @@ static int sdhci_remove(struct platform_device *pdev) return 0; } -#ifdef CONFIG_PM +#ifdef CONFIG_PM_SLEEP static int sdhci_suspend(struct device *dev) { struct sdhci_host *host = dev_get_drvdata(dev);
Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following build warning when CONFIG_PM_SLEEP is not selected. This is because sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when the CONFIG_PM_SLEEP is enabled. drivers/mmc/host/sdhci-spear.c:295:12: warning: 'sdhci_suspend' defined but not used [-Wunused-function] drivers/mmc/host/sdhci-spear.c:308:12: warning: 'sdhci_resume' defined but not used [-Wunused-function] Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/mmc/host/sdhci-spear.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)