| Message ID | 004b01ce4a1f$b0dbcec0$12936c40$@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Jingoo, On Mon, May 06 2013, Jingoo Han wrote: > The driver core clears the driver data to NULL after device_release > or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d > (device-core: Ensure drvdata = NULL when no driver is bound). > Thus, it is not needed to manually clear the device driver data to NULL. > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > drivers/mmc/host/android-goldfish.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/android-goldfish.c b/drivers/mmc/host/android-goldfish.c > index 7780c14..8b4e20a 100644 > --- a/drivers/mmc/host/android-goldfish.c > +++ b/drivers/mmc/host/android-goldfish.c > @@ -546,8 +546,6 @@ static int goldfish_mmc_remove(struct platform_device *pdev) > { > struct goldfish_mmc_host *host = platform_get_drvdata(pdev); > > - platform_set_drvdata(pdev, NULL); > - > BUG_ON(host == NULL); > > mmc_remove_host(host->mmc); Thanks. I squashed everything down into one patch, collated the ACKs and added them, and pushed it to mmc-next for 3.11. - Chris.
diff --git a/drivers/mmc/host/android-goldfish.c b/drivers/mmc/host/android-goldfish.c index 7780c14..8b4e20a 100644 --- a/drivers/mmc/host/android-goldfish.c +++ b/drivers/mmc/host/android-goldfish.c @@ -546,8 +546,6 @@ static int goldfish_mmc_remove(struct platform_device *pdev) { struct goldfish_mmc_host *host = platform_get_drvdata(pdev); - platform_set_drvdata(pdev, NULL); - BUG_ON(host == NULL); mmc_remove_host(host->mmc);
The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han <jg1.han@samsung.com> --- drivers/mmc/host/android-goldfish.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)