From patchwork Mon May 6 06:37:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 2522771 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 9619E3FC5A for ; Mon, 6 May 2013 06:37:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752756Ab3EFGhS (ORCPT ); Mon, 6 May 2013 02:37:18 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:13189 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752117Ab3EFGhR (ORCPT ); Mon, 6 May 2013 02:37:17 -0400 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout4.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMD004K06DXK2M0@mailout4.samsung.com> for linux-mmc@vger.kernel.org; Mon, 06 May 2013 15:37:16 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.50]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 24.61.31024.C9F47815; Mon, 06 May 2013 15:37:16 +0900 (KST) X-AuditID: cbfee68d-b7f016d000007930-71-51874f9c33ac Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 52.01.01422.C9F47815; Mon, 06 May 2013 15:37:16 +0900 (KST) Received: from DOJG1HAN03 ([12.23.120.99]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MMD00EDF6E3W1I0@mmp1.samsung.com>; Mon, 06 May 2013 15:37:16 +0900 (KST) From: Jingoo Han To: 'Chris Ball' Cc: linux-mmc@vger.kernel.org, Jingoo Han , Viresh Kumar Subject: [PATCH 19/22] mmc: sdhci-spear: remove unnecessary platform_set_drvdata() Date: Mon, 06 May 2013 15:37:15 +0900 Message-id: <005e01ce4a24$261f8100$725e8300$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: Ac5KI/uWcu4f+IAqQi2p03Tj5HpDsw== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGIsWRmVeSWpSXmKPExsVy+t8zI905/u2BBifmClhsf72RzeLywkus Fkf+9zNarLz4l9mBxWPnrLvsHoeurGX06NuyitHj8ya5AJYoLpuU1JzMstQifbsErowH+/+w FxzmqDjS0szWwNjB3sXIySEhYCIxaV0rC4QtJnHh3nq2LkYuDiGBZYwSWy5NBXI4wIreHxKG iC9ilHj8ZDFU0S9GiSmL+tlAutkE1CS+fDkMNlVEQFFiy/fjYDazQIbEs18nmEBsYYEQiYV7 z7CC2CwCqhLPl01kBrF5BSwltn7YzghhC0r8mHyPBaJXS2L9zuNMELa8xOY1b5khLlWQ2HH2 NSPELj2JVY0H2CBqRCT2vXjHCHKchMAmdolvPyazQywTkPg2+RALxDeyEpsOQM2RlDi44gbL BEaxWUhWz0KyehaS1bOQrFjAyLKKUTS1ILmgOCm9yFCvODG3uDQvXS85P3cTIyTOencw3j5g fYgxGWj9RGYp0eR8YJzmlcQbGpsZWZiamBobmVuakSasJM6r1mIdKCSQnliSmp2aWpBaFF9U mpNafIiRiYNTqoEx+aKIT9HLO1knD538LqR7W2g2Z8CGP2GCMb4+G//fmTbDV3FpwunXV331 M1zu8VsyBxzN17mwYPIcOZkX34T2v/I1NplqUbqvdpfM1gmWFTfm7n5wVIL/0AwmrUmLlzyX mrf2Tnispl7D9M3uVc+m2Mx3cM5hfK3l2V51b34Bu2a238evr/+9VWIpzkg01GIuKk4EAKCy 3jzJAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMKsWRmVeSWpSXmKPExsVy+t9jAd05/u2BBieO8lhsf72RzeLywkus Fkf+9zNarLz4l9mBxWPnrLvsHoeurGX06NuyitHj8ya5AJaoBkabjNTElNQihdS85PyUzLx0 WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFslF58AXbfMHKCdSgpliTmlQKGAxOJiJX07TBNCQ9x0 LWAaI3R9Q4LgeowM0EDCOsaMB/v/sBcc5qg40tLM1sDYwd7FyMEhIWAi8f6QcBcjJ5ApJnHh 3nq2LkYuDiGBRYwSj58shnJ+MUpMWdTPBlLFJqAm8eXLYXYQW0RAUWLL9+NgNrNAhsSzXyeY QGxhgRCJhXvPsILYLAKqEs+XTWQGsXkFLCW2ftjOCGELSvyYfI8FoldLYv3O40wQtrzE5jVv mSEuUpDYcfY1I8QuPYlVjQfYIGpEJPa9eMc4gVFgFpJRs5CMmoVk1CwkLQsYWVYxiqYWJBcU J6XnGukVJ+YWl+al6yXn525iBEfxM+kdjKsaLA4xCnAwKvHwFjxpCxRiTSwrrsw9xCjBwawk wuuzFyjEm5JYWZValB9fVJqTWnyIMRno04nMUqLJ+cAEk1cSb2hsYmZkaWRmYWRibk6asJI4 78FW60AhgfTEktTs1NSC1CKYLUwcnFINjOKTzvC5dcxS1Qp42+Qjq79Rv90489T5tDk5jWlq C7wmRL6Nzbdsd0lpNltT93rL2d05+bNkp71dYKDKFx51LbMsjeGgOUeGVZw72+35/g5hh95w L3SZmJ71o+isgsSUvy8sti/WvDSj3nh62p1J5noPn1RIc8Y4LjfPvRY5MVXFf5Okzu18JZbi jERDLeai4kQAcdJneCYDAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The driver core clears the driver data to NULL after device_release or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound). Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han Acked-by: Viresh Kumar --- drivers/mmc/host/sdhci-spear.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-spear.c b/drivers/mmc/host/sdhci-spear.c index 7ae5b3a..2dba9f8 100644 --- a/drivers/mmc/host/sdhci-spear.c +++ b/drivers/mmc/host/sdhci-spear.c @@ -258,7 +258,6 @@ static int sdhci_probe(struct platform_device *pdev) return 0; set_drvdata: - platform_set_drvdata(pdev, NULL); sdhci_remove_host(host, 1); free_host: sdhci_free_host(host); @@ -278,7 +277,6 @@ static int sdhci_remove(struct platform_device *pdev) int dead = 0; u32 scratch; - platform_set_drvdata(pdev, NULL); scratch = readl(host->ioaddr + SDHCI_INT_STATUS); if (scratch == (u32)-1) dead = 1;