From patchwork Fri Sep 28 05:21:59 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Seungwon Jeon X-Patchwork-Id: 1516961 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 137EE3FE80 for ; Fri, 28 Sep 2012 05:22:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751272Ab2I1FWD (ORCPT ); Fri, 28 Sep 2012 01:22:03 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:9153 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915Ab2I1FWC (ORCPT ); Fri, 28 Sep 2012 01:22:02 -0400 Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MB100FXIO8J5VJ0@mailout1.samsung.com> for linux-mmc@vger.kernel.org; Fri, 28 Sep 2012 14:22:00 +0900 (KST) X-AuditID: cbfee61a-b7f726d000000ec7-b8-506533f8f888 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 50.D5.03783.8F335605; Fri, 28 Sep 2012 14:22:00 +0900 (KST) Received: from DOTGIHJUN01 ([12.23.118.161]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MB1005MEO8NBL90@mmp2.samsung.com> for linux-mmc@vger.kernel.org; Fri, 28 Sep 2012 14:22:00 +0900 (KST) From: Seungwon Jeon To: linux-mmc@vger.kernel.org Cc: 'Chris Ball' , 'Will Newton' , 'James Hogan' References: In-reply-to: Subject: [PATCH] mmc: dw_mmc: convert the variable type of irq Date: Fri, 28 Sep 2012 14:21:59 +0900 Message-id: <00f901cd9d39$2f84c720$8e8e5560$%jun@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac03z3aCvVFr8FaITt2vKVQKst76fw3Ogf7QC4iI1hA= Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsVy+t9jQd0fxqkBBl8WcFkc+d/P6MDo8XmT XABjFJdNSmpOZllqkb5dAlfGwcYLLAUtbBVr53eyNDB+Yuli5OSQEDCR2LvgLjOELSZx4d56 ti5GLg4hgemMErs7z0I5s5gkbu7bzg5SxSagJfH3zRuwDhEBWYmffy6wgdjMAsUSk64vYOxi 5ABq4JZY3RwEEuYU4JFY96cTrFxYwE7i45+FTCA2i4CqxK0Vb1hBbF4BW4ne3R/ZIWxBiR+T 77GAjGEWUJeYMiUXYrq8xOY1b5lBwhJA4Ud/dUFMEQEria2/rSAqRCT2vXjHOIFRaBaSObMQ 5sxCMmcWko4FjCyrGEVTC5ILipPScw31ihNzi0vz0vWS83M3MYID+JnUDsaVDRaHGAU4GJV4 eC1WpgQIsSaWFVfmHmKU4GBWEuF1XgwU4k1JrKxKLcqPLyrNSS0+xCjNwaIkztvsAZQSSE8s Sc1OTS1ILYLJMnFwSjUwLg/vNXzyxVPPKrfhSn393U8m+pyR3tJC7ypVZI63P1Qq5tb6ongv 4vS7yfekGh7XqZ+yP32qpLXrTslXz5u7mrySv2+ofRyuamxgvDT82oruC3P5m/ecXTqRNfk+ a8ZE4X3z+E3mXPUv/GeYd3XH1NNhS/+fe8eU5/BglsXC3GvHF27/9Fh+tRJLcUaioRZzUXEi ACmHM6FcAgAA Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Even though platform_get_irq returns error, 'host->irq' always has an unsigned value. Less-than-zero comparison of an unsigned value is never true. Type of 'unsigned int' will be changed for 'int'. Signed-off-by: Seungwon Jeon Acked-by: Will Newton --- include/linux/mmc/dw_mmc.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h index 7c6a113..3141676 100644 --- a/include/linux/mmc/dw_mmc.h +++ b/include/linux/mmc/dw_mmc.h @@ -186,7 +186,7 @@ struct dw_mci { struct regulator *vmmc; /* Power regulator */ unsigned long irq_flags; /* IRQ flags */ - unsigned int irq; + int irq; }; /* DMA ops for Internal/External DMAC interface */