From patchwork Mon Aug 15 02:28:18 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 1066422 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.4) with ESMTP id p7F2Ejuf001875 for ; Mon, 15 Aug 2011 02:14:45 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751289Ab1HOCOo (ORCPT ); Sun, 14 Aug 2011 22:14:44 -0400 Received: from mail-pz0-f42.google.com ([209.85.210.42]:65001 "EHLO mail-pz0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750869Ab1HOCOo (ORCPT ); Sun, 14 Aug 2011 22:14:44 -0400 Received: by pzk37 with SMTP id 37so2257688pzk.1 for ; Sun, 14 Aug 2011 19:14:43 -0700 (PDT) Received: by 10.142.180.3 with SMTP id c3mr1716021wff.211.1313374483125; Sun, 14 Aug 2011 19:14:43 -0700 (PDT) Received: from localhost.localdomain ([114.216.149.134]) by mx.google.com with ESMTPS id l10sm2840446pbl.62.2011.08.14.19.14.36 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 14 Aug 2011 19:14:42 -0700 (PDT) From: Shawn Guo To: linux-mmc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Chris Ball , Stephen Rothwell , patches@linaro.org, Shawn Guo Subject: [PATCH] mmc: sdhci-esdhc-imx: add missing inclusion of linux/module.h Date: Mon, 15 Aug 2011 10:28:18 +0800 Message-Id: <1313375298-18546-1-git-send-email-shawn.guo@linaro.org> X-Mailer: git-send-email 1.7.4.1 MIME-Version: 1.0 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Mon, 15 Aug 2011 02:15:11 +0000 (UTC) There are following warning and error when compiling the driver. The patch adds the missing inclusion of linux/module.h to fix them. drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: data definition has no type or storage class drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_DEVICE_TABLE’ drivers/mmc/host/sdhci-esdhc-imx.c:87:1: warning: parameter names (without types) in function declaration drivers/mmc/host/sdhci-esdhc-imx.c:96:1: warning: data definition has no type or storage class drivers/mmc/host/sdhci-esdhc-imx.c:96:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_DEVICE_TABLE’ drivers/mmc/host/sdhci-esdhc-imx.c:96:1: warning: parameter names (without types) in function declaration drivers/mmc/host/sdhci-esdhc-imx.c:563:12: error: ‘THIS_MODULE’ undeclared here (not in a function) drivers/mmc/host/sdhci-esdhc-imx.c:587:20: error: expected declaration specifiers or ‘...’ before string constant drivers/mmc/host/sdhci-esdhc-imx.c:587:1: warning: data definition has no type or storage class drivers/mmc/host/sdhci-esdhc-imx.c:587:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_DESCRIPTION’ drivers/mmc/host/sdhci-esdhc-imx.c:587:20: warning: function declaration isn’t a prototype drivers/mmc/host/sdhci-esdhc-imx.c:588:15: error: expected declaration specifiers or ‘...’ before string constant drivers/mmc/host/sdhci-esdhc-imx.c:588:1: warning: data definition has no type or storage class drivers/mmc/host/sdhci-esdhc-imx.c:588:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_AUTHOR’ drivers/mmc/host/sdhci-esdhc-imx.c:588:15: warning: function declaration isn’t a prototype drivers/mmc/host/sdhci-esdhc-imx.c:589:16: error: expected declaration specifiers or ‘...’ before string constant drivers/mmc/host/sdhci-esdhc-imx.c:589:1: warning: data definition has no type or storage class drivers/mmc/host/sdhci-esdhc-imx.c:589:1: warning: type defaults to ‘int’ in declaration of ‘MODULE_LICENSE’ drivers/mmc/host/sdhci-esdhc-imx.c:589:16: warning: function declaration isn’t a prototype Signed-off-by: Shawn Guo Cc: Chris Ball --- Hi Stephen, I spot this on linux-next-20110812. Regards, Shawn drivers/mmc/host/sdhci-esdhc-imx.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c index 2a1ba84..4557aa1 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include