From patchwork Thu Sep 1 19:05:57 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkatraman S X-Patchwork-Id: 1120272 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p81J7rli016334 for ; Thu, 1 Sep 2011 19:07:56 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757168Ab1IATHz (ORCPT ); Thu, 1 Sep 2011 15:07:55 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:44191 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757438Ab1IATHy (ORCPT ); Thu, 1 Sep 2011 15:07:54 -0400 Received: from dlep33.itg.ti.com ([157.170.170.112]) by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id p81J7fS6030679 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 1 Sep 2011 14:07:41 -0500 Received: from dlep26.itg.ti.com (smtp-le.itg.ti.com [157.170.170.27]) by dlep33.itg.ti.com (8.13.7/8.13.8) with ESMTP id p81J7fE2009710; Thu, 1 Sep 2011 14:07:41 -0500 (CDT) Received: from DFLE70.ent.ti.com (localhost [127.0.0.1]) by dlep26.itg.ti.com (8.13.8/8.13.8) with ESMTP id p81J7fjN002182; Thu, 1 Sep 2011 14:07:41 -0500 (CDT) Received: from dlelxv24.itg.ti.com (172.17.1.199) by dfle70.ent.ti.com (128.247.5.40) with Microsoft SMTP Server id 14.1.323.3; Thu, 1 Sep 2011 14:07:41 -0500 Received: from legion.dal.design.ti.com (legion.dal.design.ti.com [128.247.22.53]) by dlelxv24.itg.ti.com (8.13.8/8.13.8) with ESMTP id p81J7f2D028850; Thu, 1 Sep 2011 14:07:41 -0500 Received: from localhost (h83-2.vpn.ti.com [172.24.83.2]) by legion.dal.design.ti.com (8.11.7p1+Sun/8.11.7) with ESMTP id p81J7b008549; Thu, 1 Sep 2011 14:07:38 -0500 (CDT) From: Venkatraman S To: , CC: , , Venkatraman S Subject: [PATCH 2/2] omap: hsmmc: Don't hold spinlock during dma configuration Date: Fri, 2 Sep 2011 00:35:57 +0530 Message-ID: <1314903957-24408-3-git-send-email-svenkatr@ti.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: References: MIME-Version: 1.0 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Thu, 01 Sep 2011 19:07:56 +0000 (UTC) No need to hold the spinlock during a rather long dma configuration sequence inside dma callback, which doesn't need it. Signed-off-by: Venkatraman S --- drivers/mmc/host/omap_hsmmc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 5b7776c..c5fd413 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -1384,10 +1384,10 @@ static void omap_hsmmc_dma_cb(int lch, u16 ch_status, void *cb_data) data = host->mrq->data; host->dma_sg_idx++; if (host->dma_sg_idx < host->dma_len) { + spin_unlock(&host->irq_lock); /* Fire up the next transfer. */ omap_hsmmc_config_dma_params(host, data, data->sg + host->dma_sg_idx); - spin_unlock(&host->irq_lock); return; }