| Message ID | 1357605755-8872-1-git-send-email-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Dear Fabio Estevam, > From: Fabio Estevam <fabio.estevam@freescale.com> > > Fixes the following warning when building with W=1 option: > > drivers/mmc/host/mxs-mmc.c: In function 'mxs_mmc_adtc': > drivers/mmc/host/mxs-mmc.c:401:2: warning: comparison between signed and > unsigned integer expressions [-Wsign-compare] > > The warning happens because 'i' is used in 'for_each_sg(sgl, sg, sg_len, > i)' and should be made unsigned. > > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Nice Acked-by: Marek Vasut <marex@denx.de> > --- > drivers/mmc/host/mxs-mmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c > index 206fe49..eb33cb1 100644 > --- a/drivers/mmc/host/mxs-mmc.c > +++ b/drivers/mmc/host/mxs-mmc.c > @@ -354,7 +354,7 @@ static void mxs_mmc_adtc(struct mxs_mmc_host *host) > struct dma_async_tx_descriptor *desc; > struct scatterlist *sgl = data->sg, *sg; > unsigned int sg_len = data->sg_len; > - int i; > + unsigned int i; > > unsigned short dma_data_dir, timeout; > enum dma_transfer_direction slave_dirn; Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Tue, Jan 08 2013, Marek Vasut wrote: >> Fixes the following warning when building with W=1 option: >> >> drivers/mmc/host/mxs-mmc.c: In function 'mxs_mmc_adtc': >> drivers/mmc/host/mxs-mmc.c:401:2: warning: comparison between signed and >> unsigned integer expressions [-Wsign-compare] >> >> The warning happens because 'i' is used in 'for_each_sg(sgl, sg, sg_len, >> i)' and should be made unsigned. >> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > > Nice > > Acked-by: Marek Vasut <marex@denx.de> Thanks, pushed to mmc-next for 3.9. - Chris.
diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c index 206fe49..eb33cb1 100644 --- a/drivers/mmc/host/mxs-mmc.c +++ b/drivers/mmc/host/mxs-mmc.c @@ -354,7 +354,7 @@ static void mxs_mmc_adtc(struct mxs_mmc_host *host) struct dma_async_tx_descriptor *desc; struct scatterlist *sgl = data->sg, *sg; unsigned int sg_len = data->sg_len; - int i; + unsigned int i; unsigned short dma_data_dir, timeout; enum dma_transfer_direction slave_dirn;