| Message ID | 1367863561-11534-4-git-send-email-fabio.estevam@freescale.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Chris, On Mon, May 6, 2013 at 3:05 PM, Fabio Estevam <fabio.estevam@freescale.com> wrote: > Since commit ab78029 (drivers/pinctrl: grab default handles from device core), > we can rely on device core for handling pinctrl. > > So remove devm_pinctrl_get_select_default() from the driver. > > Cc: Chris Ball <cjb@laptop.org> > Cc: <linux-mmc@vger.kernel.org> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> Any comments on this one? -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Fabio, On Sun, May 26 2013, Fabio Estevam wrote: > Hi Chris, > > On Mon, May 6, 2013 at 3:05 PM, Fabio Estevam > <fabio.estevam@freescale.com> wrote: >> Since commit ab78029 (drivers/pinctrl: grab default handles from device core), >> we can rely on device core for handling pinctrl. >> >> So remove devm_pinctrl_get_select_default() from the driver. >> >> Cc: Chris Ball <cjb@laptop.org> >> Cc: <linux-mmc@vger.kernel.org> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> > > Any comments on this one? Thanks, pushed to mmc-next for 3.11. - Chris.
diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c index 4efe302..2f64e5a 100644 --- a/drivers/mmc/host/mxs-mmc.c +++ b/drivers/mmc/host/mxs-mmc.c @@ -41,7 +41,6 @@ #include <linux/gpio.h> #include <linux/regulator/consumer.h> #include <linux/module.h> -#include <linux/pinctrl/consumer.h> #include <linux/stmp_device.h> #include <linux/spi/mxs-spi.h> @@ -592,7 +591,6 @@ static int mxs_mmc_probe(struct platform_device *pdev) struct mxs_mmc_host *host; struct mmc_host *mmc; struct resource *iores, *dmares; - struct pinctrl *pinctrl; int ret = 0, irq_err, irq_dma; dma_cap_mask_t mask; struct regulator *reg_vmmc; @@ -651,12 +649,6 @@ static int mxs_mmc_probe(struct platform_device *pdev) } } - pinctrl = devm_pinctrl_get_select_default(&pdev->dev); - if (IS_ERR(pinctrl)) { - ret = PTR_ERR(pinctrl); - goto out_mmc_free; - } - ssp->clk = clk_get(&pdev->dev, NULL); if (IS_ERR(ssp->clk)) { ret = PTR_ERR(ssp->clk);
Since commit ab78029 (drivers/pinctrl: grab default handles from device core), we can rely on device core for handling pinctrl. So remove devm_pinctrl_get_select_default() from the driver. Cc: Chris Ball <cjb@laptop.org> Cc: <linux-mmc@vger.kernel.org> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com> --- drivers/mmc/host/mxs-mmc.c | 8 -------- 1 file changed, 8 deletions(-)