diff mbox

[1/1] mmc: sdhci-bcm2835: Staticize bcm2835_sdhci_get_min_clock

Message ID 1372228021-28895-1-git-send-email-sachin.kamat@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Sachin Kamat June 26, 2013, 6:27 a.m. UTC 
'bcm2835_sdhci_get_min_clock' is used only in this file.
Make it static.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/mmc/host/sdhci-bcm2835.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sachin Kamat July 23, 2013, 3:39 a.m. UTC | #1 
On 26 June 2013 11:57, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> 'bcm2835_sdhci_get_min_clock' is used only in this file.
> Make it static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/mmc/host/sdhci-bcm2835.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci-bcm2835.c
> index 0584a1c..36fa2df 100644
> --- a/drivers/mmc/host/sdhci-bcm2835.c
> +++ b/drivers/mmc/host/sdhci-bcm2835.c
> @@ -119,7 +119,7 @@ static u8 bcm2835_sdhci_readb(struct sdhci_host *host, int reg)
>         return byte;
>  }
>
> -unsigned int bcm2835_sdhci_get_min_clock(struct sdhci_host *host)
> +static unsigned int bcm2835_sdhci_get_min_clock(struct sdhci_host *host)
>  {
>         return MIN_FREQ;
>  }
> --
> 1.7.9.5
>

Ping..
Sachin Kamat Aug. 2, 2013, 8:49 a.m. UTC | #2 
On 26 June 2013 11:57, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> 'bcm2835_sdhci_get_min_clock' is used only in this file.
> Make it static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/mmc/host/sdhci-bcm2835.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci-bcm2835.c
> index 0584a1c..36fa2df 100644
> --- a/drivers/mmc/host/sdhci-bcm2835.c
> +++ b/drivers/mmc/host/sdhci-bcm2835.c
> @@ -119,7 +119,7 @@ static u8 bcm2835_sdhci_readb(struct sdhci_host *host, int reg)
>         return byte;
>  }
>
> -unsigned int bcm2835_sdhci_get_min_clock(struct sdhci_host *host)
> +static unsigned int bcm2835_sdhci_get_min_clock(struct sdhci_host *host)
>  {
>         return MIN_FREQ;
>  }
> --
> 1.7.9.5
>
Chris,

Any comments on this patch?
Chris Ball Aug. 25, 2013, 1:38 a.m. UTC | #3 
Hi Sachin,

On Wed, Jun 26 2013, Sachin Kamat wrote:
> 'bcm2835_sdhci_get_min_clock' is used only in this file.
> Make it static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  drivers/mmc/host/sdhci-bcm2835.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci-bcm2835.c
> index 0584a1c..36fa2df 100644
> --- a/drivers/mmc/host/sdhci-bcm2835.c
> +++ b/drivers/mmc/host/sdhci-bcm2835.c
> @@ -119,7 +119,7 @@ static u8 bcm2835_sdhci_readb(struct sdhci_host *host, int reg)
>  	return byte;
>  }
>  
> -unsigned int bcm2835_sdhci_get_min_clock(struct sdhci_host *host)
> +static unsigned int bcm2835_sdhci_get_min_clock(struct sdhci_host *host)
>  {
>  	return MIN_FREQ;
>  }

Thanks, pushed to mmc-next for 3.12.

- Chris.
diff mbox

Patch

diff --git a/drivers/mmc/host/sdhci-bcm2835.c b/drivers/mmc/host/sdhci-bcm2835.c
index 0584a1c..36fa2df 100644
--- a/drivers/mmc/host/sdhci-bcm2835.c
+++ b/drivers/mmc/host/sdhci-bcm2835.c
@@ -119,7 +119,7 @@  static u8 bcm2835_sdhci_readb(struct sdhci_host *host, int reg)
 	return byte;
 }
 
-unsigned int bcm2835_sdhci_get_min_clock(struct sdhci_host *host)
+static unsigned int bcm2835_sdhci_get_min_clock(struct sdhci_host *host)
 {
 	return MIN_FREQ;
 }