| Message ID | 1373298887-9877-6-git-send-email-g.liakhovetski@gmx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Guennadi > diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c > index cc4c872..b58c1a9 100644 > --- a/drivers/mmc/host/sh_mobile_sdhi.c > +++ b/drivers/mmc/host/sh_mobile_sdhi.c > @@ -130,6 +130,9 @@ static const struct of_device_id sh_mobile_sdhi_of_match[] = { > { .compatible = "renesas,shmobile-sdhi" }, > { .compatible = "renesas,sh7372-sdhi" }, > { .compatible = "renesas,r8a7740-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > + { .compatible = "renesas,sh73a0-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > + { .compatible = "renesas,r8a73a4-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > + { .compatible = "renesas,r8a7790-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > {}, According to HW people, latest Renesas chip needs "TMIO_MMC_HAS_IDLE_WAIT". Could you plase add r8a7778 / r8a7779 here ? # or we can use common compatible name for it ? Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jul 08, 2013 at 11:09:07PM -0700, Kuninori Morimoto wrote: > > Hi Guennadi > > > diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c > > index cc4c872..b58c1a9 100644 > > --- a/drivers/mmc/host/sh_mobile_sdhi.c > > +++ b/drivers/mmc/host/sh_mobile_sdhi.c > > @@ -130,6 +130,9 @@ static const struct of_device_id sh_mobile_sdhi_of_match[] = { > > { .compatible = "renesas,shmobile-sdhi" }, > > { .compatible = "renesas,sh7372-sdhi" }, > > { .compatible = "renesas,r8a7740-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > + { .compatible = "renesas,sh73a0-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > + { .compatible = "renesas,r8a73a4-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > + { .compatible = "renesas,r8a7790-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > {}, > > According to HW people, latest Renesas chip needs "TMIO_MMC_HAS_IDLE_WAIT". > Could you plase add r8a7778 / r8a7779 here ? > > # or we can use common compatible name for it ? Hi Guennadi, could you please address Morimoto-san's review? -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Simon > > > diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c > > > index cc4c872..b58c1a9 100644 > > > --- a/drivers/mmc/host/sh_mobile_sdhi.c > > > +++ b/drivers/mmc/host/sh_mobile_sdhi.c > > > @@ -130,6 +130,9 @@ static const struct of_device_id sh_mobile_sdhi_of_match[] = { > > > { .compatible = "renesas,shmobile-sdhi" }, > > > { .compatible = "renesas,sh7372-sdhi" }, > > > { .compatible = "renesas,r8a7740-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > > + { .compatible = "renesas,sh73a0-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > > + { .compatible = "renesas,r8a73a4-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > > + { .compatible = "renesas,r8a7790-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > > {}, > > > > According to HW people, latest Renesas chip needs "TMIO_MMC_HAS_IDLE_WAIT". > > Could you plase add r8a7778 / r8a7779 here ? > > > > # or we can use common compatible name for it ? > > Hi Guennadi, > > could you please address Morimoto-san's review? He did it on Subject: [PATCH v4 5/7] mmc: SDHI: add DT compatibility strings for further SoCs Date: Tue, 9 Jul 2013 09:43:40 +0200 (CEST) Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 09, 2013 at 06:02:00PM -0700, Kuninori Morimoto wrote: > > Hi Simon > > > > > diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c > > > > index cc4c872..b58c1a9 100644 > > > > --- a/drivers/mmc/host/sh_mobile_sdhi.c > > > > +++ b/drivers/mmc/host/sh_mobile_sdhi.c > > > > @@ -130,6 +130,9 @@ static const struct of_device_id sh_mobile_sdhi_of_match[] = { > > > > { .compatible = "renesas,shmobile-sdhi" }, > > > > { .compatible = "renesas,sh7372-sdhi" }, > > > > { .compatible = "renesas,r8a7740-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > > > + { .compatible = "renesas,sh73a0-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > > > + { .compatible = "renesas,r8a73a4-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > > > + { .compatible = "renesas,r8a7790-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > > > {}, > > > > > > According to HW people, latest Renesas chip needs "TMIO_MMC_HAS_IDLE_WAIT". > > > Could you plase add r8a7778 / r8a7779 here ? > > > > > > # or we can use common compatible name for it ? > > > > Hi Guennadi, > > > > could you please address Morimoto-san's review? > > He did it on > > Subject: [PATCH v4 5/7] mmc: SDHI: add DT compatibility strings for further SoCs > Date: Tue, 9 Jul 2013 09:43:40 +0200 (CEST) Thanks for pointing that out. Somehow I missed it. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c index cc4c872..b58c1a9 100644 --- a/drivers/mmc/host/sh_mobile_sdhi.c +++ b/drivers/mmc/host/sh_mobile_sdhi.c @@ -130,6 +130,9 @@ static const struct of_device_id sh_mobile_sdhi_of_match[] = { { .compatible = "renesas,shmobile-sdhi" }, { .compatible = "renesas,sh7372-sdhi" }, { .compatible = "renesas,r8a7740-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, + { .compatible = "renesas,sh73a0-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, + { .compatible = "renesas,r8a73a4-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, + { .compatible = "renesas,r8a7790-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, {}, }; MODULE_DEVICE_TABLE(of, sh_mobile_sdhi_of_match);
Add further OF compatibility strings to the SDHI driver to be able to precisely control driver's behaviour on each of them. Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com> Cc: linux-mmc@vger.kernel.org Cc: Chris Ball <cjb@laptop.org> --- As explained in patch 0/7, this patch can be pushed separately via the mmc git-tree. drivers/mmc/host/sh_mobile_sdhi.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)