diff mbox

[1/2] dw_mmc-pci: get resources from a proper BAR

Message ID 1375958698-10569-1-git-send-email-andriy.shevchenko@linux.intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Andy Shevchenko Aug. 8, 2013, 10:44 a.m. UTC
There is a typo when the mapped space is from BAR 2, but BAR 0 is used instead.
This patch fixes the typo.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/mmc/host/dw_mmc-pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Prabu Thangamuthu Aug. 12, 2013, 7:34 a.m. UTC | #1
Tested-by: Prabu Thangamuthu <Prabu.T@synopsys.com>

Regards,
Prabu Thangamuthu.

On 08/12/2013 04:15 PM, Andy Shevchenko wrote:
> There is a typo when the mapped space is from BAR 2, but BAR 0 is used
> instead.
> This patch fixes the typo.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/mmc/host/dw_mmc-pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc-pci.c b/drivers/mmc/host/dw_mmc-
> pci.c index b456b0c..7d148d6 100644
> --- a/drivers/mmc/host/dw_mmc-pci.c
> +++ b/drivers/mmc/host/dw_mmc-pci.c
> @@ -59,7 +59,7 @@ static int dw_mci_pci_probe(struct pci_dev *pdev,
>  	if (ret)
>  		return ret;
> 
> -	host->regs = pcim_iomap_table(pdev)[0];
> +	host->regs = pcim_iomap_table(pdev)[PCI_BAR_NO];
> 
>  	ret = dw_mci_probe(host);
>  	if (ret)
> --
> 1.8.4.rc1

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Seungwon Jeon Aug. 12, 2013, 10:33 a.m. UTC | #2
On Monday, August 12, 2013, Prabu Thangamuthu wrote:
> 
> Tested-by: Prabu Thangamuthu <Prabu.T@synopsys.com>
> 
> Regards,
> Prabu Thangamuthu.
> 
> On 08/12/2013 04:15 PM, Andy Shevchenko wrote:
> > There is a typo when the mapped space is from BAR 2, but BAR 0 is used
> > instead.
> > This patch fixes the typo.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Seungwon Jeon <tgih.jun@samsung.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Chris Ball Aug. 25, 2013, 4:02 a.m. UTC | #3
Hi Andy,

On Thu, Aug 08 2013, Andy Shevchenko wrote:
> There is a typo when the mapped space is from BAR 2, but BAR 0 is used instead.
> This patch fixes the typo.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/mmc/host/dw_mmc-pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-pci.c b/drivers/mmc/host/dw_mmc-pci.c
> index b456b0c..7d148d6 100644
> --- a/drivers/mmc/host/dw_mmc-pci.c
> +++ b/drivers/mmc/host/dw_mmc-pci.c
> @@ -59,7 +59,7 @@ static int dw_mci_pci_probe(struct pci_dev *pdev,
>  	if (ret)
>  		return ret;
>  
> -	host->regs = pcim_iomap_table(pdev)[0];
> +	host->regs = pcim_iomap_table(pdev)[PCI_BAR_NO];
>  
>  	ret = dw_mci_probe(host);
>  	if (ret)

Thanks, pushed to mmc-next for 3.12.

- Chris.
diff mbox

Patch

diff --git a/drivers/mmc/host/dw_mmc-pci.c b/drivers/mmc/host/dw_mmc-pci.c
index b456b0c..7d148d6 100644
--- a/drivers/mmc/host/dw_mmc-pci.c
+++ b/drivers/mmc/host/dw_mmc-pci.c
@@ -59,7 +59,7 @@  static int dw_mci_pci_probe(struct pci_dev *pdev,
 	if (ret)
 		return ret;
 
-	host->regs = pcim_iomap_table(pdev)[0];
+	host->regs = pcim_iomap_table(pdev)[PCI_BAR_NO];
 
 	ret = dw_mci_probe(host);
 	if (ret)