From patchwork Wed Oct 30 14:10:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 3114881 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4B8C39F3E2 for ; Wed, 30 Oct 2013 14:29:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 25E3A20219 for ; Wed, 30 Oct 2013 14:29:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FE9F201BF for ; Wed, 30 Oct 2013 14:29:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754566Ab3J3O3r (ORCPT ); Wed, 30 Oct 2013 10:29:47 -0400 Received: from va3ehsobe004.messaging.microsoft.com ([216.32.180.14]:20138 "EHLO va3outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753167Ab3J3O3q (ORCPT ); Wed, 30 Oct 2013 10:29:46 -0400 Received: from mail37-va3-R.bigfish.com (10.7.14.232) by VA3EHSOBE009.bigfish.com (10.7.40.29) with Microsoft SMTP Server id 14.1.225.22; Wed, 30 Oct 2013 14:29:45 +0000 Received: from mail37-va3 (localhost [127.0.0.1]) by mail37-va3-R.bigfish.com (Postfix) with ESMTP id B17E320007B; Wed, 30 Oct 2013 14:29:45 +0000 (UTC) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI X-SpamScore: 3 X-BigFish: VS3(zzzz1f42h208ch1ee6h1de0h1fdah2073h1202h1e76h1d1ah1d2ah1fc6h1082kzz1de098h8275bh1de097hz2dh2a8h839hd24he5bhf0ah1288h12a5h12a9h12bdh12e5h137ah139eh13b6h1441h1504h1537h162dh1631h1758h1898h18e1h1946h19b5h1ad9h1b0ah1b2fh1fb3h1d0ch1d2eh1d3fh1dfeh1dffh1e23h1fe8h1ff5h2218h2216h1155h) Received: from mail37-va3 (localhost.localdomain [127.0.0.1]) by mail37-va3 (MessageSwitch) id 1383143383721620_31713; Wed, 30 Oct 2013 14:29:43 +0000 (UTC) Received: from VA3EHSMHS002.bigfish.com (unknown [10.7.14.251]) by mail37-va3.bigfish.com (Postfix) with ESMTP id AB5B5300040; Wed, 30 Oct 2013 14:29:43 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by VA3EHSMHS002.bigfish.com (10.7.99.12) with Microsoft SMTP Server (TLS) id 14.16.227.3; Wed, 30 Oct 2013 14:29:43 +0000 Received: from az84smr01.freescale.net (10.64.34.197) by 039-SN1MMR1-001.039d.mgd.msft.net (10.84.1.13) with Microsoft SMTP Server (TLS) id 14.3.158.2; Wed, 30 Oct 2013 14:29:43 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id r9UETbSg013528; Wed, 30 Oct 2013 07:29:40 -0700 From: Dong Aisheng To: CC: , , , , , Subject: [PATCH 1/2] mmc: sdhci: replace msleep with mdelay for tuning Date: Wed, 30 Oct 2013 22:10:41 +0800 Message-ID: <1383142242-24989-2-git-send-email-b29396@freescale.com> X-Mailer: git-send-email 1.7.2.rc3 In-Reply-To: <1383142242-24989-1-git-send-email-b29396@freescale.com> References: <1383142242-24989-1-git-send-email-b29396@freescale.com> MIME-Version: 1.0 X-FOPE-CONNECTOR: Id%0$Dn%*$RO%0$TLS%0$FQDN%$TlsDn% Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The former patch 404aceb may break the tuning process of SD3.0/eMMC4.5 cards. It changed the mdelay in tuning process to msleep, However, because the more delay of msleep(1) than mdelay(1), it will easily lead to a 150ms timeout as limited by the spec. We oberved tuning failed due to timeout on a Toshiba UHS and eMMC4.5 card after this change. Thus, for the time sensitive tuning process, change it back to mdelay as before. The breaking patch is: 404aceb mmc: sdhci: Get rid of mdelay()s where it is safe and makes sense Signed-off-by: Dong Aisheng --- drivers/mmc/host/sdhci.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 22eab3a..2ef5314 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -1981,7 +1981,7 @@ static int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode) ctrl = sdhci_readw(host, SDHCI_HOST_CONTROL2); tuning_loop_counter--; - msleep(1); + mdelay(1); } while (ctrl & SDHCI_CTRL_EXEC_TUNING); /*