From patchwork Wed Jan 15 07:15:59 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhangfei Gao X-Patchwork-Id: 3490451 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 03F9F9F381 for ; Wed, 15 Jan 2014 07:16:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 311D9200F3 for ; Wed, 15 Jan 2014 07:16:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 617D5200EC for ; Wed, 15 Jan 2014 07:16:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751436AbaAOHQv (ORCPT ); Wed, 15 Jan 2014 02:16:51 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:65434 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750928AbaAOHQv (ORCPT ); Wed, 15 Jan 2014 02:16:51 -0500 Received: by mail-pa0-f52.google.com with SMTP id kx10so771691pab.11 for ; Tue, 14 Jan 2014 23:16:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/EewXP9t9s7zGiMG8gGIoyqE8oHvPdDCe6zWnBX1NNE=; b=j1pjOgDvXIG3/xcaE2Vb/g1glLMJB/6Dv4tQ5d8dVOwqNR2r7ACmQ7JsayiMOxoB0A ReTi19KQ4msHiWM3zdQ4WqI/inKpkJGAakx4g24Iq0c5hbvKTUSP6idYMVrMfCRmEMrn vmWLyfDIAgKvJ+OiI52RYu9h92BnUxXi5Tr+M5TVVSWluxc+oiM1KmFd6dvHjDv+8dvC 6nBzL2TFSbSIZJf0sCzZ83kYdPgs7ElnR7aS5pZaxjU5iTBjrpjzEIccmsgnoFucRbwx WZgq08x+WIBvG8FhYTHOh9Z8UWfEFuP/SupRsYOjQBFsCdjCvG4O2RDArniDSB0mieqV b8qQ== X-Gm-Message-State: ALoCoQmVcaCaTlW36iYZvyDgPiyQJ/G0Kto6ywvRGpCJZsi2/wUBwCRH48Rz4xz9gDYF4XVRfdAF X-Received: by 10.66.190.198 with SMTP id gs6mr726384pac.49.1389770210654; Tue, 14 Jan 2014 23:16:50 -0800 (PST) Received: from localhost.localdomain ([124.73.90.72]) by mx.google.com with ESMTPSA id iq10sm5932707pbc.14.2014.01.14.23.16.41 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 14 Jan 2014 23:16:50 -0800 (PST) From: Zhangfei Gao To: Kevin Hilman , Chris Ball , Arnd Bergmann , Mike Turquette , Jaehoon Chung , Seungwon Jeon , Haojian Zhuang Cc: linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@linaro.org, Zhangfei Gao Subject: [PATCH] mmc: dw_mmc: fix dw_mci_get_cd Date: Wed, 15 Jan 2014 15:15:59 +0800 Message-Id: <1389770159-21125-1-git-send-email-zhangfei.gao@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: References: Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Introdeced from commit b7db86adfa58b CDETECT is ingored since IS_ERR_VALUE(!mmc_gpio_get_cd(mmc)) does not work Add spin_lock_bh(&host->lock) for atomic accessing DW_MMC_CARD_PRESENT Signed-off-by: Zhangfei Gao Reported-by: Kevin Hilman --- drivers/mmc/host/dw_mmc.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index a776f24f4311..9ded62c8225e 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -1033,7 +1033,8 @@ static int dw_mci_get_cd(struct mmc_host *mmc) int present; struct dw_mci_slot *slot = mmc_priv(mmc); struct dw_mci_board *brd = slot->host->pdata; - int gpio_cd = !mmc_gpio_get_cd(mmc); + struct dw_mci *host = slot->host; + int gpio_cd = mmc_gpio_get_cd(mmc); /* Use platform get_cd function, else try onboard card detect */ if (brd->quirks & DW_MCI_QUIRK_BROKEN_CARD_DETECTION) @@ -1041,11 +1042,12 @@ static int dw_mci_get_cd(struct mmc_host *mmc) else if (brd->get_cd) present = !brd->get_cd(slot->id); else if (!IS_ERR_VALUE(gpio_cd)) - present = !!gpio_cd; + present = !gpio_cd; else present = (mci_readl(slot->host, CDETECT) & (1 << slot->id)) == 0 ? 1 : 0; + spin_lock_bh(&host->lock); if (present) { set_bit(DW_MMC_CARD_PRESENT, &slot->flags); dev_dbg(&mmc->class_dev, "card is present\n"); @@ -1053,6 +1055,7 @@ static int dw_mci_get_cd(struct mmc_host *mmc) clear_bit(DW_MMC_CARD_PRESENT, &slot->flags); dev_dbg(&mmc->class_dev, "card is not present\n"); } + spin_unlock_bh(&host->lock); return present; } @@ -2081,7 +2084,7 @@ static int dw_mci_of_get_wp_gpio(struct device *dev, u8 slot) return gpio; } -/* find the cd gpio for a given slot; or -1 if none specified */ +/* find the cd gpio for a given slot */ static void dw_mci_of_get_cd_gpio(struct device *dev, u8 slot, struct mmc_host *mmc) {