From patchwork Tue Jan 28 08:40:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Romain Izard X-Patchwork-Id: 3545791 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 593929F2E9 for ; Tue, 28 Jan 2014 08:41:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5193120154 for ; Tue, 28 Jan 2014 08:41:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2A4C220125 for ; Tue, 28 Jan 2014 08:41:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754985AbaA1IlB (ORCPT ); Tue, 28 Jan 2014 03:41:01 -0500 Received: from mail-wg0-f50.google.com ([74.125.82.50]:41362 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754987AbaA1Ik7 (ORCPT ); Tue, 28 Jan 2014 03:40:59 -0500 Received: by mail-wg0-f50.google.com with SMTP id l18so163277wgh.17 for ; Tue, 28 Jan 2014 00:40:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=XEixSXy2nLoE8zbDTXil9SClaKWRKbvHLltvoQN8wrw=; b=wK1UmQ041iEnAQy8ULAimQ5Wu6CsdXbLUS4IwYznUuzlgC4X2fLem8ciJgkgKCVAPr F5lk+YQj0ufkz9p2BFF14uEidLQlW/OMp6NRflgcOJ/1yU/DUGPrINrbG6MFc1dpS0un EUCh3lvbWvisj9obO3NsMZSLv8NKylCRTwLdUMs7yU5WfHysYRmBXqcHmzy5p6lRrK38 +YJZuYYN/phd9s8+kaWUckBKEIJRdhY309bTY1NfgI++uzM/TcgONvBrI+CATrpaEwKd oXIAD0cfIQzbma8JQdwc8g/TeSlsLUYYuVzVtL7xIHqLONa3D1ceujDf/IQ4b+hmalf/ DixA== X-Received: by 10.195.13.164 with SMTP id ez4mr183634wjd.11.1390898456699; Tue, 28 Jan 2014 00:40:56 -0800 (PST) Received: from localhost.localdomain (ram94-11-88-187-113-157.fbx.proxad.net. [88.187.113.157]) by mx.google.com with ESMTPSA id z1sm31490527wjq.19.2014.01.28.00.40.55 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 28 Jan 2014 00:40:56 -0800 (PST) From: Romain Izard To: Chris Ball Cc: linux-mmc@vger.kernel.org, Ulf Hansson , Romain Izard Subject: [PATCH RESEND] =?UTF-8?q?mmc:=20Allow=20forward=20compatibility?= =?UTF-8?q?=20for=20e=E2=8B=85MMC?= Date: Tue, 28 Jan 2014 09:40:02 +0100 Message-Id: <1390898402-16174-1-git-send-email-romain.izard.pro@gmail.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1385714317-28911-1-git-send-email-romain.izard.pro@gmail.com> References: <1385714317-28911-1-git-send-email-romain.izard.pro@gmail.com> MIME-Version: 1.0 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As stated by the e?MMC 5.0 specification, a chip should not be rejected only because of the revision stated in the EXT_CSD_REV field of the EXT_CSD register. Remove the control on this value, the control of the CSD_STRUCTURE field should be sufficient to reject future incompatible changes. Acked-by: Ulf Hansson Signed-off-by: Romain Izard --- drivers/mmc/core/mmc.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index 98e9eb0f6643..81c23e4db704 100644 --- a/drivers/mmc/core/mmc.c +++ b/drivers/mmc/core/mmc.c @@ -293,13 +293,12 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd) } } + /* + * The EXT_CSD format is meant to be forward compatible. As long + * as CSD_STRUCTURE does not change, all values for EXT_CSD_REV + * are authorized, see JEDEC JESD84-B50 section B.8. + */ card->ext_csd.rev = ext_csd[EXT_CSD_REV]; - if (card->ext_csd.rev > 7) { - pr_err("%s: unrecognised EXT_CSD revision %d\n", - mmc_hostname(card->host), card->ext_csd.rev); - err = -EINVAL; - goto out; - } card->ext_csd.raw_sectors[0] = ext_csd[EXT_CSD_SEC_CNT + 0]; card->ext_csd.raw_sectors[1] = ext_csd[EXT_CSD_SEC_CNT + 1];