diff mbox

[2/6] mmc: Fix incorrect warning when setting 0 Hz via debugfs

Message ID 1411502430-25535-3-git-send-email-adrian.hunter@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Adrian Hunter Sept. 23, 2014, 8 p.m. UTC
It is possible to turn off the card clock by setting
the frequency to zero via debugfs e.g.

	echo 0 > /sys/kernel/debug/mmc0/clock

However that produces an incorrect warning that is
designed to warn if the frequency is below the minimum
operating frequency.  So correct the warning.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
 drivers/mmc/core/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ulf Hansson Sept. 29, 2014, 9:44 a.m. UTC | #1
On 23 September 2014 22:00, Adrian Hunter <adrian.hunter@intel.com> wrote:
> It is possible to turn off the card clock by setting
> the frequency to zero via debugfs e.g.
>
>         echo 0 > /sys/kernel/debug/mmc0/clock
>
> However that produces an incorrect warning that is
> designed to warn if the frequency is below the minimum
> operating frequency.  So correct the warning.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>

Thanks! Applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/core/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index e2e1dd4..16aa7bd 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -995,7 +995,7 @@ void mmc_set_chip_select(struct mmc_host *host, int mode)
>   */
>  static void __mmc_set_clock(struct mmc_host *host, unsigned int hz)
>  {
> -       WARN_ON(hz < host->f_min);
> +       WARN_ON(hz && hz < host->f_min);
>
>         if (hz > host->f_max)
>                 hz = host->f_max;
> --
> 1.8.3.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index e2e1dd4..16aa7bd 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -995,7 +995,7 @@  void mmc_set_chip_select(struct mmc_host *host, int mode)
  */
 static void __mmc_set_clock(struct mmc_host *host, unsigned int hz)
 {
-	WARN_ON(hz < host->f_min);
+	WARN_ON(hz && hz < host->f_min);
 
 	if (hz > host->f_max)
 		hz = host->f_max;