| Message ID | 1415771382-30831-1-git-send-email-jh80.chung@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 12 November 2014 06:49, Jaehoon Chung <jh80.chung@samsung.com> wrote: > Recommend to use "mmc-cap-highspeed" or "sd-cap-highspeed" instead of > "supports-highspeed". > Although "supports-highspeed" supports, devloper can use > "mmc-cap-highspeed" or "sd-cap-highspeed" through this message. > > Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> > --- > Changelog V2: > - Fixed Checkpatch warning > > drivers/mmc/host/dw_mmc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index bb46b1b..d75dc26 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -2434,8 +2434,11 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host) > return ERR_PTR(ret); > } > > - if (of_find_property(np, "supports-highspeed", NULL)) > + if (of_find_property(np, "supports-highspeed", NULL)) { > + dev_warn(dev, "supports-highspeed is deprecated. " \ > + "Use cap-mmc-highspeed or cap-sd-highspeed.\n"); Hi Jaehoon, This will cause checkpatch warnings which I think we shall fix. Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index bb46b1b..d75dc26 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -2434,8 +2434,11 @@ static struct dw_mci_board *dw_mci_parse_dt(struct dw_mci *host) return ERR_PTR(ret); } - if (of_find_property(np, "supports-highspeed", NULL)) + if (of_find_property(np, "supports-highspeed", NULL)) { + dev_warn(dev, "supports-highspeed is deprecated. " \ + "Use cap-mmc-highspeed or cap-sd-highspeed.\n"); pdata->caps |= MMC_CAP_SD_HIGHSPEED | MMC_CAP_MMC_HIGHSPEED; + } return pdata; }
Recommend to use "mmc-cap-highspeed" or "sd-cap-highspeed" instead of "supports-highspeed". Although "supports-highspeed" supports, devloper can use "mmc-cap-highspeed" or "sd-cap-highspeed" through this message. Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com> --- Changelog V2: - Fixed Checkpatch warning drivers/mmc/host/dw_mmc.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)