From patchwork Sun Feb 1 20:20:22 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joe Perches X-Patchwork-Id: 5757701 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 663ADBF440 for ; Sun, 1 Feb 2015 20:20:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8530C20253 for ; Sun, 1 Feb 2015 20:20:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8658C2012E for ; Sun, 1 Feb 2015 20:20:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754137AbbBAUU1 (ORCPT ); Sun, 1 Feb 2015 15:20:27 -0500 Received: from smtprelay0055.hostedemail.com ([216.40.44.55]:56383 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754134AbbBAUU0 (ORCPT ); Sun, 1 Feb 2015 15:20:26 -0500 Received: from filter.hostedemail.com (unknown [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id 8F7BC3519F4; Sun, 1 Feb 2015 20:20:25 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2, 0, 0, , d41d8cd98f00b204, joe@perches.com, :::::::::::::, RULES_HIT:41:355:379:541:599:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3653:3874:3876:4321:4384:4389:4395:4605:5007:6119:6261:10004:10400:10471:10848:11026:11232:11473:11657:11658:11914:12043:12295:12296:12517:12519:12555:12679:12740:13255:13548:14093:14096:14097:21080, 0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5, Netcheck:none, DomainCache:0, MSF:not bulk, SPF:fn, MSBL:0, DNSBL:none, Custom_rules:0:0:0 X-HE-Tag: girl98_3858313c8056 X-Filterd-Recvd-Size: 3164 Received: from joe-X200MA.home (pool-71-103-235-196.lsanca.fios.verizon.net [71.103.235.196]) (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA; Sun, 1 Feb 2015 20:20:24 +0000 (UTC) Message-ID: <1422822022.12856.3.camel@perches.com> Subject: Re: [PATCH 2/5] drivers: mmc: card: Fixes Missing blank line after variable initialization, coding style warning From: Joe Perches To: Sheetal Tigadoli Cc: chris@printf.net, linux-mmc@vger.kernel.org, ben@decadent.org.uk, kuninori.morimoto.gx@renesas.com, ulf.hansson@linaro.org, linux-kernel@vger.kernel.org Date: Sun, 01 Feb 2015 12:20:22 -0800 In-Reply-To: <1422821222-24079-3-git-send-email-sheetal.tigadoli@gmail.com> References: <1422821222-24079-1-git-send-email-sheetal.tigadoli@gmail.com> <1422821222-24079-2-git-send-email-sheetal.tigadoli@gmail.com> <1422821222-24079-3-git-send-email-sheetal.tigadoli@gmail.com> X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, 2015-02-02 at 01:36 +0530, Sheetal Tigadoli wrote: > This patch fixes "Missing blank line warnings". Following lines show warnings > generated upon running checkpatch.pl script > > drivers/mmc/card/block.c:186: WARNING: Missing a blank line after declarations > drivers/mmc/card/block.c:280: WARNING: Missing a blank line after declarations > drivers/mmc/card/block.c:620: WARNING: Missing a blank line after declarations > drivers/mmc/card/block.c:1720: WARNING: Missing a blank line after declarations 4 lines here, 3 changes below? > drivers/mmc/card/block.c | 3 +++ > 1 file changed, 3 insertions(+) btw: checkpatch has a --fix feature that could help For instance, this: $ ./scripts/checkpatch.pl -f --types=line_spacing --fix-inplace drivers/mmc/card/block.c $ git diff drivers/mmc/card/block.c --- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c index c69afb5..247044f 100644 --- a/drivers/mmc/card/block.c +++ b/drivers/mmc/card/block.c @@ -183,6 +183,7 @@ static void mmc_blk_put(struct mmc_blk_data *md) md->usage--; if (md->usage == 0) { int devidx = mmc_get_devidx(md->disk); + blk_cleanup_queue(md->queue.queue); __clear_bit(devidx, dev_use); @@ -277,6 +278,7 @@ static ssize_t force_ro_store(struct device *dev, struct device_attribute *attr, char *end; struct mmc_blk_data *md = mmc_blk_get(dev_to_disk(dev)); unsigned long set = simple_strtoul(buf, &end, 0); + if (end == buf) { ret = -EINVAL; goto out; @@ -617,6 +619,7 @@ static int mmc_blk_ioctl(struct block_device *bdev, fmode_t mode, unsigned int cmd, unsigned long arg) { int ret = -EINVAL; + if (cmd == MMC_IOC_CMD) ret = mmc_blk_ioctl_cmd(bdev, (struct mmc_ioc_cmd __user *)arg); return ret; @@ -1717,6 +1720,7 @@ static int mmc_blk_cmd_err(struct mmc_blk_data *md, struct mmc_card *card, int ret) { struct mmc_queue_req *mq_rq; + mq_rq = container_of(brq, struct mmc_queue_req, brq); /*