From patchwork Fri Oct 9 01:03:51 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcin Wojtas X-Patchwork-Id: 7358521 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 31525BF90C for ; Fri, 9 Oct 2015 00:58:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4D675207B9 for ; Fri, 9 Oct 2015 00:58:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4613A207D3 for ; Fri, 9 Oct 2015 00:58:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753798AbbJIA6n (ORCPT ); Thu, 8 Oct 2015 20:58:43 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:33904 "EHLO mail-lb0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752721AbbJIA4m (ORCPT ); Thu, 8 Oct 2015 20:56:42 -0400 Received: by lbbwt4 with SMTP id wt4so64942690lbb.1 for ; Thu, 08 Oct 2015 17:56:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=d64x9AsZw80uM1zGpU3A24DRATlvmEyHHlQdOrUVpFY=; b=mBZWWqM3HdtO+07YUBaHiNtHhic+5EjVlAwCesC3ZXWQE92MoJQJrr42YIPhsntXe5 fBRHDWV2O60nMV/LsrazYDaw3PU32mIxVnG2D8ju2AoO3UyUBS6e/SjMJsxscBp3uPa/ Gy52Z53i5+Z/0zcps0HBIcYD3qOVJKTuR/fG1XsRLIdnLCrygsvWnLehQ/r8LvE0U93r hVT1XBG9PY3ZnwxCqsKs491QVTUF5gpjL/iqKxz4KDHt3GE0yFaE0jABw69FwDZrWypV sMqXYLSM/fikv+dinwsbbAS9SIBHTx77WUaHu+Tu80iJDUzoYvoUoUFOXQ0K0BWd2Zbu woXQ== X-Gm-Message-State: ALoCoQnNTUYnPADSVxYMbp/tb3xUFvkqa7PuCtRD/drExmyQ7yotqIigSvMI5ru9IEBYNMTEiu5i X-Received: by 10.112.172.165 with SMTP id bd5mr5060630lbc.51.1444352201511; Thu, 08 Oct 2015 17:56:41 -0700 (PDT) Received: from enkidu.semihalf.local (cardhu.semihalf.com. [213.17.239.108]) by smtp.gmail.com with ESMTPSA id og8sm7668933lbc.5.2015.10.08.17.56.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Oct 2015 17:56:40 -0700 (PDT) From: Marcin Wojtas To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org Cc: ulf.hansson@linaro.org, sebastian.hesselbarth@gmail.com, andrew@lunn.ch, jason@lakedaemon.net, thomas.petazzoni@free-electrons.com, gregory.clement@free-electrons.com, nadavh@marvell.com, alior@marvell.com, tawfik@marvell.com, mw@semihalf.com, jaz@semihalf.com Subject: [PATCH v2 1/5] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC Date: Fri, 9 Oct 2015 03:03:51 +0200 Message-Id: <1444352635-21965-2-git-send-email-mw@semihalf.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1444352635-21965-1-git-send-email-mw@semihalf.com> References: <1444352635-21965-1-git-send-email-mw@semihalf.com> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When resuming from suspend on Armada 38x SoC MBus windows have to be re-configured and for that purpose mv_conf_mbus_windows function needed rework. MBus windows register base address obtaining was moved to armada_38x_quirks function in order to be kept in pxa global structure, because it is used during a resume. This commit fixes resuming from suspend by calling MBus windows configuration routine and therefore enabling proper DMA operation. Signed-off-by: Marcin Wojtas --- drivers/mmc/host/sdhci-pxav3.c | 38 +++++++++++++++++++------------------- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c index f5edf9d..76b9a70 100644 --- a/drivers/mmc/host/sdhci-pxav3.c +++ b/drivers/mmc/host/sdhci-pxav3.c @@ -63,6 +63,7 @@ struct sdhci_pxa { struct clk *clk_io; u8 power_mode; void __iomem *sdio3_conf_reg; + void __iomem *mbus_win_regs; }; /* @@ -81,30 +82,16 @@ struct sdhci_pxa { #define SDIO3_CONF_CLK_INV BIT(0) #define SDIO3_CONF_SD_FB_CLK BIT(2) -static int mv_conf_mbus_windows(struct platform_device *pdev, +static int mv_conf_mbus_windows(struct device *dev, void __iomem *regs, const struct mbus_dram_target_info *dram) { int i; - void __iomem *regs; - struct resource *res; if (!dram) { - dev_err(&pdev->dev, "no mbus dram info\n"); - return -EINVAL; - } - - res = platform_get_resource(pdev, IORESOURCE_MEM, 1); - if (!res) { - dev_err(&pdev->dev, "cannot get mbus registers\n"); + dev_err(dev, "no mbus dram info\n"); return -EINVAL; } - regs = ioremap(res->start, resource_size(res)); - if (!regs) { - dev_err(&pdev->dev, "cannot map mbus registers\n"); - return -ENOMEM; - } - for (i = 0; i < SDHCI_MAX_WIN_NUM; i++) { writel(0, regs + SDHCI_WINDOW_CTRL(i)); writel(0, regs + SDHCI_WINDOW_BASE(i)); @@ -122,8 +109,6 @@ static int mv_conf_mbus_windows(struct platform_device *pdev, writel(cs->base, regs + SDHCI_WINDOW_BASE(i)); } - iounmap(regs); - return 0; } @@ -135,6 +120,14 @@ static int armada_38x_quirks(struct platform_device *pdev, struct sdhci_pxa *pxa = pltfm_host->priv; struct resource *res; + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "mbus"); + pxa->mbus_win_regs = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(pxa->mbus_win_regs)) { + dev_err(mmc_dev(host->mmc), + "failed to obtain MBus windows register base\n"); + return PTR_ERR(pxa->mbus_win_regs); + } + host->quirks &= ~SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN; host->quirks |= SDHCI_QUIRK_MISSING_CAPS; res = platform_get_resource_byname(pdev, IORESOURCE_MEM, @@ -403,7 +396,8 @@ static int sdhci_pxav3_probe(struct platform_device *pdev) ret = armada_38x_quirks(pdev, host); if (ret < 0) goto err_mbus_win; - ret = mv_conf_mbus_windows(pdev, mv_mbus_dram_info()); + ret = mv_conf_mbus_windows(&pdev->dev, pxa->mbus_win_regs, + mv_mbus_dram_info()); if (ret < 0) goto err_mbus_win; } @@ -520,6 +514,12 @@ static int sdhci_pxav3_resume(struct device *dev) { int ret; struct sdhci_host *host = dev_get_drvdata(dev); + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); + struct sdhci_pxa *pxa = pltfm_host->priv; + + if (pxa->mbus_win_regs) + ret = mv_conf_mbus_windows(dev, pxa->mbus_win_regs, + mv_mbus_dram_info()); pm_runtime_get_sync(dev); ret = sdhci_resume_host(host);