From patchwork Wed Jan 27 05:06:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Lin X-Patchwork-Id: 8130451 Return-Path: X-Original-To: patchwork-linux-mmc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C0D5DBEEE5 for ; Wed, 27 Jan 2016 05:16:45 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EBDF1202F2 for ; Wed, 27 Jan 2016 05:16:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 11D4F202E6 for ; Wed, 27 Jan 2016 05:16:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752899AbcA0FL0 (ORCPT ); Wed, 27 Jan 2016 00:11:26 -0500 Received: from lucky1.263xmail.com ([211.157.147.131]:60630 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751805AbcA0FLY (ORCPT ); Wed, 27 Jan 2016 00:11:24 -0500 Received: from shawn.lin?rock-chips.com (unknown [192.168.167.87]) by lucky1.263xmail.com (Postfix) with SMTP id 920168990C; Wed, 27 Jan 2016 13:11:20 +0800 (CST) X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.263.net (Postfix) with ESMTP id 969F741F5; Wed, 27 Jan 2016 13:11:20 +0800 (CST) X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: ulf.hansson@linaro.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-SENDER: lintao@rock-chips.com X-DNS-TYPE: 0 Received: from localhost.localdomain (unknown [58.22.7.114]) by smtp.263.net (Postfix) whith ESMTP id 2702WTMMAE; Wed, 27 Jan 2016 13:11:21 +0800 (CST) From: Shawn Lin To: Ulf Hansson Cc: bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Shawn Lin , Michal Simek , soren.brinkmann@xilinx.com Subject: [RFC PATCH 04/21] mmc: sdhci-of-arasan: consolidate parsing path Date: Wed, 27 Jan 2016 13:06:50 +0800 Message-Id: <1453871210-3453-1-git-send-email-shawn.lin@rock-chips.com> X-Mailer: git-send-email 1.8.0 In-Reply-To: <1453871155-3283-1-git-send-email-shawn.lin@rock-chips.com> References: <1453871155-3283-1-git-send-email-shawn.lin@rock-chips.com> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY, URIBL_BLACK autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch remove mmc_of_parse and check return value of sdhci_get_of_property. Cc: Michal Simek Cc: soren.brinkmann@xilinx.com Signed-off-by: Shawn Lin --- drivers/mmc/host/sdhci-of-arasan.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c index 75379cb..b653ec7 100644 --- a/drivers/mmc/host/sdhci-of-arasan.c +++ b/drivers/mmc/host/sdhci-of-arasan.c @@ -177,17 +177,14 @@ static int sdhci_arasan_probe(struct platform_device *pdev) host->quirks2 |= SDHCI_QUIRK2_HOST_NO_CMD23; } - sdhci_get_of_property(pdev); + ret = sdhci_get_of_property(pdev); + if (ret) + goto clk_disable_all; + pltfm_host = sdhci_priv(host); pltfm_host->priv = sdhci_arasan; pltfm_host->clk = clk_xin; - ret = mmc_of_parse(host->mmc); - if (ret) { - dev_err(&pdev->dev, "parsing dt failed (%u)\n", ret); - goto clk_disable_all; - } - ret = sdhci_add_host(host); if (ret) goto err_pltfm_free;