diff mbox

mmc: sanitize 'bus width' in debug output

Message ID 1454056070-6164-1-git-send-email-wsa@the-dreams.de (mailing list archive)
State New, archived
Headers show

Commit Message

Wolfram Sang Jan. 29, 2016, 8:27 a.m. UTC 
From: Wolfram Sang <wsa+renesas@sang-engineering.com>

The bus width is sometimes the actual bus width, and sometimes indices
to different arrays encoding the bus width. In my debugging case "2"
could mean 8-bit as well as 4-bit, which was extremly confusing. Let's
use the human-readable actual bus width in all places.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/mmc/core/core.c | 2 +-
 drivers/mmc/core/mmc.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Ulf Hansson Feb. 2, 2016, 1:11 p.m. UTC | #1 
On 29 January 2016 at 09:27, Wolfram Sang <wsa@the-dreams.de> wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> The bus width is sometimes the actual bus width, and sometimes indices
> to different arrays encoding the bus width. In my debugging case "2"
> could mean 8-bit as well as 4-bit, which was extremly confusing. Let's
> use the human-readable actual bus width in all places.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/core/core.c | 2 +-
>  drivers/mmc/core/mmc.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index f95d41ffc766e5..746de248defced 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -1033,7 +1033,7 @@ static inline void mmc_set_ios(struct mmc_host *host)
>                 "width %u timing %u\n",
>                  mmc_hostname(host), ios->clock, ios->bus_mode,
>                  ios->power_mode, ios->chip_select, ios->vdd,
> -                ios->bus_width, ios->timing);
> +                1 << ios->bus_width, ios->timing);
>
>         host->ops->set_ios(host, ios);
>  }
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 07a135bc893057..4dbe3df8024b2c 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -945,7 +945,7 @@ static int mmc_select_bus_width(struct mmc_card *card)
>                         break;
>                 } else {
>                         pr_warn("%s: switch to bus width %d failed\n",
> -                               mmc_hostname(host), ext_csd_bits[idx]);
> +                               mmc_hostname(host), 1 << bus_width);
>                 }
>         }
>
> --
> 2.6.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
index f95d41ffc766e5..746de248defced 100644
--- a/drivers/mmc/core/core.c
+++ b/drivers/mmc/core/core.c
@@ -1033,7 +1033,7 @@  static inline void mmc_set_ios(struct mmc_host *host)
 		"width %u timing %u\n",
 		 mmc_hostname(host), ios->clock, ios->bus_mode,
 		 ios->power_mode, ios->chip_select, ios->vdd,
-		 ios->bus_width, ios->timing);
+		 1 << ios->bus_width, ios->timing);
 
 	host->ops->set_ios(host, ios);
 }
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 07a135bc893057..4dbe3df8024b2c 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -945,7 +945,7 @@  static int mmc_select_bus_width(struct mmc_card *card)
 			break;
 		} else {
 			pr_warn("%s: switch to bus width %d failed\n",
-				mmc_hostname(host), ext_csd_bits[idx]);
+				mmc_hostname(host), 1 << bus_width);
 		}
 	}