diff mbox

mmc: core: remove redundant memset of mmc_decode_cid

Message ID 1457714145-6958-1-git-send-email-shawn.lin@rock-chips.com (mailing list archive)
State New, archived
Headers show

Commit Message

Shawn Lin March 11, 2016, 4:35 p.m. UTC
When initializing sd or sdio card, we get struct mmc_card
from mmc_alloc_card which allocates it by kzalloc. So we don't
need another memset while decoding cid.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---

 drivers/mmc/core/sd.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Ulf Hansson March 16, 2016, 11:38 a.m. UTC | #1
On 11 March 2016 at 17:35, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> When initializing sd or sdio card, we get struct mmc_card
> from mmc_alloc_card which allocates it by kzalloc. So we don't
> need another memset while decoding cid.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
>  drivers/mmc/core/sd.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> index bb39a29..b95bd24 100644
> --- a/drivers/mmc/core/sd.c
> +++ b/drivers/mmc/core/sd.c
> @@ -74,8 +74,6 @@ void mmc_decode_cid(struct mmc_card *card)
>  {
>         u32 *resp = card->raw_cid;
>
> -       memset(&card->cid, 0, sizeof(struct mmc_cid));
> -
>         /*
>          * SD doesn't currently have a version field so we will
>          * have to assume we can parse this.
> --
> 2.3.7
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
index bb39a29..b95bd24 100644
--- a/drivers/mmc/core/sd.c
+++ b/drivers/mmc/core/sd.c
@@ -74,8 +74,6 @@  void mmc_decode_cid(struct mmc_card *card)
 {
 	u32 *resp = card->raw_cid;
 
-	memset(&card->cid, 0, sizeof(struct mmc_cid));
-
 	/*
 	 * SD doesn't currently have a version field so we will
 	 * have to assume we can parse this.