| Message ID | 1464983233-27001-2-git-send-email-stefan.wahren@i2se.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 06/03/2016 01:47 PM, Stefan Wahren wrote:
> The sdhci-iproc also supports bcm2835. So this binding is obsolete.
sdhci-iproc supports this binding, so I don't believe the binding is
obsolete. The duplicate implementations (drivers) can possibly be
removed, but not the binding doc, which is (or at least could be) still
in use.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Stephen, > Stephen Warren <swarren@wwwdotorg.org> hat am 3. Juni 2016 um 22:00 > geschrieben: > > > On 06/03/2016 01:47 PM, Stefan Wahren wrote: > > The sdhci-iproc also supports bcm2835. So this binding is obsolete. > > sdhci-iproc supports this binding, so I don't believe the binding is > obsolete. The duplicate implementations (drivers) can possibly be > removed, but not the binding doc, which is (or at least could be) still > in use. sorry for my late reply. So the brcm,bcm2835-sdhci.txt must be kept, even if the compatible string "brcm,bcm2835-sdhci" has been added to brcm,sdhci-iproc.txt? Do i need to send a new version of this series? Stefan > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 06/09/2016 12:11 PM, Stefan Wahren wrote: > Hi Stephen, > >> Stephen Warren <swarren@wwwdotorg.org> hat am 3. Juni 2016 um 22:00 >> geschrieben: >> >> >> On 06/03/2016 01:47 PM, Stefan Wahren wrote: >>> The sdhci-iproc also supports bcm2835. So this binding is obsolete. >> >> sdhci-iproc supports this binding, so I don't believe the binding is >> obsolete. The duplicate implementations (drivers) can possibly be >> removed, but not the binding doc, which is (or at least could be) still >> in use. > > sorry for my late reply. > > So the brcm,bcm2835-sdhci.txt must be kept, even if the compatible string > "brcm,bcm2835-sdhci" has been added to brcm,sdhci-iproc.txt? Sorry for the slow reply; I was on vacation. So, if the binding documentation has been collapsed into the other binding document, then it's OK to remove this one. I took a look at the iproc binding doc and it looks completely compatible with this removed binding doc, so I think this patch is OK. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhci.txt b/Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhci.txt deleted file mode 100644 index 59476fb..0000000 --- a/Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhci.txt +++ /dev/null @@ -1,18 +0,0 @@ -Broadcom BCM2835 SDHCI controller - -This file documents differences between the core properties described -by mmc.txt and the properties that represent the BCM2835 controller. - -Required properties: -- compatible : Should be "brcm,bcm2835-sdhci". -- clocks : The clock feeding the SDHCI controller. - -Example: - -sdhci: sdhci { - compatible = "brcm,bcm2835-sdhci"; - reg = <0x7e300000 0x100>; - interrupts = <2 30>; - clocks = <&clk_mmc>; - bus-width = <4>; -};
The sdhci-iproc also supports bcm2835. So this binding is obsolete. Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> --- .../devicetree/bindings/mmc/brcm,bcm2835-sdhci.txt | 18 ------------------ 1 file changed, 18 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mmc/brcm,bcm2835-sdhci.txt