From patchwork Fri Jul 29 04:15:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Lin X-Patchwork-Id: 9252029 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 74188601C0 for ; Fri, 29 Jul 2016 04:18:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6AA7427E63 for ; Fri, 29 Jul 2016 04:18:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5F5DF27F8F; Fri, 29 Jul 2016 04:18:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 028B727E63 for ; Fri, 29 Jul 2016 04:18:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752321AbcG2ESh (ORCPT ); Fri, 29 Jul 2016 00:18:37 -0400 Received: from lucky1.263xmail.com ([211.157.147.133]:43885 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752304AbcG2ESd (ORCPT ); Fri, 29 Jul 2016 00:18:33 -0400 Received: from shawn.lin?rock-chips.com (unknown [192.168.167.105]) by lucky1.263xmail.com (Postfix) with SMTP id 84AC253B29; Fri, 29 Jul 2016 12:18:19 +0800 (CST) X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.263.net (Postfix) with ESMTP id B810A39C; Fri, 29 Jul 2016 12:18:16 +0800 (CST) X-RL-SENDER: shawn.lin@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <057885b9ccc9b2efc998d696eef9ab68> X-ATTACHMENT-NUM: 0 X-SENDER: lintao@rock-chips.com X-DNS-TYPE: 0 Received: from unknown (unknown [58.22.7.114]) by smtp.263.net (Postfix) whith SMTP id 11195YE7MFV; Fri, 29 Jul 2016 12:18:19 +0800 (CST) From: Shawn Lin To: Heiko Stuebner , Rob Herring , Jaehoon Chung , Ulf Hansson Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, Douglas Anderson , Brian Norris , Feng Xiao , Elaine Zhang , linux-kernel@vger.kernel.org, Shawn Lin Subject: [PATCH 4/5] mmc: dw_mmc: add power domain support Date: Fri, 29 Jul 2016 12:15:02 +0800 Message-Id: <1469765703-30999-5-git-send-email-shawn.lin@rock-chips.com> X-Mailer: git-send-email 1.8.0 In-Reply-To: <1469765703-30999-1-git-send-email-shawn.lin@rock-chips.com> References: <1469765703-30999-1-git-send-email-shawn.lin@rock-chips.com> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We should enable power domain once provided. Otherwise we take risk of bus err as it's maybe in off state before probing. Signed-off-by: Shawn Lin --- drivers/mmc/host/dw_mmc.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 32380d5..8b39168 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -22,6 +22,8 @@ #include #include #include +#include +#include #include #include #include @@ -3024,6 +3026,9 @@ int dw_mci_probe(struct dw_mci *host) host->bus_hz = clk_get_rate(host->ciu_clk); } + pm_runtime_enable(host->dev); + pm_runtime_get_sync(host->dev); + if (!host->bus_hz) { dev_err(host->dev, "Platform data must supply bus speed\n"); @@ -3197,6 +3202,9 @@ err_clk_biu: if (!IS_ERR(host->biu_clk)) clk_disable_unprepare(host->biu_clk); + pm_runtime_put(host->dev); + pm_runtime_disable(host->dev); + return ret; } EXPORT_SYMBOL(dw_mci_probe); @@ -3226,6 +3234,9 @@ void dw_mci_remove(struct dw_mci *host) if (!IS_ERR(host->biu_clk)) clk_disable_unprepare(host->biu_clk); + + pm_runtime_put(host->dev); + pm_runtime_disable(host->dev); } EXPORT_SYMBOL(dw_mci_remove);