From patchwork Thu Jan 5 19:24:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Wahren X-Patchwork-Id: 9499593 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9C88F606B5 for ; Thu, 5 Jan 2017 19:27:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 844D628450 for ; Thu, 5 Jan 2017 19:27:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 78C5F28452; Thu, 5 Jan 2017 19:27:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E338A28450 for ; Thu, 5 Jan 2017 19:27:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763570AbdAET1M (ORCPT ); Thu, 5 Jan 2017 14:27:12 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:57803 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763560AbdAETZk (ORCPT ); Thu, 5 Jan 2017 14:25:40 -0500 Received: from localhost.localdomain ([95.91.4.8]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.167]) with ESMTPSA (Nemesis) id 0M9B9x-1cDPnd09XB-00CQxz; Thu, 05 Jan 2017 20:24:28 +0100 From: Stefan Wahren To: Ulf Hansson Cc: Shawn Guo , Fabio Estevam , Marek Vasut , =?UTF-8?q?Lothar=20Wa=C3=9Fmann?= , linux-mmc@vger.kernel.org, Stefan Wahren Subject: [PATCH next] mmc: mxs-mmc: Fix additional cycles after transmission stop Date: Thu, 5 Jan 2017 19:24:04 +0000 Message-Id: <1483644245-7538-1-git-send-email-stefan.wahren@i2se.com> X-Mailer: git-send-email 1.7.9.5 X-Provags-ID: V03:K0:bmEIq8NTM/o+FVuXGJZ3Vc/YMx4Sk7epoVIpzGJgTkaizkjFvIf liLO0Oi6E3cBStTkh8gnyqGNGDU+AAZulgzHTW3W7f1UNCijX7I4QIdYEmqZxtrHcZ6Slx0 GFwD0R6LF52ma4VBmN5BBlkttFmgB5WbJyll8SMsXs4ULmJZkiRDQZQd6/c64kdJz+xFvE4 nHnfVc8cvWZJctZIEVEAA== X-UI-Out-Filterresults: notjunk:1; V01:K0:bzG8WHUFGu8=:txC7kANjtb9tPbPtjpjhuS DIz0xmFRJ3A2Yv5mbRrSH7ZSfLvvkK8IPASWSSGbePgQkgyOzWVsQBAKqBWxvjJtEYQj1k3dI Xp8YZjv9fvzvACYdD76pNRaiUEkeXNZ66bB/YiuCFreloY8NRxDRgNLJ9mM6gRUXVXryWsrhP Zsip+kwwVcjZPmZuK4j0qwYMBIuS7jK62gIrR366huarTZbUhKVLxUFDy31/weL1+DLvbodLV /kndy2MvXyP8slMM8eqBO5pC/OjFqLug87K798hiiEwDRBtKsSDyFb/GJPLknam07E4Pk8cwy nUVzs9OXsOQBZL28cerh+JWXOSuH8KEnJU5WzgqTFAwxIV/bOqbGKl9QmfdH4MTExvrILO0N+ +IUfyOlnF8byo89T3sClSx+PlUicoOeuaF87KL13AptnzzTkmScIB/j6lmu7mdKTjC4AL398F kalBPeOQgNVrxqRM8iK2LLLSGxlLt+WaiB5GkUuQXk2Vo2BcS48Kk6vdiIj3gJyMpFKvijR7p R1pUgd+V916cxK6K0PlSvNKcKXc+JLKTcLt0QcvwZJZHyMlfBglh8+Omkp+sWdr8QnDPyLMuL LKXqPb9xwEAk3+53U22ts3TFIzcWQByIHRUQ+6V4kyDCf9EEayZljtCk/UqoJCaDc548OoIAl i7fLmNBgI/ViD/bIOJCTe+hOyZf8nMKTcA8qEnfGCFus8UvtYQ3HqVJH2ioaOTWrEKYY= Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP According to the code the intention is to append 8 SCK cycles instead of 4 at end of a MMC_STOP_TRANSMISSION command. But this will never happened because it's an AC command not an ADTC command. So fix this by moving the statement into the right function. Signed-off-by: Stefan Wahren Fixes: e4243f13d10e (mmc: mxs-mmc: add mmc host driver for i.MX23/28) --- drivers/mmc/host/mxs-mmc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c index 44ecebd..c8b8ac6 100644 --- a/drivers/mmc/host/mxs-mmc.c +++ b/drivers/mmc/host/mxs-mmc.c @@ -309,6 +309,9 @@ static void mxs_mmc_ac(struct mxs_mmc_host *host) cmd0 = BF_SSP(cmd->opcode, CMD0_CMD); cmd1 = cmd->arg; + if (cmd->opcode == MMC_STOP_TRANSMISSION) + cmd0 |= BM_SSP_CMD0_APPEND_8CYC; + if (host->sdio_irq_en) { ctrl0 |= BM_SSP_CTRL0_SDIO_IRQ_CHECK; cmd0 |= BM_SSP_CMD0_CONT_CLKING_EN | BM_SSP_CMD0_SLOW_CLKING_EN; @@ -417,8 +420,7 @@ static void mxs_mmc_adtc(struct mxs_mmc_host *host) ssp->base + HW_SSP_BLOCK_SIZE); } - if ((cmd->opcode == MMC_STOP_TRANSMISSION) || - (cmd->opcode == SD_IO_RW_EXTENDED)) + if (cmd->opcode == SD_IO_RW_EXTENDED) cmd0 |= BM_SSP_CMD0_APPEND_8CYC; cmd1 = cmd->arg;