diff mbox

mmc: vub300: Remove bogus check of irqs_queued

Message ID 1484108089-5454-1-git-send-email-shawn.lin@rock-chips.com (mailing list archive)
State New, archived
Headers show

Commit Message

Shawn Lin Jan. 11, 2017, 4:14 a.m. UTC
It's unnecessary to check the irqs_queued value as
it always needs to queue one if irq isn't enabled.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---

 drivers/mmc/host/vub300.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Ulf Hansson Jan. 12, 2017, 12:01 p.m. UTC | #1
On 11 January 2017 at 05:14, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> It's unnecessary to check the irqs_queued value as
> it always needs to queue one if irq isn't enabled.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
>  drivers/mmc/host/vub300.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
> index bb3e0d1..21ea776 100644
> --- a/drivers/mmc/host/vub300.c
> +++ b/drivers/mmc/host/vub300.c
> @@ -640,8 +640,6 @@ static void __vub300_irqpoll_response(struct vub300_mmc_host *vub300)
>                 mutex_lock(&vub300->irq_mutex);
>                 if (vub300->irq_enabled)
>                         mmc_signal_sdio_irq(vub300->mmc);
> -               else if (vub300->irqs_queued)
> -                       vub300->irqs_queued += 1;
>                 else
>                         vub300->irqs_queued += 1;
>                 vub300->irq_disabled = 0;
> --
> 1.9.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
index bb3e0d1..21ea776 100644
--- a/drivers/mmc/host/vub300.c
+++ b/drivers/mmc/host/vub300.c
@@ -640,8 +640,6 @@  static void __vub300_irqpoll_response(struct vub300_mmc_host *vub300)
 		mutex_lock(&vub300->irq_mutex);
 		if (vub300->irq_enabled)
 			mmc_signal_sdio_irq(vub300->mmc);
-		else if (vub300->irqs_queued)
-			vub300->irqs_queued += 1;
 		else
 			vub300->irqs_queued += 1;
 		vub300->irq_disabled = 0;