| Message ID | 1499418535-10161-1-git-send-email-haibo.chen@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Haibo, On 2017/7/7 17:08, Haibo Chen wrote: > Change the default err value to -EINVAL, otherwise signal voltage > will not change to 1V8 if card or controller only support 1V8 for > HS400ES mode. > This description is misleading as hs400(es) must be running under 1.8v vqmmc. But the patch itself is correct. > Fixes: commit 1720d3545b77 ("mmc: core: switch to 1V8 or 1V2 for hs400es mode") > Cc: <stable@vger.kernel.org> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com> > --- > drivers/mmc/core/mmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c > index 92c6167..336a950 100644 > --- a/drivers/mmc/core/mmc.c > +++ b/drivers/mmc/core/mmc.c > @@ -1289,7 +1289,7 @@ int mmc_hs400_to_hs200(struct mmc_card *card) > static int mmc_select_hs400es(struct mmc_card *card) > { > struct mmc_host *host = card->host; > - int err = 0; > + int err = -EINVAL; > u8 val; > > if (!(host->caps & MMC_CAP_8_BIT_DATA)) { > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11 July 2017 at 02:38, Shawn Lin <shawn.lin@rock-chips.com> wrote: > Hi Haibo, > > On 2017/7/7 17:08, Haibo Chen wrote: >> >> Change the default err value to -EINVAL, otherwise signal voltage >> will not change to 1V8 if card or controller only support 1V8 for >> HS400ES mode. >> > > This description is misleading as hs400(es) must be running under > 1.8v vqmmc. But the patch itself is correct. > > >> Fixes: commit 1720d3545b77 ("mmc: core: switch to 1V8 or 1V2 for hs400es >> mode") >> Cc: <stable@vger.kernel.org> >> Signed-off-by: Haibo Chen <haibo.chen@nxp.com> >> --- >> drivers/mmc/core/mmc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c >> index 92c6167..336a950 100644 >> --- a/drivers/mmc/core/mmc.c >> +++ b/drivers/mmc/core/mmc.c >> @@ -1289,7 +1289,7 @@ int mmc_hs400_to_hs200(struct mmc_card *card) >> static int mmc_select_hs400es(struct mmc_card *card) >> { >> struct mmc_host *host = card->host; >> - int err = 0; >> + int err = -EINVAL; >> u8 val; >> if (!(host->caps & MMC_CAP_8_BIT_DATA)) { >> > Seems like Haibo has been busy. Shawn, if you think it's important, could you pick up this and re-submit? Kind regards Uffe -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index 92c6167..336a950 100644 --- a/drivers/mmc/core/mmc.c +++ b/drivers/mmc/core/mmc.c @@ -1289,7 +1289,7 @@ int mmc_hs400_to_hs200(struct mmc_card *card) static int mmc_select_hs400es(struct mmc_card *card) { struct mmc_host *host = card->host; - int err = 0; + int err = -EINVAL; u8 val; if (!(host->caps & MMC_CAP_8_BIT_DATA)) {
Change the default err value to -EINVAL, otherwise signal voltage will not change to 1V8 if card or controller only support 1V8 for HS400ES mode. Fixes: commit 1720d3545b77 ("mmc: core: switch to 1V8 or 1V2 for hs400es mode") Cc: <stable@vger.kernel.org> Signed-off-by: Haibo Chen <haibo.chen@nxp.com> --- drivers/mmc/core/mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)