| Message ID | 1502366898-23691-2-git-send-email-adrian.hunter@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Aug 10, 2017 at 2:08 PM, Adrian Hunter <adrian.hunter@intel.com> wrote: > mmc_return_hold() / mmc_retune_release() are used around a group of > commands to prevent re-tuning between the commands. Re-tuning can still > happen before the first command. In some cases, re-tuning must be > prevented entirely. Add mmc_retune_hold_now() for that purpose. It is > added in preparation for CQE support where it will be used by CQE recovery. > > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > +void mmc_retune_hold_now(struct mmc_host *host) > void mmc_retune_release(struct mmc_host *host) If the only hint we have about how to use these functions is through the commit log we are in trouble, but I would say in this case the function name is kind of half-obvious at least. I think what troubles me is Rusty's API maturity guideline #6 "6. The name tells you how to use it." Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10 August 2017 at 14:08, Adrian Hunter <adrian.hunter@intel.com> wrote: > mmc_return_hold() / mmc_retune_release() are used around a group of > commands to prevent re-tuning between the commands. Re-tuning can still > happen before the first command. In some cases, re-tuning must be > prevented entirely. Add mmc_retune_hold_now() for that purpose. It is > added in preparation for CQE support where it will be used by CQE recovery. > > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> Thanks, applied for next! Kind regards Uffe > --- > drivers/mmc/core/host.c | 6 ++++++ > drivers/mmc/core/host.h | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c > index 1503412f826c..ad88deb2e8f3 100644 > --- a/drivers/mmc/core/host.c > +++ b/drivers/mmc/core/host.c > @@ -111,6 +111,12 @@ void mmc_retune_hold(struct mmc_host *host) > host->hold_retune += 1; > } > > +void mmc_retune_hold_now(struct mmc_host *host) > +{ > + host->retune_now = 0; > + host->hold_retune += 1; > +} > + > void mmc_retune_release(struct mmc_host *host) > { > if (host->hold_retune) > diff --git a/drivers/mmc/core/host.h b/drivers/mmc/core/host.h > index fb6a76a03833..77d6f60d1bf9 100644 > --- a/drivers/mmc/core/host.h > +++ b/drivers/mmc/core/host.h > @@ -19,6 +19,7 @@ > void mmc_retune_enable(struct mmc_host *host); > void mmc_retune_disable(struct mmc_host *host); > void mmc_retune_hold(struct mmc_host *host); > +void mmc_retune_hold_now(struct mmc_host *host); > void mmc_retune_release(struct mmc_host *host); > int mmc_retune(struct mmc_host *host); > void mmc_retune_pause(struct mmc_host *host); > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c index 1503412f826c..ad88deb2e8f3 100644 --- a/drivers/mmc/core/host.c +++ b/drivers/mmc/core/host.c @@ -111,6 +111,12 @@ void mmc_retune_hold(struct mmc_host *host) host->hold_retune += 1; } +void mmc_retune_hold_now(struct mmc_host *host) +{ + host->retune_now = 0; + host->hold_retune += 1; +} + void mmc_retune_release(struct mmc_host *host) { if (host->hold_retune) diff --git a/drivers/mmc/core/host.h b/drivers/mmc/core/host.h index fb6a76a03833..77d6f60d1bf9 100644 --- a/drivers/mmc/core/host.h +++ b/drivers/mmc/core/host.h @@ -19,6 +19,7 @@ void mmc_retune_enable(struct mmc_host *host); void mmc_retune_disable(struct mmc_host *host); void mmc_retune_hold(struct mmc_host *host); +void mmc_retune_hold_now(struct mmc_host *host); void mmc_retune_release(struct mmc_host *host); int mmc_retune(struct mmc_host *host); void mmc_retune_pause(struct mmc_host *host);
mmc_return_hold() / mmc_retune_release() are used around a group of commands to prevent re-tuning between the commands. Re-tuning can still happen before the first command. In some cases, re-tuning must be prevented entirely. Add mmc_retune_hold_now() for that purpose. It is added in preparation for CQE support where it will be used by CQE recovery. Signed-off-by: Adrian Hunter <adrian.hunter@intel.com> --- drivers/mmc/core/host.c | 6 ++++++ drivers/mmc/core/host.h | 1 + 2 files changed, 7 insertions(+)