diff mbox

[v2] mmc: renesas_sdhi: Add r8a7743/5 support

Message ID 1503311897-18807-1-git-send-email-biju.das@bp.renesas.com (mailing list archive)
State New, archived
Headers show

Commit Message

Biju Das Aug. 21, 2017, 10:38 a.m. UTC
Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI
is identical to the R-Car Gen2 family.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
v1->v2
    -Modified the listing SoC's description related to SoC
     with 1 Clock and 2 Clocks

This patch is compiled and tested against linux next tag
next-20170817.

 Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Comments

Geert Uytterhoeven Aug. 21, 2017, 11:30 a.m. UTC | #1
Hi Biju,

On Mon, Aug 21, 2017 at 12:38 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI
> is identical to the R-Car Gen2 family.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> ---
> v1->v2
>     -Modified the listing SoC's description related to SoC
>      with 1 Clock and 2 Clocks
>
> This patch is compiled and tested against linux next tag
> next-20170817.
>
>  Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
> index 4fd8b7a..1e3106e 100644
> --- a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
> +++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
> @@ -15,6 +15,8 @@ Required properties:
>                 "renesas,sdhi-r7s72100" - SDHI IP on R7S72100 SoC
>                 "renesas,sdhi-r8a73a4" - SDHI IP on R8A73A4 SoC
>                 "renesas,sdhi-r8a7740" - SDHI IP on R8A7740 SoC
> +               "renesas,sdhi-r8a7743" - SDHI IP on R8A7743 SoC
> +               "renesas,sdhi-r8a7745" - SDHI IP on R8A7745 SoC
>                 "renesas,sdhi-r8a7778" - SDHI IP on R8A7778 SoC
>                 "renesas,sdhi-r8a7779" - SDHI IP on R8A7779 SoC
>                 "renesas,sdhi-r8a7790" - SDHI IP on R8A7790 SoC
> @@ -33,10 +35,9 @@ Required properties:
>           If 2 clocks are specified by the hardware, you must name them as
>           "core" and "cd". If the controller only has 1 clock, naming is not
>           required.
> -         Below is the number clocks for each supported SoC:
> -          1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790
> -             R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
> -          2: R7S72100
> +         Most supported SoCs only have 1 clock. Devices which have more

That is actually mentioned in the paragraph above:

- clocks: Most controllers only have 1 clock source per channel. However, on
          some variations of this controller, the internal card detection
          logic that exists in this controller is sectioned off to be run by a
          separate second clock source to allow the main core clock to be turned
          off to save power.

so I suggest just integrating the (short) list in that paragraph.

> +         than 1 clock are listed below:
> +         2: R7S72100"

Bogus trailing double quote.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Wolfram Sang Aug. 21, 2017, 11:33 a.m. UTC | #2
> -	  Below is the number clocks for each supported SoC:
> -	   1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790
> -	      R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
> -	   2: R7S72100
> +	  Most supported SoCs only have 1 clock. Devices which have more
> +	  than 1 clock are listed below:
> +	  2: R7S72100"

I like this, but stray " at the end of the line?

With that fixed:

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Biju Das Aug. 21, 2017, 12:13 p.m. UTC | #3
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogZGV2aWNldHJlZS1vd25l
ckB2Z2VyLmtlcm5lbC5vcmcgW21haWx0bzpkZXZpY2V0cmVlLQ0KPiBvd25lckB2Z2VyLmtlcm5l
bC5vcmddIE9uIEJlaGFsZiBPZiBHZWVydCBVeXR0ZXJob2V2ZW4NCj4gU2VudDogMjEgQXVndXN0
IDIwMTcgMTI6MzANCj4gVG86IEJpanUgRGFzIDxiaWp1LmRhc0BicC5yZW5lc2FzLmNvbT4NCj4g
Q2M6IFVsZiBIYW5zc29uIDx1bGYuaGFuc3NvbkBsaW5hcm8ub3JnPjsgUm9iIEhlcnJpbmcgPHJv
YmgrZHRAa2VybmVsLm9yZz47DQo+IE1hcmsgUnV0bGFuZCA8bWFyay5ydXRsYW5kQGFybS5jb20+
OyBXb2xmcmFtIFNhbmcgPHdzYUB0aGUtDQo+IGRyZWFtcy5kZT47IFNpbW9uIEhvcm1hbiA8aG9y
bXNAdmVyZ2UubmV0LmF1PjsgTWFnbnVzIERhbW0NCj4gPG1hZ251cy5kYW1tQGdtYWlsLmNvbT47
IENocmlzIFBhdGVyc29uDQo+IDxDaHJpcy5QYXRlcnNvbjJAcmVuZXNhcy5jb20+OyBkZXZpY2V0
cmVlQHZnZXIua2VybmVsLm9yZzsgTGludXgtUmVuZXNhcw0KPiA8bGludXgtcmVuZXNhcy1zb2NA
dmdlci5rZXJuZWwub3JnPjsgbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnOw0K
PiBMaW51eCBNTUMgTGlzdCA8bGludXgtbW1jQHZnZXIua2VybmVsLm9yZz4NCj4gU3ViamVjdDog
UmU6IFtQQVRDSCB2Ml0gbW1jOiByZW5lc2FzX3NkaGk6IEFkZCByOGE3NzQzLzUgc3VwcG9ydA0K
Pg0KPiBIaSBCaWp1LA0KPg0KPiBPbiBNb24sIEF1ZyAyMSwgMjAxNyBhdCAxMjozOCBQTSwgQmlq
dSBEYXMgPGJpanUuZGFzQGJwLnJlbmVzYXMuY29tPg0KPiB3cm90ZToNCj4gPiBBZGQgc3VwcG9y
dCBmb3IgcjhhNzc0My81IFNvQy4gUmVuZXNhcyBSWi9HMVtNRV0gKFI4QTc3NDMvNSkgU0RISSBp
cw0KPiA+IGlkZW50aWNhbCB0byB0aGUgUi1DYXIgR2VuMiBmYW1pbHkuDQo+ID4NCj4gPiBTaWdu
ZWQtb2ZmLWJ5OiBCaWp1IERhcyA8YmlqdS5kYXNAYnAucmVuZXNhcy5jb20+DQo+ID4gLS0tDQo+
ID4gdjEtPnYyDQo+ID4gICAgIC1Nb2RpZmllZCB0aGUgbGlzdGluZyBTb0MncyBkZXNjcmlwdGlv
biByZWxhdGVkIHRvIFNvQw0KPiA+ICAgICAgd2l0aCAxIENsb2NrIGFuZCAyIENsb2Nrcw0KPiA+
DQo+ID4gVGhpcyBwYXRjaCBpcyBjb21waWxlZCBhbmQgdGVzdGVkIGFnYWluc3QgbGludXggbmV4
dCB0YWcNCj4gPiBuZXh0LTIwMTcwODE3Lg0KPiA+DQo+ID4gIERvY3VtZW50YXRpb24vZGV2aWNl
dHJlZS9iaW5kaW5ncy9tbWMvdG1pb19tbWMudHh0IHwgOSArKysrKy0tLS0NCj4gPiAgMSBmaWxl
IGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkNCj4gPg0KPiA+IGRpZmYg
LS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbW1jL3RtaW9fbW1jLnR4
dA0KPiA+IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21tYy90bWlvX21tYy50
eHQNCj4gPiBpbmRleCA0ZmQ4YjdhLi4xZTMxMDZlIDEwMDY0NA0KPiA+IC0tLSBhL0RvY3VtZW50
YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tbWMvdG1pb19tbWMudHh0DQo+ID4gKysrIGIvRG9j
dW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21tYy90bWlvX21tYy50eHQNCj4gPiBAQCAt
MTUsNiArMTUsOCBAQCBSZXF1aXJlZCBwcm9wZXJ0aWVzOg0KPiA+ICAgICAgICAgICAgICAgICAi
cmVuZXNhcyxzZGhpLXI3czcyMTAwIiAtIFNESEkgSVAgb24gUjdTNzIxMDAgU29DDQo+ID4gICAg
ICAgICAgICAgICAgICJyZW5lc2FzLHNkaGktcjhhNzNhNCIgLSBTREhJIElQIG9uIFI4QTczQTQg
U29DDQo+ID4gICAgICAgICAgICAgICAgICJyZW5lc2FzLHNkaGktcjhhNzc0MCIgLSBTREhJIElQ
IG9uIFI4QTc3NDAgU29DDQo+ID4gKyAgICAgICAgICAgICAgICJyZW5lc2FzLHNkaGktcjhhNzc0
MyIgLSBTREhJIElQIG9uIFI4QTc3NDMgU29DDQo+ID4gKyAgICAgICAgICAgICAgICJyZW5lc2Fz
LHNkaGktcjhhNzc0NSIgLSBTREhJIElQIG9uIFI4QTc3NDUgU29DDQo+ID4gICAgICAgICAgICAg
ICAgICJyZW5lc2FzLHNkaGktcjhhNzc3OCIgLSBTREhJIElQIG9uIFI4QTc3NzggU29DDQo+ID4g
ICAgICAgICAgICAgICAgICJyZW5lc2FzLHNkaGktcjhhNzc3OSIgLSBTREhJIElQIG9uIFI4QTc3
NzkgU29DDQo+ID4gICAgICAgICAgICAgICAgICJyZW5lc2FzLHNkaGktcjhhNzc5MCIgLSBTREhJ
IElQIG9uIFI4QTc3OTAgU29DIEBADQo+ID4gLTMzLDEwICszNSw5IEBAIFJlcXVpcmVkIHByb3Bl
cnRpZXM6DQo+ID4gICAgICAgICAgIElmIDIgY2xvY2tzIGFyZSBzcGVjaWZpZWQgYnkgdGhlIGhh
cmR3YXJlLCB5b3UgbXVzdCBuYW1lIHRoZW0gYXMNCj4gPiAgICAgICAgICAgImNvcmUiIGFuZCAi
Y2QiLiBJZiB0aGUgY29udHJvbGxlciBvbmx5IGhhcyAxIGNsb2NrLCBuYW1pbmcgaXMgbm90DQo+
ID4gICAgICAgICAgIHJlcXVpcmVkLg0KPiA+IC0gICAgICAgICBCZWxvdyBpcyB0aGUgbnVtYmVy
IGNsb2NrcyBmb3IgZWFjaCBzdXBwb3J0ZWQgU29DOg0KPiA+IC0gICAgICAgICAgMTogU0g3M0Ew
LCBSOEE3M0E0LCBSOEE3NzQwLCBSOEE3Nzc4LCBSOEE3Nzc5LCBSOEE3NzkwDQo+ID4gLSAgICAg
ICAgICAgICBSOEE3NzkxLCBSOEE3NzkyLCBSOEE3NzkzLCBSOEE3Nzk0LCBSOEE3Nzk1LCBSOEE3
Nzk2DQo+ID4gLSAgICAgICAgICAyOiBSN1M3MjEwMA0KPiA+ICsgICAgICAgICBNb3N0IHN1cHBv
cnRlZCBTb0NzIG9ubHkgaGF2ZSAxIGNsb2NrLiBEZXZpY2VzIHdoaWNoIGhhdmUNCj4gPiArIG1v
cmUNCj4NCj4gVGhhdCBpcyBhY3R1YWxseSBtZW50aW9uZWQgaW4gdGhlIHBhcmFncmFwaCBhYm92
ZToNCj4NCj4gLSBjbG9ja3M6IE1vc3QgY29udHJvbGxlcnMgb25seSBoYXZlIDEgY2xvY2sgc291
cmNlIHBlciBjaGFubmVsLiBIb3dldmVyLCBvbg0KPiAgICAgICAgICAgc29tZSB2YXJpYXRpb25z
IG9mIHRoaXMgY29udHJvbGxlciwgdGhlIGludGVybmFsIGNhcmQgZGV0ZWN0aW9uDQo+ICAgICAg
ICAgICBsb2dpYyB0aGF0IGV4aXN0cyBpbiB0aGlzIGNvbnRyb2xsZXIgaXMgc2VjdGlvbmVkIG9m
ZiB0byBiZSBydW4gYnkgYQ0KPiAgICAgICAgICAgc2VwYXJhdGUgc2Vjb25kIGNsb2NrIHNvdXJj
ZSB0byBhbGxvdyB0aGUgbWFpbiBjb3JlIGNsb2NrIHRvIGJlIHR1cm5lZA0KPiAgICAgICAgICAg
b2ZmIHRvIHNhdmUgcG93ZXIuDQo+DQo+IHNvIEkgc3VnZ2VzdCBqdXN0IGludGVncmF0aW5nIHRo
ZSAoc2hvcnQpIGxpc3QgaW4gdGhhdCBwYXJhZ3JhcGguDQo+DQo+ID4gKyAgICAgICAgIHRoYW4g
MSBjbG9jayBhcmUgbGlzdGVkIGJlbG93Og0KPiA+ICsgICAgICAgICAyOiBSN1M3MjEwMCINCj4N
Cj4gQm9ndXMgdHJhaWxpbmcgZG91YmxlIHF1b3RlLg0KDQpUaGFua3MuIEkgd2lsbCBzZW5kIHYz
IHdpdGggYWJvdmUgY2hhbmdlcy4NCg0KPiBHcntvZXRqZSxlZXRpbmd9cywNCj4NCj4gICAgICAg
ICAgICAgICAgICAgICAgICAgR2VlcnQNCj4NCj4gLS0NCj4gR2VlcnQgVXl0dGVyaG9ldmVuIC0t
IFRoZXJlJ3MgbG90cyBvZiBMaW51eCBiZXlvbmQgaWEzMiAtLSBnZWVydEBsaW51eC0NCj4gbTY4
ay5vcmcNCj4NCj4gSW4gcGVyc29uYWwgY29udmVyc2F0aW9ucyB3aXRoIHRlY2huaWNhbCBwZW9w
bGUsIEkgY2FsbCBteXNlbGYgYSBoYWNrZXIuIEJ1dA0KPiB3aGVuIEknbSB0YWxraW5nIHRvIGpv
dXJuYWxpc3RzIEkganVzdCBzYXkgInByb2dyYW1tZXIiIG9yIHNvbWV0aGluZyBsaWtlIHRoYXQu
DQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLS0gTGludXMgVG9ydmFsZHMNCj4g
LS0NCj4gVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vi
c2NyaWJlIGRldmljZXRyZWUiIGluIHRoZSBib2R5DQo+IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRv
bW9Admdlci5rZXJuZWwub3JnIE1vcmUgbWFqb3Jkb21vIGluZm8gYXQNCj4gaHR0cDovL3ZnZXIu
a2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sDQoNCg0KDQpSZW5lc2FzIEVsZWN0cm9uaWNz
IEV1cm9wZSBMdGQsIER1a2VzIE1lYWRvdywgTWlsbGJvYXJkIFJvYWQsIEJvdXJuZSBFbmQsIEJ1
Y2tpbmdoYW1zaGlyZSwgU0w4IDVGSCwgVUsuIFJlZ2lzdGVyZWQgaW4gRW5nbGFuZCAmIFdhbGVz
IHVuZGVyIFJlZ2lzdGVyZWQgTm8uIDA0NTg2NzA5Lg0K
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring Aug. 21, 2017, 11:34 p.m. UTC | #4
On Mon, Aug 21, 2017 at 11:38:17AM +0100, Biju Das wrote:
> Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI
> is identical to the R-Car Gen2 family.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> ---
> v1->v2
>     -Modified the listing SoC's description related to SoC
>      with 1 Clock and 2 Clocks
> 
> This patch is compiled and tested against linux next tag
> next-20170817.
> 
>  Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

Acked-by: Rob Herring <robh@kernel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
index 4fd8b7a..1e3106e 100644
--- a/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
+++ b/Documentation/devicetree/bindings/mmc/tmio_mmc.txt
@@ -15,6 +15,8 @@  Required properties:
 		"renesas,sdhi-r7s72100" - SDHI IP on R7S72100 SoC
 		"renesas,sdhi-r8a73a4" - SDHI IP on R8A73A4 SoC
 		"renesas,sdhi-r8a7740" - SDHI IP on R8A7740 SoC
+		"renesas,sdhi-r8a7743" - SDHI IP on R8A7743 SoC
+		"renesas,sdhi-r8a7745" - SDHI IP on R8A7745 SoC
 		"renesas,sdhi-r8a7778" - SDHI IP on R8A7778 SoC
 		"renesas,sdhi-r8a7779" - SDHI IP on R8A7779 SoC
 		"renesas,sdhi-r8a7790" - SDHI IP on R8A7790 SoC
@@ -33,10 +35,9 @@  Required properties:
 	  If 2 clocks are specified by the hardware, you must name them as
 	  "core" and "cd". If the controller only has 1 clock, naming is not
 	  required.
-	  Below is the number clocks for each supported SoC:
-	   1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790
-	      R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
-	   2: R7S72100
+	  Most supported SoCs only have 1 clock. Devices which have more
+	  than 1 clock are listed below:
+	  2: R7S72100"
 
 Optional properties:
 - toshiba,mmc-wrprotect-disable: write-protect detection is unavailable