From patchwork Tue Nov 7 08:09:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 10045847 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 181366032D for ; Tue, 7 Nov 2017 08:11:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 066AB29EED for ; Tue, 7 Nov 2017 08:11:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ECD7B29FA5; Tue, 7 Nov 2017 08:11:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8B04929EED for ; Tue, 7 Nov 2017 08:11:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932641AbdKGILL (ORCPT ); Tue, 7 Nov 2017 03:11:11 -0500 Received: from conuserg-09.nifty.com ([210.131.2.76]:24938 "EHLO conuserg-09.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932539AbdKGIKz (ORCPT ); Tue, 7 Nov 2017 03:10:55 -0500 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-09.nifty.com with ESMTP id vA789u4J027191; Tue, 7 Nov 2017 17:09:57 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com vA789u4J027191 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1510042198; bh=TOu8YvCmwMNxJg5/p52cQaqb3M4eDFL2Kjs5nozs9qc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rULzlUvfY/k/R7p5CIyp6paOwEqOLD2NaekhTkOZAOSt5u4WvnbVJ+J6WebcHJkDp kbTmBsy8kdo30IZFvpLcK7SjioL7MCSoTpBshh9k2rjg36Um4x/40eBcWS1JQFZ5z/ DblAYJm/9eGmxSwYYxxHX4OiSHbgUE6PwRN5F1NlBSrMx6h1fBl8I1ZaqW6/+xq5aD frF9U1JcGfbozYPgzyFkIL/6qhL8PGoekkwYbP+pZ0uXffFtRgiZaZ3yEuS7SMc96I 1l+v84NN0cE8VjQ7/Sdm8tAre/E9Kkd7C5gdwjUxqsE095wAgngC1e49f6OBbNGl00 w+tvvCzFEX3wQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: Wolfram Sang , linux-mmc@vger.kernel.org Cc: Simon Horman , Yoshihiro Shimoda , Masahiro Yamada , linux-kernel@vger.kernel.org, Ulf Hansson Subject: [PATCH 1/6] mmc: renesas_sdhc: remove eprobe jump label Date: Tue, 7 Nov 2017 17:09:27 +0900 Message-Id: <1510042172-27220-2-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1510042172-27220-1-git-send-email-yamada.masahiro@socionext.com> References: <1510042172-27220-1-git-send-email-yamada.masahiro@socionext.com> Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP "goto eprobe" does nothing useful. Return directly. Signed-off-by: Masahiro Yamada --- drivers/mmc/host/renesas_sdhi_core.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c index fcf7235..4b7a4e2 100644 --- a/drivers/mmc/host/renesas_sdhi_core.c +++ b/drivers/mmc/host/renesas_sdhi_core.c @@ -495,9 +495,8 @@ int renesas_sdhi_probe(struct platform_device *pdev, priv->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(priv->clk)) { - ret = PTR_ERR(priv->clk); - dev_err(&pdev->dev, "cannot get clock: %d\n", ret); - goto eprobe; + dev_err(&pdev->dev, "cannot get clock\n"); + return PTR_ERR(priv->clk); } /* @@ -524,10 +523,8 @@ int renesas_sdhi_probe(struct platform_device *pdev, } host = tmio_mmc_host_alloc(pdev); - if (!host) { - ret = -ENOMEM; - goto eprobe; - } + if (!host) + return -ENOMEM; if (of_data) { mmc_data->flags |= of_data->tmio_flags; @@ -652,7 +649,7 @@ int renesas_sdhi_probe(struct platform_device *pdev, tmio_mmc_host_remove(host); efree: tmio_mmc_host_free(host); -eprobe: + return ret; } EXPORT_SYMBOL_GPL(renesas_sdhi_probe);