diff mbox

[2/2] mmc: sd: Remove redundant err assignment from mmc_read_switch

Message ID 1519694795-138735-2-git-send-email-shawn.lin@rock-chips.com (mailing list archive)
State New, archived
Headers show

Commit Message

Shawn Lin Feb. 27, 2018, 1:26 a.m. UTC 
Variable err would be firstly initialized by the return value of
mmc_sd_switch().

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---

 drivers/mmc/core/sd.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Ulf Hansson March 15, 2018, 10:23 a.m. UTC | #1 
On 27 February 2018 at 02:26, Shawn Lin <shawn.lin@rock-chips.com> wrote:
> Variable err would be firstly initialized by the return value of
> mmc_sd_switch().
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
>  drivers/mmc/core/sd.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
> index d094497..329e600 100644
> --- a/drivers/mmc/core/sd.c
> +++ b/drivers/mmc/core/sd.c
> @@ -291,8 +291,6 @@ static int mmc_read_switch(struct mmc_card *card)
>                 return 0;
>         }
>
> -       err = -EIO;
> -
>         status = kmalloc(64, GFP_KERNEL);
>         if (!status)
>                 return -ENOMEM;
> --
> 1.9.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c
index d094497..329e600 100644
--- a/drivers/mmc/core/sd.c
+++ b/drivers/mmc/core/sd.c
@@ -291,8 +291,6 @@  static int mmc_read_switch(struct mmc_card *card)
 		return 0;
 	}
 
-	err = -EIO;
-
 	status = kmalloc(64, GFP_KERNEL);
 	if (!status)
 		return -ENOMEM;