| Message ID | 1522924302-130177-1-git-send-email-shawn.lin@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 5 April 2018 at 12:31, Shawn Lin <shawn.lin@rock-chips.com> wrote: > DDR52 with 8-bit mode should be handled in a different way when > requesting ciu_clk. However DDR50 is used for SDMMC/SDIO and > could never be possible with 8-bit mode. It's trival but misleading. > > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> Thanks, queued for 4.18! Kind regards Uffe > --- > Changes-in-v2: > - reword the comment a bit, mostly suggested by Ulf. > > > drivers/mmc/host/dw_mmc-rockchip.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c > index 40d7de2..8c86a80 100644 > --- a/drivers/mmc/host/dw_mmc-rockchip.c > +++ b/drivers/mmc/host/dw_mmc-rockchip.c > @@ -44,9 +44,8 @@ static void dw_mci_rk3288_set_ios(struct dw_mci *host, struct mmc_ios *ios) > * bus_hz = cclkin / RK3288_CLKGEN_DIV > * ios->clock = (div == 0) ? bus_hz : (bus_hz / (2 * div)) > * > - * Note: div can only be 0 or 1 > - * if DDR50 8bit mode(only emmc work in 8bit mode), > - * div must be set 1 > + * Note: div can only be 0 or 1, but div must be set to 1 for eMMC > + * DDR52 8-bit mode. > */ > if (ios->bus_width == MMC_BUS_WIDTH_8 && > ios->timing == MMC_TIMING_MMC_DDR52) > -- > 1.9.1 > > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c index 40d7de2..8c86a80 100644 --- a/drivers/mmc/host/dw_mmc-rockchip.c +++ b/drivers/mmc/host/dw_mmc-rockchip.c @@ -44,9 +44,8 @@ static void dw_mci_rk3288_set_ios(struct dw_mci *host, struct mmc_ios *ios) * bus_hz = cclkin / RK3288_CLKGEN_DIV * ios->clock = (div == 0) ? bus_hz : (bus_hz / (2 * div)) * - * Note: div can only be 0 or 1 - * if DDR50 8bit mode(only emmc work in 8bit mode), - * div must be set 1 + * Note: div can only be 0 or 1, but div must be set to 1 for eMMC + * DDR52 8-bit mode. */ if (ios->bus_width == MMC_BUS_WIDTH_8 && ios->timing == MMC_TIMING_MMC_DDR52)
DDR52 with 8-bit mode should be handled in a different way when requesting ciu_clk. However DDR50 is used for SDMMC/SDIO and could never be possible with 8-bit mode. It's trival but misleading. Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> --- Changes-in-v2: - reword the comment a bit, mostly suggested by Ulf. drivers/mmc/host/dw_mmc-rockchip.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)