From patchwork Thu Aug 26 22:16:40 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 177422 Return-path: X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on void.printf.net X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.9 tests=RCVD_IN_DNSWL_LOW autolearn=disabled version=3.2.5 Envelope-to: chris@printf.net Delivery-date: Thu, 26 Aug 2010 23:17:30 +0100 Received: from lists.laptop.org ([18.85.2.145] helo=mail.laptop.org) by void.printf.net with esmtp (Exim 4.69) (envelope-from ) id 1OoklF-0000gb-3B for chris@printf.net; Thu, 26 Aug 2010 23:17:29 +0100 Received: by mail.laptop.org (Postfix) id 529C723899; Thu, 26 Aug 2010 18:17:10 -0400 (EDT) Delivered-To: cjb@laptop.org Received: from spam.laptop.org (spam.laptop.org [18.85.46.23]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.laptop.org (Postfix) with ESMTPS id 458A623897 for ; Thu, 26 Aug 2010 18:17:10 -0400 (EDT) X-ASG-Debug-ID: 1282861009-0b7425520002-zHW3sV Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by spam.laptop.org with ESMTP id 23u9ESNLBNFmoRcr for ; Thu, 26 Aug 2010 18:17:27 -0400 (EDT) X-Barracuda-Envelope-From: linux-mmc-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754103Ab0HZWRJ (ORCPT ); Thu, 26 Aug 2010 18:17:09 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:56631 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753836Ab0HZWRJ (ORCPT ); Thu, 26 Aug 2010 18:17:09 -0400 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id o7QMGf5w004264 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 26 Aug 2010 15:16:41 -0700 Received: from akpm.mtv.corp.google.com (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with SMTP id o7QMGePY017797; Thu, 26 Aug 2010 15:16:40 -0700 Date: Thu, 26 Aug 2010 15:16:40 -0700 From: Andrew Morton To: Matt Fleming Cc: Magnus Damm , Yusuke Goda , linux-mmc@vger.kernel.org, Ian Molton , Paul Mundt X-ASG-Orig-Subj: Re: [PATCH] tmio_mmc: Prevents unexpected status clear Subject: Re: [PATCH] tmio_mmc: Prevents unexpected status clear Message-Id: <20100826151640.04d11be0.akpm@linux-foundation.org> In-Reply-To: <20100826221024.GA11300@console-pimps.org> References: <20100708144626.2091f6c1.akpm@linux-foundation.org> <4C3BBE77.8080000@renesas.com> <20100715132552.fcb5791b.akpm@linux-foundation.org> <20100825231107.45227d6a@linux-g6p1.site> <20100825160722.9c9c38c8.akpm@linux-foundation.org> <4C75BB0D.2030202@renesas.com> <20100826075320.0538043b@linux-g6p1.site> <20100826072642.GB19339@console-pimps.org> <20100826141237.c31bc1ed.akpm@linux-foundation.org> <20100826221024.GA11300@console-pimps.org> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.9; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org X-Barracuda-Connect: vger.kernel.org[209.132.180.67] X-Barracuda-Start-Time: 1282861047 X-Barracuda-URL: http://18.85.46.23:8000/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at laptop.org X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=5.5 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.39119 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- diff -puN drivers/mmc/host/tmio_mmc.h~tmio_mmc-dont-clear-unhandled-pending-interrupts drivers/mmc/host/tmio_mmc.h --- a/drivers/mmc/host/tmio_mmc.h~tmio_mmc-dont-clear-unhandled-pending-interrupts +++ a/drivers/mmc/host/tmio_mmc.h @@ -82,10 +82,7 @@ #define ack_mmc_irqs(host, i) \ do { \ - u32 mask;\ - mask = sd_ctrl_read32((host), CTL_STATUS); \ - mask &= ~((i) & TMIO_MASK_IRQ); \ - sd_ctrl_write32((host), CTL_STATUS, mask); \ + sd_ctrl_write32((host), CTL_STATUS, ~(i)); \ } while (0)